Comments (8)
That's fair. My personal greedy side is saying "just implement it ASAP, consequences be damned, I have a personal need for it" but waiting to refractor until v2 is reasonable here I feel.
from shotshare.
Hey @EmberHeartshine, this would definitely be a fairly trivial move to go from auto incrementing IDs to UUIDs, though this would break existing usages of ShotShare (if people have created shots and distributed links to them).
I can see two possible ideas for handling this
- Implement some sort of opt-in feature that would change column behavior
- Hold off on this till version 2 and issue a warning for updating from 1 -> 2 regarding this
Let me know if you have any additional ideas as to how I could go about this!
from shotshare.
I don't know the current logic behind storing what values of shot page correspond to what image, but I imagine there shouldn't be any intersection between UUIDs and numerical shot pages. Would there be any harm to simply changing the way shot page URLs are stored in the database and continue to append past the existing entries? Or are shot pages indexed in such a way that makes that change impossible?
from shotshare.
I don't know the current logic behind storing what values of shot page correspond to what image, but I imagine there shouldn't be any intersection between UUIDs and numerical shot pages. Would there be any harm to simply changing the way shot page URLs are stored in the database and continue to append past the existing entries? Or are shot pages indexed in such a way that makes that change impossible?
I have never actually mixed UUIDs & auto incrementing IDs, though they would never intersect. Let me sit on this one for a little bit and dive into any of the UUID helpers that are built into Laravel to make sure mixing these wouldn't break anything.
In MySQL a UUID is not a special datatype (so this column would just shift to a varchar), I would wonder if this would have a negative impact on databases that do possess special data types for UUIDs (I think Postgres has this).
from shotshare.
After thinking about it a little bit more, I will comment that this is a blocking issue for me-- that is, I can't deploy ShotShare in the capacity I need it (without #23 fixed, anyway). If you don't want to do the refactor until 2.0 anyway then I totally get it, but I was a little more flippant with my previous comment than I intended.
It looks like you have #23 on the roadmap for 1.7.0, however, so this may be a non-issue.
from shotshare.
After thinking about it a little bit more, I will comment that this is a blocking issue for me-- that is, I can't deploy ShotShare in the capacity I need it (without #23 fixed, anyway). If you don't want to do the refactor until 2.0 anyway then I totally get it, but I was a little more flippant with my previous comment than I intended.
It looks like you have #23 on the roadmap for 1.7.0, however, so this may be a non-issue.
Hey @EmberHeartshine, I have an "opt-in" UUID solution in my working branch, we should see this feature in 1.7.0. You can see that progress here.
from shotshare.
This functionality has just been rolled out in 1.7.0; lemme me know if you have any questions!
see FEATURE_UUID_ROUTES
here
from shotshare.
This is so awesome.
Seriously, you're doing amazing work implementing feature requests from some random schmuck on the internet. You need a tip jar or Patreon or something.
from shotshare.
Related Issues (20)
- Better way to indicate that a shot's title is editable HOT 8
- Ability to hide/privatize uploader name HOT 3
- Ability to choose whether to upload multiple images as a set or as individual shots HOT 4
- Deleted images is still be accessable via direct link HOT 6
- [Enhancement] Store config in a configuration file instead of relying on environment variables HOT 3
- 419 Page expired HOT 16
- Be able to upload an avatar HOT 2
- Image preview embed for Discord et. al. HOT 7
- Blank home page HOT 5
- Sharing link buttons not working HOT 1
- Shot visibility issue HOT 1
- Cloud-based Providers (S3) Support
- Laravel Octane + FrankenPHP
- Optional EXIF Stripping
- "Server Error" HOT 1
- [ERROR] Create user via CLI - could not find driver HOT 1
- Allow videos to be uploaded HOT 1
- User invitations
- Web installer for first time run
- Guest access
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shotshare.