Comments (7)
The reason that the changes above don't work is that they rely on javascript injecting the tags. Most metdata scrapers don't render pages, they just fetch the base HTML and look for tags.
This PR should do what's needed: #62
from shotshare.
Spent a fair bit of time testing on this, no matter what meta tags I tried, I was not able to get Discord displaying these images from the shot view, will revisit this soon though and see if I can figure it out.
from shotshare.
Even <meta property="og:image" content="[image link]">
?
from shotshare.
Indeed @EmberHeartshine, here's some of the tags I tried.
from shotshare.
I'm not familiar with vue formatting, is the colon before content
removed when processing for the client?
from shotshare.
I'm not familiar with vue formatting, is the colon before
content
removed when processing for the client?
Correct, :
indicates an expression as opposed to a static value
from shotshare.
The reason that the changes above don't work is that they rely on javascript injecting the tags. Most metdata scrapers don't render pages, they just fetch the base HTML and look for tags.
This PR should do what's needed: #62
Good catch and thank you for opening a PR!
from shotshare.
Related Issues (20)
- Better way to indicate that a shot's title is editable HOT 8
- Ability to hide/privatize uploader name HOT 3
- Ability to choose whether to upload multiple images as a set or as individual shots HOT 4
- Deleted images is still be accessable via direct link HOT 6
- [Enhancement] Store config in a configuration file instead of relying on environment variables HOT 3
- 419 Page expired HOT 16
- Be able to upload an avatar HOT 2
- Blank home page HOT 5
- Sharing link buttons not working HOT 1
- Shot visibility issue HOT 1
- Cloud-based Providers (S3) Support
- Laravel Octane + FrankenPHP
- Optional EXIF Stripping
- "Server Error" HOT 1
- [ERROR] Create user via CLI - could not find driver HOT 1
- Allow videos to be uploaded HOT 1
- User invitations
- Web installer for first time run
- Guest access
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shotshare.