Giter Club home page Giter Club logo

Comments (7)

bentasker avatar bentasker commented on August 15, 2024 1

The reason that the changes above don't work is that they rely on javascript injecting the tags. Most metdata scrapers don't render pages, they just fetch the base HTML and look for tags.

This PR should do what's needed: #62

from shotshare.

mdshack avatar mdshack commented on August 15, 2024

Spent a fair bit of time testing on this, no matter what meta tags I tried, I was not able to get Discord displaying these images from the shot view, will revisit this soon though and see if I can figure it out.

from shotshare.

EmberHeartshine avatar EmberHeartshine commented on August 15, 2024

Even <meta property="og:image" content="[image link]"> ?

from shotshare.

mdshack avatar mdshack commented on August 15, 2024

Indeed @EmberHeartshine, here's some of the tags I tried.

from shotshare.

EmberHeartshine avatar EmberHeartshine commented on August 15, 2024

I'm not familiar with vue formatting, is the colon before content removed when processing for the client?

from shotshare.

mdshack avatar mdshack commented on August 15, 2024

I'm not familiar with vue formatting, is the colon before content removed when processing for the client?

Correct, : indicates an expression as opposed to a static value

from shotshare.

mdshack avatar mdshack commented on August 15, 2024

The reason that the changes above don't work is that they rely on javascript injecting the tags. Most metdata scrapers don't render pages, they just fetch the base HTML and look for tags.

This PR should do what's needed: #62

Good catch and thank you for opening a PR!

from shotshare.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.