mchlnix / amazoncheck Goto Github PK

It is possible, that prices are taken as the minimum and/or displayed as the current price, although the shipping costs from the merchant would make the combined price higher, than the last minimum. This needs to be taken into account.

Mirroring the log file is overkill and not user friendly. The output should merely contain:

• The current runs number
• If an article changes in price
• any connection issues ( only once per run would be optimal )

This probably means, that the write_log_file function needs to be changed.

The log file is meant to give a perspective of what happens, when the program isn't running in 'VERBOSE MODE' or if the program crashes, so keeping the output of older runs in the log file is unnecessary and potentially clogs up the hard drive and the programs startup.

What it says up there. Even the next run doesn't recognize the result.

If the program was called in VERBOSE - mode earlier, then it outputs log information to the console, even if it is called in SILENT - mode. This could be fixed, by always starting the program in SILENT - mode and first thing after loading the old config, if necessary, process the arguments and behave accordingly.

It would be more informative, if the notification gave special notice to noticeable price drops and hikes producing a new minimum or maximum ( or reaching the old one ).

As of right now the program only looks for the bold red price on the product page and does not take into account, that there may be cheaper alternative merchants.

See also the issue about not taking the shipping costs into consideration.

Make it an option or an iteration to display the articles not in a treeview, but in an interface similar to what a twitter client might look like.

Tested on BackTrack 5. Indicator didn't know the get_menu method.
Problems with writing images.

Could also enable a sortable TreeView implementation.

In the German amazon layout it only finds the used price, without the shipping cost.

Right now, if the daemon is running and new articles get added they are not updated until the daemon gets restarted. This can be changed by making the daemon read the .data file with every new run.

Articles can be added but not deleted as of yet, so there should be a way to do that ( at the moment the user needs to alter the .amazonCheck/aC.data file ).

A prognosis function would display the likelihood that a price would go up or down, but given the current, average and min/max prices, the users should be able to make that judgment by themselves.

It seems a useful prognosis formula would transcend the scope of this application.

We check if the data file is there and we have permission to read it, but no check is done if the data in the file is actually in coherent and legal json format. One user trying to manipulate it and all goes down the drain.

Refractor the startup code for better overview of what it does.

Especially the argument processing needs a better look, maybe a specific function returning keywords that then later get processed.