mchllngr / mchllngr-slack-bot Goto Github PK
View Code? Open in Web Editor NEWLicense: Apache License 2.0
License: Apache License 2.0
Should they see some empty state or some kind of default values?
In the case of reviewList: If the absence API is slow it may take a while to handle the request. In that case slack shows an error, presumably because the context.ack()
is send after the request is handled completely. Maybe doing the context.ack()
before fixes this issue for everything.
Currently each Script
has a unique id
, but when e.g. multiple Script
s register themselfes as BlockAction
s they could use the same String
/Pattern
, but only the last one would actually be used, overriding previous ones.
Same goes for other things like Command
s etc.
As an example, the following val id: String
and val idRegex: RegexKt
should be unique.
sealed class BlockActionId {
sealed class User : BlockActionId() {
data class Str(val id: String) : User()
data class Regex(val idRegex: RegexKt) : User()
}
// ...
}
This is already added, but in a very limited way. This should be done in a more general concept, maybe with some kind of "admin only" script?
Right now it's pretty hacky after making it work with the modal setup, but surely it can be simplified.
Maybe by changing blockId
and/or actionId
of the ConfigBlock
s inside the modal, because maybe those don't need to be so strictly unique after moving to the modal setup anymore?
Then script-admins can enable/disable as well
check enabled-state with a list of ids so that only one db-request is needed ("get all enabled=true from db")
like commit-hash, build-time, etc.
by itself or only via AdminService?
Create something like the following table to generally allow making one or more users admins for a specific script.
CREATE TABLE scriptAdmin(
id INTEGER AS ScriptAdminId NOT NULL PRIMARY KEY AUTO_INCREMENT,
scriptId INTEGER AS ScriptId NOT NULL,
userId VARCHAR(256) AS UserId NOT NULL,
CONSTRAINT fk_scriptadmin_script_id FOREIGN KEY (scriptId) REFERENCES script(id) ON DELETE CASCADE ON UPDATE CASCADE,
CONSTRAINT fk_scriptadmin_user_id FOREIGN KEY (userId) REFERENCES user(id) ON DELETE CASCADE ON UPDATE CASCADE
);
The absence-API is case sensitive when filtering for emails
e.g [email protected] != [email protected]
Because of this the emails for filtering should include one all lower case and one with the first and each character after a .
in upper case.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.