mchllngr / mchllngr-slack-bot Goto Github PK

In the case of reviewList: If the absence API is slow it may take a while to handle the request. In that case slack shows an error, presumably because the context.ack() is send after the request is handled completely. Maybe doing the context.ack() before fixes this issue for everything.

Should they see some empty state or some kind of default values?

Right now it's pretty hacky after making it work with the modal setup, but surely it can be simplified.
Maybe by changing blockId and/or actionId of the ConfigBlocks inside the modal, because maybe those don't need to be so strictly unique after moving to the modal setup anymore?

check enabled-state with a list of ids so that only one db-request is needed ("get all enabled=true from db")

• allow enabling overall and on a team-basis?

https://docs.docker.com/compose/compose-file/compose-versioning/

• Allow Admins to specify allowed users for a script dynamically on Home

Create something like the following table to generally allow making one or more users admins for a specific script.

CREATE TABLE scriptAdmin(
    id INTEGER AS ScriptAdminId NOT NULL PRIMARY KEY AUTO_INCREMENT,
    scriptId INTEGER AS ScriptId NOT NULL,
    userId VARCHAR(256) AS UserId NOT NULL,
    CONSTRAINT fk_scriptadmin_script_id FOREIGN KEY (scriptId) REFERENCES script(id) ON DELETE CASCADE ON UPDATE CASCADE,
    CONSTRAINT fk_scriptadmin_user_id FOREIGN KEY (userId) REFERENCES user(id) ON DELETE CASCADE ON UPDATE CASCADE
);

This is already added, but in a very limited way. This should be done in a more general concept, maybe with some kind of "admin only" script?

like commit-hash, build-time, etc.

Then script-admins can enable/disable as well

Currently each Script has a unique id, but when e.g. multiple Scripts register themselfes as BlockActions they could use the same String/Pattern, but only the last one would actually be used, overriding previous ones.

Same goes for other things like Commands etc.

As an example, the following val id: String and val idRegex: RegexKt should be unique.

sealed class BlockActionId {

    sealed class User : BlockActionId() {

        data class Str(val id: String) : User()

        data class Regex(val idRegex: RegexKt) : User()
    }

    // ...
}

The absence-API is case sensitive when filtering for emails
e.g [email protected] != [email protected]

Because of this the emails for filtering should include one all lower case and one with the first and each character after a . in upper case.

by itself or only via AdminService?

https://documenter.getpostman.com/view/799228/absenceio-api-documentation/2Fwbis#intro

• correctly setup docker tags for images (e.g. latest, semver, ...)