mcansh / remix-fastify Goto Github PK

  if (Buffer.isBuffer(response.body)) {
    // in 1.4.3 this block was called, worked fine
    reply.send(response.body);
  } else if ((_response$body = response.body) !== null && _response$body !== void 0 && _response$body.pipe) {
    // in 1.5.1 this block not called because ` _response$body.pipe` is `undefined`
    response.body.pipe(reply.raw);
  } else {
    // in 1.5.1 this block is called and response body is empty
    reply.send();
  }

[redacted]/node_modules/@mcansh/remix-fastify/dist/index.mjs:12
  AbortController,
  ^^^^^^^^^^^^^^^
SyntaxError: Named export 'AbortController' not found. The requested module '@remix-run/node' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

"dependencies": {
    "@mcansh/remix-fastify": "^2.6.0",
    "@remix-run/node": "^1.14.1",
    "@remix-run/react": "^1.14.1",
    "fastify": "^4.14.1",
    "isbot": "^3.6.6",
    "react": "^18.2.0",
    "react-dom": "^18.2.0"
  }

PS D:\Data\code\test\my-remix-fastify-test> npm run dev

> dev
> npm run build && run-p dev:*


> build
> remix build

Building Remix app in production mode...
Built in 619ms

> dev:remix
> remix dev


> dev:server
> node --require dotenv/config --watch ./server.js

(node:1696) ExperimentalWarning: Watch mode is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
✅ app ready: http://0.0.0.0:3000
Loading environment variables from .env
node:internal/validators:163
    throw new ERR_INVALID_ARG_TYPE(name, 'string', value);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received null
    at new NodeError (node:internal/errors:399:5)
    at validateString (node:internal/validators:163:11)
    at resolve (node:path:167:9)
    at FSWatcher.<anonymous> (node:internal/watch_mode/files_watcher:94:30)
    at FSWatcher.emit (node:events:513:28)
    at FSWatcher._handle.onchange (node:internal/fs/watchers:215:12) {
  code: 'ERR_INVALID_ARG_TYPE'
}

Node.js v18.14.2
💿 Built in 688ms
ERROR: "dev:server" exited with 1.

> dev
> cross-env NODE_ENV=development node --watch-path ./server.js --enable-source-maps ./server.js

(node:27007) ExperimentalWarning: Watch mode is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Failed running './server.js'

AssertionError [ERR_ASSERTION]: The first character of a path should be `/` or `*`
    at Router.on (Q:\example\node_modules\find-my-way\index.js:107:3)
    at Object.addNewRoute (Q:\example\node_modules\fastify\lib\route.js:271:16)
    at Object.route (Q:\example\node_modules\fastify\lib\route.js:203:19)
    at Object.prepareRoute (Q:\example\node_modules\fastify\lib\route.js:142:18)
    at Object._get [as get] (Q:\example\node_modules\fastify\fastify.js:244:34)
    at remixFastify (Q:\example\node_modules\@mcansh\remix-fastify\src\plugin.ts:71:13)
    at Plugin.exec (Q:\example\node_modules\avvio\plugin.js:130:19)
    at Boot.loadPlugin (Q:\example\node_modules\avvio\plugin.js:272:10)
    at processTicksAndRejections (node:internal/process/task_queues:83:21) {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: false,
  expected: true,
  operator: '=='
}

const app = fastify({
  http2: true,
});

const handler = createRequestHandler({..});

return handler(request, reply);

Argument of type 'FastifyRequest<RouteGenericInterface, Http2Server, Http2ServerRequest, FastifySchema, FastifyTypeProviderDefault, unknown, FastifyBaseLogger, ResolveFastifyRequestType<...>>' is not assignable to parameter of type 'FastifyRequest<RouteGenericInterface, RawServerDefault, IncomingMessage, FastifySchema, FastifyTypeProviderDefault, unknown, FastifyBaseLogger, ResolveFastifyRequestType<...>>'.
  Type 'Http2ServerRequest' is missing the following properties from type 'IncomingMessage': headersDistinct, trailersDistinctts(2345)
(parameter) request: FastifyRequest<RouteGenericInterface, Http2Server, Http2ServerRequest, FastifySchema, FastifyTypeProviderDefault, unknown, FastifyBaseLogger, ResolveFastifyRequestType<...>>

 WARN  Issues with peer dependencies found
.
└─┬ @mcansh/remix-fastify 2.7.3
  ├── ✕ missing peer @remix-run/router@^1.5.0
  └── ✕ missing peer fastify@"^3.29.0 || ^4.0.0"
Peer dependencies that should be installed:
  @remix-run/router@^1.5.0     fastify@"^3.29.0 || ^4.0.0"  

{
  "private": true,
  "sideEffects": false,
  "scripts": {
    "build": "remix build",
    "dev": "npm-run-all build --parallel \"dev:*\"",
    "dev:node": "cross-env NODE_ENV=development nodemon --require dotenv/config ./server.js --watch ./server.js",
    "dev:remix": "remix watch",
    "start": "cross-env NODE_ENV=production node ./server.js",
    "typecheck": "tsc",
    "aws:bundle": "grunt bundle"
  },
  "dependencies": {
    "@mcansh/remix-fastify": "^2.7.3",
    "@remix-run/css-bundle": "^1.16.1",
    "@remix-run/express": "^1.16.1",
    "@remix-run/node": "^1.16.1",
    "@remix-run/react": "^1.16.1",
    "compression": "^1.7.4",
    "cross-env": "^7.0.3",
    "express": "^4.18.2",
    "isbot": "^3.6.8",
    "morgan": "^1.10.0",
    "react": "^18.2.0",
    "react-dom": "^18.2.0"
  },
  "devDependencies": {
    "@remix-run/dev": "^1.16.1",
    "@remix-run/eslint-config": "^1.16.1",
    "@types/compression": "^1.7.2",
    "@types/express": "^4.17.17",
    "@types/morgan": "^1.9.4",
    "@types/react": "^18.0.35",
    "@types/react-dom": "^18.0.11",
    "dotenv": "^16.0.3",
    "eslint": "^8.38.0",
    "grunt": "^1.6.1",
    "grunt-contrib-clean": "^2.0.1",
    "grunt-contrib-copy": "^1.0.0",
    "grunt-exec": "^3.0.0",
    "nodemon": "^2.0.22",
    "npm-run-all": "^4.1.5",
    "typescript": "^5.0.4"
  },
  "engines": {
    "node": ">=14"
  }
}

NPM Error: npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@remix-run%2fnode - Not found
npm ERR! 404 
npm ERR! 404  '@remix-run/[email protected]' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! A complete log of this run can be found in:
npm ERR!     /app/.npm/_logs/2021-09-22T08_03_55_954Z-debug.log

NPM Error: npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@remix-run%2fnode - Not found
npm ERR! 404 
npm ERR! 404  '@remix-run/[email protected]' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! A complete log of this run can be found in:
npm ERR!     /app/.npm/_logs/2021-09-21T08_02_24_032Z-debug.log

NPM Error: npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@remix-run%2fnode - Not found
npm ERR! 404 
npm ERR! 404  '@remix-run/[email protected]' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! A complete log of this run can be found in:
npm ERR!     /app/.npm/_logs/2021-09-20T07_42_09_944Z-debug.log

NPM Error: npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@remix-run%2fnode - Not found
npm ERR! 404 
npm ERR! 404  '@remix-run/[email protected]' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! A complete log of this run can be found in:
npm ERR!     /app/.npm/_logs/2021-09-24T15_25_55_361Z-debug.log

NPM Error: npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@remix-run%2fnode - Not found
npm ERR! 404 
npm ERR! 404  '@remix-run/[email protected]' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! A complete log of this run can be found in:
npm ERR!     /app/.npm/_logs/2021-09-23T14_50_01_805Z-debug.log

NPM Error: npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@remix-run%2fnode - Not found
npm ERR! 404 
npm ERR! 404  '@remix-run/[email protected]' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! A complete log of this run can be found in:
npm ERR!     /app/.npm/_logs/2021-09-22T15_02_48_518Z-debug.log

npm i @mcansh/remix-fastify

export default function () {
  return <div>hello world</div>;
}

Error: Cannot set headers after they are sent to the client
    at new NodeError (node:internal/errors:393:5)
    at ServerResponse.setHeader (node:_http_outgoing:644:11)
    at ServerResponse.writeHead (node:_http_server:377:21)
    at onSendEnd (node_modules/fastify/lib/reply.js:598:7)
    at onSendHook (node_modules/fastify/lib/reply.js:529:5)
    at fallbackErrorHandler (node_modules/fastify/lib/error-handler.js:130:3)
    at handleError (node_modules/fastify/lib/error-handler.js:60:5)
    at onErrorHook (node_modules/fastify/lib/reply.js:699:5)
    at _Reply.Reply.send (node_modules/fastify/lib/reply.js:133:5)
    at defaultErrorHandler (node_modules/fastify/lib/error-handler.js:91:9)

      <button
        onClick={() => {
          fetcher.submit(
            { foo: "bar" },
            {
              method: "POST",
              action: "/test",
              encType: "application/json",
            }
          );
        }}
      >
        test
      </button>

export const action = async ({ request }: ActionArgs) => {
  console.log(await request.json());
  return null;
};

  await app.register(remixFastifyPlugin, {
    build: path.join(__dirname, '../build/index.js'), // resolves fine
    mode: isDev ? 'development' : 'production',
  });

let remixFastify = async (fastify, options = {}) => {
  let {build, mode = process.env.NODE_ENV} = options;
  (0, import_tiny_invariant.default)(build, "You must provide a build");

  console.error(build)  // resolves fine to D:\apps\xx\frontend\build\index.js
  console.error(typeof build === "string" ) // true
  console.error(resolvedBuild) // {}


  let resolvedBuild = typeof build === "string" ? require(build) : build;  // require(build) resolves to {}

  if (!fastify.hasContentTypeParser("*")) {
    fastify.addContentTypeParser("*", (_request, payload, done) => {
      done(null, payload);
    });
  }
  fastify.register(import_fastify_racing.default, {handleError: true});
  let ROOT_DIR = process.cwd();
  let PUBLIC_DIR = path.join(ROOT_DIR, "public");
  let ASSET_DIR = path.join(ROOT_DIR, resolvedBuild.assetsBuildDirectory); // resolvedBuild.assetsBuildDirectory is undefined - error

[20:25:17.890] ERROR: Promise may not be fulfilled with 'undefined' when statusCode is not 204 {"reqId":"req-1"}
    err: {
      "type": "FastifyError",
      "message": "Promise may not be fulfilled with 'undefined' when statusCode is not 204",
      "stack":
          FastifyError: Promise may not be fulfilled with 'undefined' when statusCode is not 204
              at D:\apps\pandahub\node_modules\.pnpm\[email protected]\node_modules\fastify\lib\wrapThenable.js:30:30
              at processTicksAndRejections (node:internal/process/task_queues:96:5)
      "name": "FastifyError",
      "code": "FST_ERR_PROMISE_NOT_FULFILLED",
      "statusCode": 500
    }

  if (nodeRes.body) {
    await writeReadableStreamToWritable(nodeRes.body, reply.raw);
    // fastify.sent is false
    // fastify.send() not called
  }