mbd-s / artbot Goto Github PK

Make sure to document both how to setup the application (secret keys, seed tasks, etc) as well as how to run the thin server. Two months from now you'll be trying to remember yourself!

The .alert-error class has 3 different styles assigned to it, across these files:

• artists.scss
• questions.scss
• application.css.sass

Due to the default behavior of the asset pipeline, all three of these files are loaded/applied to every page on your site, meaning likely only the style in application.css.sass is being applied. Given that this is a site-wide style, and not resource-specific, it makes sense to keep it in application.css.sass

Pick one and stick to it!

Currently there is a .css.sass file, as well as .scss files

You're in a good position to refactor artbot.rb.

One thing that stands out is that every message hash shares the same type and channel:

{
  type: 'message', # always the same
  text: "https://slack-artbot.herokuapp.com/arts/#{@@current_art.id}", # this changes
  channel: data['channel'] # always the same
}

One approach would be to use the merge method to establish some defaults, i.e.:

defaults = {"default": "info"}
config = {"specific": "data"}

defaults.merge(config) # {"default": "info", "specific": "data}

This allows you to both set, and override default configurations.

As you go through, keep in mind Sandi Metz rules: https://robots.thoughtbot.com/sandi-metz-rules-for-developers