maybeec / oomph-task-unzip Goto Github PK

If there is a whitespace in MSI file path, the extraction fails:

Execute: msiexec /a "I:\eclipse\Neuer Ordner\temp\nodejs.msi" /qn TARGETDIR="I:\eclipse\Neuer Ordner\software\nodejs\" @ I:\eclipse\Neuer Ordner
Performing cli install.nodejs.cleanup.msi
Execute: del "I:\eclipse\Neuer Ordner\software\nodejs\nodejs.msi" @ I:\eclipse\Neuer Ordner
I:\eclipse\Neuer Ordner\software\nodejs\nodejs.msi konnte nicht gefunden werden

When the target directory contains an open handle. The task is failing with an
The requested operation cannot be performed on a file with a user-mapped section open

Would be nice to have an ignore failures or skip if already existing.

Starting Unzip process Archive: C:\Users\sholzer\test\temp\elasticsearch-2.3.0.zip Destination: C:\Users\sholzer\test\software Unarchiving Extracting elasticsearch-2.3.0/README.textile com.github.maybeec.oomph.task.unzip.core.exceptions.UnzipTaskException: java.io.FileNotFoundException: C:\Users\sholzer\test\software\elasticsearch-2.3.0\README.textile (The system cannot find the path specified) at com.github.maybeec.oomph.task.unzip.core.impl.UnzipUtilImpl.unzip(UnzipUtilImpl.java:86)

At this time the folder elasticsearch-2.3.0 isn't created. I think this may be the problem

The following exception is thrown at setup task execution:

Bundle com.github.maybeec.oomph.task.unzip 1.0.0.201610121435
Bundle org.eclipse.oomph.setup 1.6.0.v20160920-0456, build=2617, branch=2d2865a4ea3642019005845421c65b1a0d87c679
Bundle org.eclipse.oomph.setup.core 1.6.0.v20160920-1303, build=2617, branch=2d2865a4ea3642019005845421c65b1a0d87c679
Bundle org.eclipse.oomph.setup.maven 1.6.0.v20160920-0456, build=2617, branch=2d2865a4ea3642019005845421c65b1a0d87c679
Bundle org.eclipse.oomph.setup.p2 1.6.0.v20160920-0456, build=2617, branch=2d2865a4ea3642019005845421c65b1a0d87c679
Performing unzip
Starting Unzip process
Archive: C:\Projekte\IDE\tapir-showcase-latest\ws\tapir-showcase.zip
Destination: tapir-showcase
java.lang.NoClassDefFoundError: org/codehaus/plexus/archiver/zip/ZipUnArchiver
  at com.github.maybeec.oomph.task.unzip.core.impl.UnzipUtilImpl.getUnArchiver(UnzipUtilImpl.java:65)
  at com.github.maybeec.oomph.task.unzip.core.impl.UnzipUtilImpl.unzip(UnzipUtilImpl.java:28)
  at com.github.maybeec.oomph.task.unzip.impl.unzipTaskImpl.perform(unzipTaskImpl.java:310)
  at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer.doPerformNeededSetupTasks(SetupTaskPerformer.java:3131)
  at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer.access$1(SetupTaskPerformer.java:3074)
  at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer$WorkspaceUtil$1.run(SetupTaskPerformer.java:4295)
  at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2241)
  at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer$WorkspaceUtil.performNeededSetupTasks(SetupTaskPerformer.java:4289)
  at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer$WorkspaceUtil.access$0(SetupTaskPerformer.java:4287)
  at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer.performNeededSetupTasks(SetupTaskPerformer.java:3065)
  at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer.performTriggeredSetupTasks(SetupTaskPerformer.java:3040)
  at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer.perform(SetupTaskPerformer.java:2940)
  at org.eclipse.oomph.setup.ui.wizards.ProgressPage$9.run(ProgressPage.java:556)
  at org.eclipse.oomph.setup.ui.wizards.ProgressPage$11$1.run(ProgressPage.java:682)
  at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

A mvn clean install (or package) of the "task-unzip" submodule fails with the following error on several machines/setups:

[INFO] --- tycho-compiler-plugin:0.22.0:compile (default-compile) @ com.github.maybeec.oomph.task.unzip ---
[INFO] Compiling 13 source files to C:\FOLDER\repositories\oomph-task-unzip\task-unzip\target\classes
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26.983 s
[INFO] Finished at: 2020-10-28T18:35:49+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:0.22.0:compile (default-compile) on project com.github.maybeec.oomph.task.unzip: Compilation failure: Compilation failure:
[ERROR] C:\FOLDER\repositories\oomph-task-unzip\task-unzip\src\com\github\maybeec\oomph\task\unzip\core\impl\UnzipUtilImpl.java:[7]
[ERROR] import org.apache.commons.compress.archivers.ArchiveEntry;
[ERROR] ^^^^^^^^^^^^^^^^^^
[ERROR] The import org.apache.commons cannot be resolved
[ERROR] C:\FOLDER\repositories\oomph-task-unzip\task-unzip\src\com\github\maybeec\oomph\task\unzip\core\impl\UnzipUtilImpl.java:[8]
[ERROR] import org.apache.commons.compress.archivers.ArchiveInputStream;
[ERROR] ^^^^^^^^^^^^^^^^^^
[ERROR] The import org.apache.commons cannot be resolved
[ERROR] C:\FOLDER\repositories\oomph-task-unzip\task-unzip\src\com\github\maybeec\oomph\task\unzip\core\impl\UnzipUtilImpl.java:[9]
[ERROR] import org.apache.commons.compress.archivers.ArchiveStreamFactory;
[ERROR] ^^^^^^^^^^^^^^^^^^
[ERROR] The import org.apache.commons cannot be resolved
[ERROR] C:\FOLDER\repositories\oomph-task-unzip\task-unzip\src\com\github\maybeec\oomph\task\unzip\core\impl\UnzipUtilImpl.java:[10]
[ERROR] import org.apache.commons.compress.compressors.CompressorInputStream;
[ERROR] ^^^^^^^^^^^^^^^^^^
[ERROR] The import org.apache.commons cannot be resolved
[ERROR] C:\FOLDER\repositories\oomph-task-unzip\task-unzip\src\com\github\maybeec\oomph\task\unzip\core\impl\UnzipUtilImpl.java:[11]
[ERROR] import org.apache.commons.compress.compressors.CompressorStreamFactory;
[ERROR] ^^^^^^^^^^^^^^^^^^
[ERROR] The import org.apache.commons cannot be resolved
[ERROR] C:\FOLDER\repositories\oomph-task-unzip\task-unzip\src\com\github\maybeec\oomph\task\unzip\core\impl\UnzipUtilImpl.java:[12]
[ERROR] import org.apache.commons.compress.utils.IOUtils;
[ERROR] ^^^^^^^^^^^^^^^^^^
[ERROR] The import org.apache.commons cannot be resolved
[ERROR] C:\FOLDER\repositories\oomph-task-unzip\task-unzip\src\com\github\maybeec\oomph\task\unzip\core\impl\UnzipUtilImpl.java:[47]
[ERROR] CompressorInputStream cIS = new CompressorStreamFactory().createCompressorInputStream(in);
[ERROR] ^^^^^^^^^^^^^^^^^^^^^
[ERROR] CompressorInputStream cannot be resolved to a type
[ERROR] C:\FOLDER\repositories\oomph-task-unzip\task-unzip\src\com\github\maybeec\oomph\task\unzip\core\impl\UnzipUtilImpl.java:[47]
[ERROR] CompressorInputStream cIS = new CompressorStreamFactory().createCompressorInputStream(in);
[ERROR] ^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] CompressorStreamFactory cannot be resolved to a type
[ERROR] C:\FOLDER\repositories\oomph-task-unzip\task-unzip\src\com\github\maybeec\oomph\task\unzip\core\impl\UnzipUtilImpl.java:[64]
[ERROR] ArchiveInputStream archiveIS = new ArchiveStreamFactory().createArchiveInputStream(fileIS);
[ERROR] ^^^^^^^^^^^^^^^^^^
[ERROR] ArchiveInputStream cannot be resolved to a type
[ERROR] C:\FOLDER\repositories\oomph-task-unzip\task-unzip\src\com\github\maybeec\oomph\task\unzip\core\impl\UnzipUtilImpl.java:[64]
[ERROR] ArchiveInputStream archiveIS = new ArchiveStreamFactory().createArchiveInputStream(fileIS);
[ERROR] ^^^^^^^^^^^^^^^^^^^^
[ERROR] ArchiveStreamFactory cannot be resolved to a type
[ERROR] C:\FOLDER\repositories\oomph-task-unzip\task-unzip\src\com\github\maybeec\oomph\task\unzip\core\impl\UnzipUtilImpl.java:[65]
[ERROR] ArchiveEntry entry;
[ERROR] ^^^^^^^^^^^^
[ERROR] ArchiveEntry cannot be resolved to a type
[ERROR] C:\FOLDER\repositories\oomph-task-unzip\task-unzip\src\com\github\maybeec\oomph\task\unzip\core\impl\UnzipUtilImpl.java:[77]
[ERROR] IOUtils.copy(archiveIS, out);
[ERROR] ^^^^^^^
[ERROR] IOUtils cannot be resolved
[ERROR] 12 problems (12 errors)
[ERROR] -> [Help 1]

Maven is actually downloading the Apache commons-compress-1.19.jar to the local Maven repository and it is also being copied to the project's lib folder. So that is working and the dependency is actually present on the filesystem.
However, Maven can not find this dependency.

Importing the submodule in Eclipse shows the same. Eclipse isn't able to auto-complete an "import" statement to "org.apache.commons.*":

The Properties > Build path of that submodule doesn't show any Maven dependencies (actually the "Maven Dependencies" list wasn't even there! I had to edit the .classpath file for that):

I did not come up with any solution so far - do you have any ideas?

Thank you

Would be great if this (and the download task) would show a more descriptive label in the designer and the installer instead of just "unzip".

while installing a project that relies on oomph-task-unzip i am getting the error message

requires 'osgi.bundle; org.junit 0.0.0' but it could not be found

Unzip seems to need junit but it isn't declared as an dependency? Is that correct? I am not too familiar with oomph, so I am not really sure if the problem is this repo?

Setup a README.md with the main information like

• how to integrate (especially update site)
• main contribution / purpose of this task (what does it do, where can it be used for?)
• Support for which zip formats?

The schema location (https://raw.githubusercontent.com/maybeec/oomph-task-unzip/master/task-unzip-updatesite/model/Task-unzip-1.0.ecore) mentioned in the readme returns a 404 error.

Our eclipse installation (via Oomph) currently fails, because https://maybeec.github.io/oomph-task-unzip/update/ throws a 404.

Would it be possible to get this up and running again? Or is there a replacement project?

• refactor namespace to match github repository
• get running maven build for update site generation

see commits on maybeec/oomph-task-cli#1 for further clarification

The console output is too large atm. There is one line per file and folder which floods the installer log while unzipping large files

org.eclipse.core.runtime.CoreException: Cannot complete the install because one or more required items could not be found.
at org.eclipse.oomph.util.OomphPlugin.coreException(OomphPlugin.java:280)
at org.eclipse.oomph.p2.internal.core.ProfileTransactionImpl.resolve(ProfileTransactionImpl.java:426)
at org.eclipse.oomph.p2.internal.core.ProfileTransactionImpl.commit(ProfileTransactionImpl.java:338)
at org.eclipse.oomph.setup.ui.EnablementComposite$5.run(EnablementComposite.java:316)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
Contains: Software being installed: artificial_root 1.0.0.v1603175059045
Contains: Missing requirement: unzip Setup Task 1.0.0.201612071748 (com.github.maybeec.oomph.task.unzip 1.0.0.201612071748) requires 'osgi.bundle; org.junit 0.0.0' but it could not be found
Contains: Cannot satisfy dependency:
Contains: From: artificial_root 1.0.0.v1603175059045
Contains: To: org.eclipse.equinox.p2.iu; com.github.maybeec.oomph.task.unzip.feature.feature.group 0.0.0
Contains: Cannot satisfy dependency:
Contains: From: unzip Setup Task 1.0.0.201612071748 (com.github.maybeec.oomph.task.unzip.feature.feature.group 1.0.0.201612071748)
Contains: To: org.eclipse.equinox.p2.iu; com.github.maybeec.oomph.task.unzip [1.0.0.201612071748,1.0.0.201612071748]

Check for any TODOs left in code

• parent-pom similar to lexeme
  • contributers
  • source distribution / issue management
  • license (latest EPL)
• manifest (resp. generated property files covering these)
  • license (latest EPL)
  • more explanatory feature texts?
• change license in top level repository