Giter Club home page Giter Club logo

Comments (10)

steffenheyne avatar steffenheyne commented on September 3, 2024

Which changes you mean?

from snakepipes.

vivekbhr avatar vivekbhr commented on September 3, 2024

Any updates present in current develop, like for example the trimming option were different between scRNAaseq and other workflows

from snakepipes.

steffenheyne avatar steffenheyne commented on September 3, 2024

the slight differing trimming option was intentionally, as poly-A trimming is "easier" with cutadapt, therefore scRNA-seq supports only cutadapt right now....but I can change this for consistency

from snakepipes.

vivekbhr avatar vivekbhr commented on September 3, 2024

@steffenheyne feel free to close this if you think it's done

from snakepipes.

dpryan79 avatar dpryan79 commented on September 3, 2024

Isn't cutadapt the default trimmer in the other workflows already? I wouldn't oppose getting rid of Trim Galore all together, since cutadapt is vastly faster.

from snakepipes.

steffenheyne avatar steffenheyne commented on September 3, 2024

yes, cutadapt is default everywhere...and as trimgalore is just a "convenience" wrapper around cutadapt, I'm fine getting rid of trimgalore.

more general aspect: I'm just always a bit afraid that we miss/might use the right adapter/primer sequence as there are eg slight diff. between small RNA-seq and other protocols, here trimGalore has some autodetect function, but also I'm not sure how good this is actually working etc...

should we make adapter sequence configureable via defaults.yaml?

from snakepipes.

steffenheyne avatar steffenheyne commented on September 3, 2024

currently we just use always "AGATCGGAAGAGC"

from snakepipes.

dpryan79 avatar dpryan79 commented on September 3, 2024

We could make that configurable I suppose. I actually want to add a --detect option to cutadapt (I looked into making Trim Galore multithreading...but that'd be absurdly complicated). I think Trim Galore does an OK job for the most part with adapter detection, but of course if you know what the adapter is then that'll always be the most reliable. The WGBS pipeline has two different adapter sequences built in, so one can instead trim with Nextera adapters if needed. Maybe that's the way to go, since we don't currently support sRNA-seq.

from snakepipes.

vivekbhr avatar vivekbhr commented on September 3, 2024

Yah if cutadapt rule can be adopted for multiple adaptor types, I would also vote to get rid of trim-galore

from snakepipes.

steffenheyne avatar steffenheyne commented on September 3, 2024

see now here
#151

from snakepipes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.