Giter Club home page Giter Club logo

Comments (4)

elzadj avatar elzadj commented on June 9, 2024 1

@Naaaaiix Try the solution you suggested: FontLevel can admit the same prop as Typography, modify it, and send it back. Thanks.

from maxi-blocks.

Naaaaiix avatar Naaaaiix commented on June 9, 2024

As commented with Svitlana, the script is working and takes the values by default, so no need of CSS. Goooood! 👍
But, never's too good: there's a conflict with another component that may we should resolve. It's about FontLevel, at least on ImageBox

Captura de pantalla 2020-04-10 a las 13 53 37

Problem

What's the matter? That if you change from H2 to H3, Typography component won't feel the difference, and despite the HTML code will show a H3 instead of H2, the CSS will remain with the Typography one.

Solution

May would be a good idea to integrate FontLevel inside of Typography, with a disable options in case is no need, and may it can modify the Typography options to the heading default directly in case is changed.

Let me know your opinions and suggestions, and let's find the best solution! Good coding my friends 😸

from maxi-blocks.

Naaaaiix avatar Naaaaiix commented on June 9, 2024

Ok, the problem with default values for Typography is still there, so it's necessary to fix it. And for FontLevel situation, it will integrate the option to modify Typography component props in order to update it in case of necessity.
So, in a list (and some more things):

  • Typography default values
  • FontLevel integrate Typography props
  • Add AlignmentControl

from maxi-blocks.

Naaaaiix avatar Naaaaiix commented on June 9, 2024

Decomposed in different issues and related with 'Typography' project

from maxi-blocks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.