Comments (4)
@Naaaaiix Try the solution you suggested: FontLevel can admit the same prop as Typography, modify it, and send it back. Thanks.
from maxi-blocks.
As commented with Svitlana, the script is working and takes the values by default, so no need of CSS. Goooood! 👍
But, never's too good: there's a conflict with another component that may we should resolve. It's about FontLevel, at least on ImageBox
Problem
What's the matter? That if you change from H2 to H3, Typography component won't feel the difference, and despite the HTML code will show a H3 instead of H2, the CSS will remain with the Typography one.
Solution
May would be a good idea to integrate FontLevel inside of Typography, with a disable options in case is no need, and may it can modify the Typography options to the heading default directly in case is changed.
Let me know your opinions and suggestions, and let's find the best solution! Good coding my friends 😸
from maxi-blocks.
Ok, the problem with default values for Typography is still there, so it's necessary to fix it. And for FontLevel situation, it will integrate the option to modify Typography component props in order to update it in case of necessity.
So, in a list (and some more things):
- Typography default values
- FontLevel integrate Typography props
- Add AlignmentControl
from maxi-blocks.
Decomposed in different issues and related with 'Typography' project
from maxi-blocks.
Related Issues (20)
- Style card affecting native blocks without any foundation blocks being used on page or on site
- We have ability copy/paste nested column inside column
- Need to add styles for video's icon
- Appender between containers
- Blocks don't work in Template preview from pages
- maxi does not work if create new template HOT 1
- DC content is not rendering on frontend HOT 1
- Double link in list
- CL / DC / pagination when pages have tags / categories
- Bug with CL ( equal IDs? ) HOT 1
- Overwrite for colours does not work on frontend
- Need to add support for CPT templates HOT 1
- Unit bug for patterns from the cloud
- Add support for displaying ACF fields from Options Pages in MaxiBlocks
- Issues when switching category HOT 1
- Hidden class does not work for DC if enable DC link for column
- Typography Units Defaults migrator infinite run and pages freeze HOT 1
- Maxi Toolbar in the editor's distraction free mode
- Overflow does not work correct for image block HOT 1
- Weird font bug on mobile
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from maxi-blocks.