async_trait is allowed or not about chromiumoxide HOT 4 CLOSED

Hey,
I'm generally not opposed to introducing async_trait, however I'm not quite sure whether it makes sense here.
If I understood your request correctly you want to implement support for Network.setRequestInterception? According to the docs, this is deprecated in favour of Fetch.enable. Puppeteer also seems to use Fetch.enable here, and the chromiumoxide command is here, which enables issuing of Fetch.requestPaused events.

After having a quick look at headless_chrome's method, this hook trait callback should execute on arrival of those events, correct?
There is already a way to subscribe to events, have you checked the EventListener for the Page and there is also a PR that would add event listener for the browser #39

For me this hook trait would make sense if we want to add designated support for event callbacks, but I'm not sure whether this makes a huge difference compared to the existing event stream functionality.

from chromiumoxide.

I'm tring to implement a server-side render service via headless chrome, and I need to hook all network request from the page , to make sure all components has been loaded, reject unexpected resource request to make sure our service is safe and stable.
I do believe EventListener is a useful, and I known how to use it. But it's low level API for me, same to others.
If I would implement the high level API for my self, why not for others on the same time.

from chromiumoxide.

Without async_trait, there would be some boring code for peopel who want to impl Hook trait. Of course, that's not a so important.

(Sorry for my terrible English)

from chromiumoxide.

I believe I got your point and I also think this may be beneficial for others, so I for sure welcome contributions on this :)

from chromiumoxide.