mattpilott / sapper-start Goto Github PK

Thanks a lot for this great sample. It works great for svelte-apollo 0.3.0 as it can be easily enhanced to work with a mutation too.

The problems start when svelte-apollo is upgraded to 0.4.0. It requires calling setClient, but as you already mentioned in your code, doing so will break the sapper app with Function called outside component initialization. Any ideas on how to fix this? Thanks!

Feature Request
As IE11 (despite being a legacy browser) still is widely used, especially at government institutions and some bigger organisations, and Edge is here to stay, it would be nice to have support for IE11 and Edge implemented by default.

Looking at this repo: https://github.com/antony/sapper-ie, the additions needed seem somehow straight forward.. I know that Antony currently is evaluating a pull request that may improve it, so I will keep an eye out.

Something like:

function redirectTrail(req, res, next) {
	const test = /\?[^]*\//.test(req.url);
	if (req.url.substr(-1) === '/' && req.url.length > 1 && !test) {
		res.statusCode = 301;
		res.setHeader('Location', req.url.slice(0, -1));
		res.end();
	}
	else {
		next();
	}
}

Thanks a lot Matt for your template, it got me started with SCSS for a configuration nobody is talking elsewhere (a SCSS based template).
I have a SCSS based template, made up of a root SCSS file that imports other files, which in turn import other files (among which bootstrap).
All these are in the ./static folder.
Your template is building fine the first npm run dev, but as soon as I change one of these SCSS files, the recompilation gives problems, something like possible duplicates. Here is the output:

{
  "status": 1,
  "file": "/home/me/sapper-scss-matt-app/static/_core.scss",
  "line": 24,
  "column": 1,
  "message": "It's not clear which file to import for '@import \"bootstrap/bootstrap\"'.\nCandidates:\n  bootstrap/bootstrap.scss\n  bootstrap/bootstrap.css\nPlease delete or rename all but one of these files.\n",
  "formatted": "Error: It's not clear which file to import for '@import \"bootstrap/bootstrap\"'.\n       Candidates:\n         bootstrap/bootstrap.scss\n         bootstrap/bootstrap.css\n       Please delete or rename all but one of these files.\n        on line 24 of static/_core.scss\n        from line 3 of static/global.scss\n>> @import \"bootstrap/bootstrap\";\r\n   ^\n"
}

This is the main task of 2.0 and will be executed as a full rebuild to ensure it has no legacy sapperiness

As this is actually a source file that needs to be compiled it should really live somewhere in the src folder as opposed to the static folder