mattjmorrison / capistrano-django Goto Github PK

Currently, this script builds a new virtualenv per deploy, which extends deploy times by quite a bit.

I've written some code to build the virtualenv once, in the shared directory, and then symlink it into the release directory. I'm submitting a pull request - AFAICT, it doesn't break anything, and is switchable via one config variable.

It's been a long time since i've used capistrano (and django) so coming back to this library exposed a lot of pieces of config that I completely forgot about.

I created a minimal deploy example app that has a few placeholders here.

Would you rather link externally or have me add it to the project and do a PR?

It would be great to utilize this for my Capistrano v3 deployments.

Currently. the virtualenv command that runs via python:create_virtualenv is just a flat virtualenv #{path}; there are several options that might be useful/necessary to pass to it at creation time, e.g. python to use, system-site-package, etc.

Matt

Would you be willing to support a "breaking change" to the project? example -today this assumes you are using grunt for the npm deploy step but it would be nice to support grunt/gulp/broccoli/whatever is next and I'm thinking this line

https://github.com/mattjmorrison/capistrano-django/blob/master/lib/capistrano/django.rb#L141

We could swap out for a complete "npm task" in the config so I would supply this

set :npm_task, './node_modules/.bin/grunt deploy'

Instead of this (what I'm doing today)

set :grunt_task, 'deploy'

Any way you would be up for a change like this in the next release?