Giter Club home page Giter Club logo

ethereum-paper-wallet's People

Contributors

dependabot[bot] avatar elmol avatar matthiaszimmermann avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ethereum-paper-wallet's Issues

password in bash history

Suggestion.
This command does not store password in bash history:
java -jar target/epwg-0.4.0-SNAPSHOT.jar -d data -p $(read -s -p "password: "; echo $REPLY)

Issue with Java Home Environment Variable

Morning,

Got this working this afternoon and noticed an error in your script for creating the wallets. Current script example has the pass phrase wrapped by SINGLE inverted commas -- these need to be DOUBLE inverted commas.

Cheers

Mik

Default wallet should be random

Hi. Sad story short. In the beginning of this year (2021) I was new in crypto world. I've found this repository to create my first ethereum wallet in offline mode. I use MacOS. I've run command

# '123445asdff' was my password (not real one)
java -jar target/epwg-0.4.0-SNAPSHOT.jar -d data -p $(read -s -p "123445asdff"; echo $REPLY)

I already do not remember all details but somehow it gave me the wallet file. Then I mined there for 3 months with one low-end GPU on 2miners (0.1 eth) and later on ethermine (0.01 eth) pools. Then I changed my wallet on new one (because I've bought couple mid-range new GPUs) and haven't used this wallet for a while. Today I remembered that I have some Ethereum money/coins and wanted to send it to my second wallet and here I've found out the saddest thing ... the wallet that was generated is wallet as the wallet on main page (readme) - my password wasn't used but default one as on screenshot. And someone has generated the same wallet/password/privatekey and used it to transfer my ethereum to another wallet, it can be seen on etherscan (https://etherscan.io/address/0x47f71c6ee2e7d538c7554ec650bd7e536dc9057b).

This is my fault for sure. To prevent this for happening seems there should be added some randomness when password is not provided or empty, or something unexpected has happened.

This is not my main account, just didn't want that my colleagues see how stupid I was )
Thank you.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.