mattecarra / acca Goto Github PK

Since acc doesn't install by Magisk but directly from acc apk 1.0.13 The app doesn't stop or limit charging. Deinstall and reinstall doesn't help the problem.

Can't read it's own config files apparently. Tried version 1.0.6 and 1.0.8

Dear developer!
I love ACC and ACCA. But here's a small problem. In previous versions, ACCA frontend works perfectly with systemless ACC backend. But after recent updates, ACCA no longer works with systemless ACC backend.
New ACCA seems to uninstalling systemless ACC and replace it with integrated ACC, and because of which, ACCA is altering the originally RO partition.

And my suggestion is provide support for systemless ACC backend or maybe give an option in ACCA settings to switch between systemless or integrated version.

Thanks!

the accepted voltage range is 3920-4349mV

Should it be kept that way? Or have something that will re-apply the profile of it has been edited.

AccA crashes upon pull-down of the notifications bar from the top of the screen, with any app open or just at the launcher.

Occurs on 1.0.8 and v1.0.9, does not occur on 1.0.3.

Device: kltedv (Samsung Galaxy S5 SM-G900i)
LineageOS 15.1-20190224-NIGHTLY-kltedv
Ares-Kernel-beta-v1.4

Log: 2019-06-25-17-45-50-0.txt

Pixel 3XL currently on May update and Magisk 19.2 Canary (19203).

When I install this app on the latest beta it tells me that the daemon is not running although it is. Did I miss something in the install?

#60

Add an app theme selector in preferences, and design an appropriate dark theme for ACCA.

The android overview buttons are not visible, however you can still use them (by guessing/knowing their positions).
It seems like that the buttons are overlayed by the white ui, however the tabs are positioned above the button area.

ACCA Version: 1.0.16 (21)
ACC Version: 201908180
Android Version: 6.0

I added a German translation to the crowdin project.
How do I get it to git/how do you do that?
Not used to work with crowdin :)

There are more and more files and folder under /sdcard/ .
It will be very thankful if you put them under /sdcard/Android/data/mattecarra.accapp .

ACC App crashed when I first installed and opened it, worked fine after that:

Process: mattecarra.accapp
Flags: 0x38e8be44
Package: mattecarra.accapp v12 (1.0.8)
Build: google/hammerhead/hammerhead:6.0.1/M4B30Z/3437181:user/release-keys

java.lang.RuntimeException: Failure delivering result ResultInfo{who=@android:requestPermissions:, request=0, result=-1, data=Intent { act=android.content.pm.action.REQUEST_PERMISSIONS (has extras) }} to activity {mattecarra.accapp/mattecarra.accapp.activities.MainActivity}: java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState
  at android.app.ActivityThread.deliverResults(ActivityThread.java:3699)
  at android.app.ActivityThread.handleSendResult(ActivityThread.java:3742)
  at android.app.ActivityThread.-wrap16(ActivityThread.java)
  at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1393)
  at android.os.Handler.dispatchMessage(Handler.java:102)
  at android.os.Looper.loop(Looper.java:148)
  at android.app.ActivityThread.main(ActivityThread.java:5417)
  at java.lang.reflect.Method.invoke(Native Method)
  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
  at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:107)
Caused by: java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState
  at androidx.fragment.app.FragmentManagerImpl.checkStateLoss(FragmentManager.java:2080)
  at androidx.fragment.app.FragmentManagerImpl.enqueueAction(FragmentManager.java:2106)
  at androidx.fragment.app.BackStackRecord.commitInternal(BackStackRecord.java:683)
  at androidx.fragment.app.BackStackRecord.commit(BackStackRecord.java:637)
  at mattecarra.accapp.activities.MainActivity.loadFragment(MainActivity.kt:159)
  at mattecarra.accapp.activities.MainActivity.onNavigationItemSelected(MainActivity.kt:139)
  at com.google.android.material.bottomnavigation.BottomNavigationView$1.onMenuItemSelected(BottomNavigationView.java:204)
  at androidx.appcompat.view.menu.MenuBuilder.dispatchMenuItemSelected(MenuBuilder.java:840)
  at androidx.appcompat.view.menu.MenuItemImpl.invoke(MenuItemImpl.java:158)
  at androidx.appcompat.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:991)
  at com.google.android.material.bottomnavigation.BottomNavigationView.setSelectedItemId(BottomNavigationView.java:405)
  at mattecarra.accapp.activities.MainActivity.initUi(MainActivity.kt:276)
  at mattecarra.accapp.activities.MainActivity.onRequestPermissionsResult(MainActivity.kt:121)
  at android.app.Activity.dispatchRequestPermissionsResult(Activity.java:6582)
  at android.app.Activity.dispatchActivityResult(Activity.java:6460)
  at android.app.ActivityThread.deliverResults(ActivityThread.java:3695)
  ... 10 more

The latest 1.0.8 doesn't show custom charging switches when editing profiles, only automatic can be selected.

in version 201907180 magisk module will be removed when AccA is installed,could add a script in magisk autorun scripts dir(/data/adb/ service.d or post-fs-data.d) to symlink the acc dir and run accd at boot.

Use DJS to integrate scheduling of commands in ACCA.

Hi @MatteCarra
I've been using AccA for a week or 2, so far no problem with charging control file. However, there are no notifications I found but a member on xda said there is notification on lockscreen. I'm confused here whether it's a bug or not. I also found out that there's no sound notification for stop charging.

My device is xperia M4 Aqua (stock 6.0.1 + stock kernel) rooted with magisk 19.3 stable.

Implement schedule expansion on click.
The expanded schedule should show all the profile attributes (just like profiles in the profile section).
The schedule edit call should be moved to the three dots option menu, above the delete option.

Although the daemon is active (I checked from the command line), the app says it is not running.

Hello, on 1.0.7, in the first profile max temp is set on 90. Just to let you know.

It seems like acca doesn't handle wireless charging well on xiaomi mi 9 , it's switching on off on off... while around charging limit.
I think it's bad for battery life.

This isn't a big deal, but I noticed a typo while setting the on plugged option. I assume it's supposed to say "Leave blank to disable", but instead it says "Leave black to disable."

• Add an embedded compatible version and start the daemon on system startup.
• Add a setting option to choose between bundled, dev, dev with changelogs
• Add a warning when selecting stable/dev
• If an user selects master/dev keep acc updated with new commits

With 1.0.8 and miui 10, Android 9, Xiaomi Mi8 and latest Magister (19.3/19.2) i can See negative values when charging the battery. It is charging -2000 instead +2000

Hello, I created a profile with almost default values. Just set the shut down value to 10. On plugged command acc -e. But as per setting, the charging start cool down over 60% for 10 seconds. It works fine if the screen is on. But after the screen is locked & turned off, charging does not resume from cool down. If I press the power button the charging starts immediately.

OxygenOS on the OnePlus 7 Pro has a persistent notification that appears when you plug in the official Warp Charge 30 car charger. It displays this notification until the car charger is disconnected.

Unfortunately, it seems that however ACC/AccA handles the 'stop' functionality goes undetected by the process/logic in charge of removing the notification, so when ACC disables charging, the persistent notification remains. Then even when physically removing the cable, the phone still does not realize and the notification is stuck until I either charge with a wall charger or do use the car charger and remember to unplug it before ACC disables charging.

I would simply disable this notification, but the system does not allow it to be disabled. I could also use Automagic to consistently snooze it to suppress it, but I'm also concerned that it could potentially cause some other issue such as a background process that may still think the phone is being charged which may lead to unintended consequences.

I'm hoping there's some way to understand and fix this, though I'm not sure how and I know it would be impossible to test if you guys don't have this phone and the car charger, but I'm fully willing to coordinate, provide logs, and test any ideas or test versions you come up with.

Setting chagingSwitch=FILE DEFAULT_VOLTAGE STOP_VOLTAGE in applyOnPlug/applyOnBoot has no effect (probably overwritten by general chagingSwitch setting)

I'm running Google pixel 3 with latest versions of the app and Acc installed. Updated app potential cause, but not sure.

Have an option to show the battery option and status as an ongoing notification.

Concerns: battery impact.

When I attempt to use "Edit limit for one charge", the moment I tap Apply ACCA freezes - it doesn't even dismiss the dialog. It does however appear to apply the setting.

Also, a bit after reaching the set one-time-limit, ACC crashes and the phone just discharges, but that may be an ACC bug, I'll try it from commandline.

ACCA 1.0.8
ACC 2019.6.20
Phone: LG V20 (US996) with Oreo 8.0.0

When using dark theme and selective a profile, the highlighted line does not appear to indicate the selected profile.

Steps to reproduce:

1. Open settings and select the dark theme.
2. Go to the Profiles screen.
3. Tap to select a new profile.

Expected Outcome:
-- A green line should appear to indicate the tapped profile is selected.

Actual Outcome:
-- No green line appears.

Reproduced on:
Xiaomi Mi A1 running Android 8.1.0.

I am using the battery/charge_disable switch. When the battery is not being charged and the phone is running on usb power the app will show the wrong current: the system will draw about 2mA but the app shows -2000mA instead.

The responsible function is this one:

I'm running Pie on a Pixel 3a and since the current in the in the corresponding sysfs file is given un uA, it should always be divided by 1000. I don't know if there are other phones/version where the current is given in mA already.

updateBatteryInfoRunnable in DashboardViewModel is not paused when app is paused

When I attempt to select a Voltage control file, I am unable to see the actual file being selected, or the options available to me. This happened in both V. 14 and V. 15 of the app. I believe it is a design issue only, and may not require the submission of a log, but I have attached screenshots to explain what I'm experiencing.
On the Portrait screenshot, I am unable to scroll through the other options for a Voltage Control file.

On the Landscape screenshot, I can see that there are five (5) options for voltage control files, but I cannot actually see what they are.

I have not seen anyone else report this issue in the XDA thread, and the quick browsing of "related issues" on github did not produce any immediately obvious results.
I am running LineageOS 16 on my OnePlus 6T, in case that information is helpful.

By contrast, the Capacity Control/Charging Switch menu pops up perfectly for me, with clear listings of the available switch files.

If there is anything else you need from me, please do not hesitate to let me know.

The start/stop button is especially concerning. One will often find themselves double-pressing it - thinking that the first click somehow failed.

Just a passing by remind :)

v1.0.12
SU permission has been granted at prompt and yet this warning is displayed despite having an active Internet connection (WiFi/data) and even after installing acc through the magisk manager (7.3.2). The magisk (19.3) module is installed, up to date (201907180) and it works through a terminal emulator.

===System's data===
Model: SM-J700M (j7elte)
TWRP: 3.2.3-0
Magisk: 19.3
Device API level: 23
Android version: 6.0.1
Kernel Version: 3.10.61-11132510
Build number: MMB29K.J700MUBS2BQF4
SELinux status: Enforcing (SEPF_SECMOBILE_6.0.1_0034)
ASKS v1.2_161011
KNOX 2.6

• More details about configuration without editing.
• Limited details view of requent stats/settings.
• Easier way to see options for the profile.

<string name="cooldown_capacity">开始冷却阀值:</string>
<string name="resume_charge">恢复充电阀值:</string>
<string name="stop_charge">停止充电阀值:</string>

There is no word “阀值” , the correct is "阈值"

How do I update the app without loosing my data?
Can you add an in app update checker?
Can you create a default profile for each phone that is the manufacturers settings, as in what it would charge to if I completely removed ACC. Or a default check box next to each slider.

Hello, I am using ACC module with latest Magisk module, on LineageOS 14.1. I have noticed some problems. I use Termux. I generally use acc -e 80%. But when I connect the charger next time, I have to manually run acc -e to start charging, then run acc -e 80%. Also acc -e 80 60 (keep battery percentage within a limit) does not work at all.

Steps to reproduce:

1. Open AccA
2. Edit Config
3. Edit voltage limit
4. Enable voltage limit
5. Enter valid limit (e.g 4100)
6. Click Ok, save config
7. Go back into config editor and edit voltage limit
8. Voltage limit is now displayed in microVolts (4100 -> 4100000)

Acc reports voltage limits in microVolts, not milliVolts even though the voltage limit is set via milliVolts, which is probably why the voltage limit is displaying incorrectly

[Fixed]

Before installation of this app, (acc is installed and effective) Automat App is able to shutdown my rooted tab if the tab is idle or inactive for more than 3 hours

Auto idle shutdown is not working after installation of AccA I.e. it is disturbing the sleep or idle period of tab

Hey!
I really enjoy the app but right now it does not fit exactly my usage of ACC and I'd like to suggest some new features :)

The biggest one is the integration with Tasker to be able to switch between profiles without human interaction. For instance, at night I want my phone to charge very slowly in 3 to 5 hours but the day I want my phone to charge faster. If making AccA a Tasker plugin is a bit hard, another solution might just be to store profiles created in the app in a folder in /sdcard/acc and then using Tasker to swap profiles using "Copy file" action.

My second suggestion is a persistant notification showing charging state, battery current, active profile (using name), and even more information when expanding the notification such as cooldown state, battery temp, ...

I would also like to suggest a "dev mode" which notify the user if acc daemon crashes in background with the error message if applicable. This could be very useful to detect flaws in profiles or why the daemon is not working sometime :)

And finally a more user-friendly "log" section in the app to understand what ACC is doing. (I think I'm not the only who don't understand anything when looking in this section and would like something more explicit ^^).
I am thinking to something like this:

[XX-XX-XXXX HH:MM:s] Phone plugged in, updating files (1000000 > path/to/max_current_file, 450000 > path/to/max_voltage/file)
[XX-XX-XXXX HH:MM:s] Battery temp = 40°C, Charge paused for 30s (0 > path/to/charge_file)
[XX-XX-XXXX HH:MM:s] Resuming charging (1 > path/to/charge_file).
[XX-XX-XXXX HH:MM:s] Battery level > 80%, activating cooldown.
[XX-XX-XXXX HH:MM:s] Cooldown active: charge paused for 10s (0 > path/to/charge_file).
[XX-XX-XXXX HH:MM:s] Cooldown active: charge resumed for 50s (1 > path/to/charge_file).
[XX-XX-XXXX HH:MM:s] Battery level = 90%, Charge paused (0 > path/to/charge_file).
[XX-XX-XXXX HH:MM:s] Battery level = 80%, Charge resumed (1 > path/to/charge_file).

Thank you very much for all the work you are doing, you are awesome <3
Thanks to VR25 too for the work done on the daemon <3

Most heavily modified OEM Android ROMs turn smartphones into dumb phones.
Currently, the worst offender is EMUI.
Here, we will be discussing ways of ensuring ACC gets initialized on boot.

Starting point: https://dontkillmyapp.com/