mattcurrie / cgb-acid2 Goto Github PK

Hey there! In my own experience, the description "Object Priority Mode (DMG/CGB)" for the mole error could potentially be a little misleading.

In my own experience, the cause was that sprites on CGB are prioritized by position OAM rather than by X-coordinate.

I'm making an issue rather than a PR because I'm sure you understand this better than I do, and I might just be misunderstanding something.

Thanks for your work on these :)

I'm posting this issue out of a bit of selfishness because I have a failure case that's not represented on the README and I'm not quite sure what's going on. See the following image:

On the left is my emulator, and on the right is SameBoy. The top images are running in DMG mode, and the bottom ones are running in CGB mode. It seems obvious (though it may not be) that the missing center tiles represent an unimplemented detail between DMG and CGB since this issue affects both emulators on DMG, but only affects my emulator on CGB. The problem is: I have no idea what that unimplemented detail is. If I manage to figure it out, I will reply to this issue with the fix and reiterate my recommendation to include this failure case in the README. If anyone else knows what's going on here, I would love to know the answer.