Giter Club home page Giter Club logo

phc2foodcore's People

Contributors

matrexsvigil avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

phc2foodcore's Issues

Fruit punch has too much saturation and keeps players away from exploring the mod

Ever since me and my friends started a modpack playthrough on a private server with this mod, the farming aspect has been permanently left out of the picture due to how easy it was to make the fruit punch, an item which takes very little effort to create, yet it offers long lasting saturation.

Looking at the difficulty of other recipes which render similar saturation, the fruit punch is in comparison absolutely too overpowered and defeats the purpose of exploring your mod.

An example: One of my friends spent 1-2 weeks building a burger factory which included milking cows, getting beef from them, growing tomatoes, bread and the likes. He has also taken the time to create a huge, realistic factory building with designated rooms for each section and redstone circuitry to turn everything off as needed. In summary, this was one of his biggest projects in the modpack. After he was done, he found out all of his hard work was in vein as the fruit punch's recipe was just 3 berries and a juicer, and had nearly just as much saturation as the burgers. The amount of effort it takes to find berries is little to none, juicer is easily craftable and it is possible to make a farm that grants you a stack of fruit punch per harvest, early-game.

Please strongly consider reworking fruit punch by either lowering its saturation or increasing the steps needed to make it. I understand that there are also weaker variations of berry products, which you make using 1 berry and a juicer, as well as 2 berries and a juicer, however the fruit punch shouldn't be as saturating as high tier food with that crafting difficulty.

Support "small ice cubes" from Vanilla Food Pantry mod

It would be great if "small ice cubes" could be supported by recipes that otherwise require ice in this mod (and the extended food mod). If this isn't practical, it would be ideal if instead the relevant recipes were updated to use the tag forge:ice_like (which I can then tag the "small ice cubes" item with).

forge:fruits tag doesn't seem to be loaded correctly

replication steps:

  1. install the following mod loader and mods in a 1.18.2 minecraft:
  • forge 40.1.14
  • jei-1.18.2-9.5.5.174
  • pamhc2foodcore-1.18.2-1.0.1
  1. open up the world and look up the recipe for fruit salad

problem:

  • The player will see this as the recipe:

image

potential resources for this issue:

1.16.1 Recipes are not working

Single player game, mod appears to load properly. Recipes all show up in JEI. Was able to make the tools (juicer, pan, etc) but all of the food recipes I have tried so far do not seem to work. I also have Cooking for Blockheads and Simple Farming installed. But Pam's food recipes are not craftable in a regular workbench, nor in the cooking station. I have also tried both with the simple farming food and with vanilla only crops. Both putting the items in manually and via the + in JEI results in a null option in the crafting window.

Using version 1.0.5

[Feature Request] Quick fix

Can you updated the mod.toml to allow for 1.16.3. I would only like the food core updated, as that is the last mod that needs updated to update my pack. there is a lot of bug fixes that are being prevented by something that a lot of mods that can support both versions (1.16.2, and 1.16.3) in one jar. I know it is an easy fix, and if you would like i can do the 30 second job for you.

infinite item glitch in all recipes containing flour

Whenever I use the cooking table to craft any recipe containing the flour item from pamhc2foodcore-1.18.2-1.0.0.jar, I also end up with a ton of extra flour. In one instance I crafted 12 batter, and then attempted to use up the random flour it gave me by crafting a stack of dough, and ended up with an additional 38 stacks of flour.
Afterward I opened the fridge and found 15 stacks of dough. I'm sure I didn't craft that many.
The issue also occurs when crafting in the regular inventory crafting grid.
Later on i had the same issue crafting dough again. I also suddenly acquired about 20 stacks of pasta when i was trying to make only one. Also, while making bread from the duplicate dough stacks, each stack of dough was only making around 20 bread items, despite the recipe being 1:1.

[1.16.1] Cannot register a generic event listener with addListener, use addGenericListener

I was launching Valhelsia 3 and this error shows up.

Crash Log:

[29Jul2020 18:22:44.611] [modloading-worker-6/ERROR] [net.minecraftforge.fml.javafmlmod.FMLModContainer/LOADING]: Failed to create mod instance. ModID: pamhc2foodcore, class pam.pamhc2foodcore.Pamhc2foodcore
java.lang.IllegalArgumentException: Cannot register a generic event listener with addListener, use addGenericListener
	at net.minecraftforge.eventbus.EventBus.checkNotGeneric(EventBus.java:167) ~[eventbus-3.0.3-service.jar:?]
	at net.minecraftforge.eventbus.EventBus.checkNotGeneric(EventBus.java:162) ~[eventbus-3.0.3-service.jar:?]
	at net.minecraftforge.eventbus.EventBus.addListener(EventBus.java:173) ~[eventbus-3.0.3-service.jar:?]
	at pam.pamhc2foodcore.SideProxy.<init>(SideProxy.java:20) ~[?:1.0.4]
	at pam.pamhc2foodcore.SideProxy$Client.<init>(SideProxy.java:43) ~[?:1.0.4]
	at pam.pamhc2foodcore.Pamhc2foodcore.lambda$null$0(Pamhc2foodcore.java:28) ~[?:1.0.4]
	at pam.pamhc2foodcore.Pamhc2foodcore$$Lambda$3138/1536676784.get(Unknown Source) ~[?:?]
	at net.minecraftforge.fml.DistExecutor.unsafeRunForDist(DistExecutor.java:174) ~[?:?]
	at net.minecraftforge.fml.DistExecutor.runForDist(DistExecutor.java:157) ~[?:?]
	at pam.pamhc2foodcore.Pamhc2foodcore.<init>(Pamhc2foodcore.java:28) ~[?:1.0.4]
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:1.8.0_51]
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) ~[?:1.8.0_51]
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:1.8.0_51]
	at java.lang.reflect.Constructor.newInstance(Constructor.java:422) ~[?:1.8.0_51]
	at java.lang.Class.newInstance(Class.java:442) ~[?:1.8.0_51]
	at net.minecraftforge.fml.javafmlmod.FMLModContainer.constructMod(FMLModContainer.java:136) [?:32.0]
	at net.minecraftforge.fml.javafmlmod.FMLModContainer$$Lambda$2930/794358930.accept(Unknown Source) [?:32.0]
	at net.minecraftforge.fml.javafmlmod.FMLModContainer$ErroringConsumer.accept(FMLModContainer.java:190) [?:32.0]
	at net.minecraftforge.fml.ModContainer.transitionState(ModContainer.java:113) [?:?]
	at net.minecraftforge.fml.ModList.lambda$null$11(ModList.java:135) [?:?]
	at net.minecraftforge.fml.ModList$$Lambda$3120/381247034.accept(Unknown Source) [?:?]
	at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) [?:1.8.0_51]
	at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374) [?:1.8.0_51]
	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:512) [?:1.8.0_51]
	at java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:291) [?:1.8.0_51]
	at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731) [?:1.8.0_51]
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) [?:1.8.0_51]
	at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056) [?:1.8.0_51]
	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1689) [?:1.8.0_51]
	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157) [?:1.8.0_51]
[29Jul2020 18:22:44.618] [modloading-worker-6/ERROR] [net.minecraftforge.fml.javafmlmod.FMLModContainer/LOADING]: An error occurred while dispatching event CONSTRUCT to pamhc2foodcore
[29Jul2020 18:22:44.619] [modloading-worker-6/FATAL] [net.minecraftforge.eventbus.EventBus/EVENTBUS]: EventBus 96 shutting down - future events will not be posted.
java.lang.Exception: stacktrace
	at net.minecraftforge.eventbus.EventBus.shutdown(EventBus.java:317) [eventbus-3.0.3-service.jar:?]
	at net.minecraftforge.fml.javafmlmod.FMLModContainer.afterEvent(FMLModContainer.java:123) [?:32.0]
	at net.minecraftforge.fml.javafmlmod.FMLModContainer$$Lambda$2931/9452563.accept(Unknown Source) [?:32.0]
	at net.minecraftforge.fml.javafmlmod.FMLModContainer$ErroringConsumer.accept(FMLModContainer.java:190) [?:32.0]
	at net.minecraftforge.fml.ModContainer.transitionState(ModContainer.java:113) [?:?]
	at net.minecraftforge.fml.ModList.lambda$null$11(ModList.java:135) [?:?]
	at net.minecraftforge.fml.ModList$$Lambda$3120/381247034.accept(Unknown Source) [?:?]
	at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) [?:1.8.0_51]
	at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374) [?:1.8.0_51]
	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:512) [?:1.8.0_51]
	at java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:291) [?:1.8.0_51]
	at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731) [?:1.8.0_51]
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) [?:1.8.0_51]
	at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056) [?:1.8.0_51]
	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1689) [?:1.8.0_51]
	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157) [?:1.8.0_51]
[29Jul2020 18:22:44.700] [modloading-worker-4/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key itemsPerColumn was corrected from null to 4
[29Jul2020 18:22:44.793] [modloading-worker-4/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key itemsPerRow was corrected from null to 4
[29Jul2020 18:22:44.995] [modloading-worker-4/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key diyData was corrected from null to true
[29Jul2020 18:22:45.057] [modloading-worker-4/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key showDevData was corrected from null to false
[29Jul2020 18:22:45.110] [modloading-worker-4/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key enchantsBlacklist was corrected from null to [flimflam, soulBound]
[29Jul2020 18:22:45.111] [modloading-worker-4/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key hiddenTabs was corrected from null to []
[29Jul2020 18:22:45.113] [modloading-worker-4/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key dimensionsBlacklist was corrected from null to [-11]
[29Jul2020 18:22:47.180] [Render thread/INFO] [net.minecraftforge.fml.DeferredWorkQueue/LOADING]: Dispatching synchronous work after CONSTRUCT: 1 jobs
[29Jul2020 18:22:47.246] [Render thread/INFO] [net.minecraftforge.fml.DeferredWorkQueue/LOADING]: Synchronous work queue completed in 00:00:00.031
[29Jul2020 18:22:47.247] [Render thread/FATAL] [net.minecraftforge.fml.ModLoader/LOADING]: Failed to complete lifecycle event CONSTRUCT, 1 errors found
[29Jul2020 18:22:47.247] [Render thread/FATAL] [net.minecraftforge.eventbus.EventBus/EVENTBUS]: EventBus 0 shutting down - future events will not be posted.
java.lang.Exception: stacktrace
	at net.minecraftforge.eventbus.EventBus.shutdown(EventBus.java:317) [eventbus-3.0.3-service.jar:?]
	at net.minecraftforge.fml.client.ClientModLoader.lambda$createRunnableWithCatch$5(ClientModLoader.java:111) [?:?]
	at net.minecraftforge.fml.client.ClientModLoader$$Lambda$2787/937346147.run(Unknown Source) [?:?]
	at net.minecraftforge.fml.client.ClientModLoader.begin(ClientModLoader.java:93) [?:?]
	at net.minecraft.client.Minecraft.<init>(Minecraft.java:425) [?:?]
	at net.minecraft.client.main.Main.main(Main.java:149) [?:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_51]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_51]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_51]
	at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_51]
	at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:51) [forge-1.16.1-32.0.97.jar:32.0]
	at net.minecraftforge.fml.loading.FMLClientLaunchProvider$$Lambda$480/889260651.call(Unknown Source) [forge-1.16.1-32.0.97.jar:32.0]
	at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-6.1.1.jar:?]
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-6.1.1.jar:?]
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-6.1.1.jar:?]
	at cpw.mods.modlauncher.Launcher.run(Launcher.java:81) [modlauncher-6.1.1.jar:?]
	at cpw.mods.modlauncher.Launcher.main(Launcher.java:65) [modlauncher-6.1.1.jar:?]
[29Jul2020 18:22:50.679] [Render thread/INFO] [com.mojang.text2speech.NarratorWindows/]: Narrator library for x64 successfully loaded
[29Jul2020 18:22:50.919] [Render thread/INFO] [net.minecraft.resources.SimpleReloadableResourceManager/]: Reloading ResourceManager: Default, Mod Resources
[29Jul2020 18:22:51.086] [Worker-Main-8/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Configuration file C:\Users\NW Wind\Twitch\Minecraft\Instances\Valhelsia 3 (1)\config\jeresources-common.toml is not correct. Correcting
[29Jul2020 18:22:51.087] [Worker-Main-8/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key itemsPerColumn was corrected from null to 4
[29Jul2020 18:22:51.089] [Worker-Main-8/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key itemsPerRow was corrected from null to 4
[29Jul2020 18:22:51.092] [Worker-Main-8/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key diyData was corrected from null to true
[29Jul2020 18:22:51.093] [Worker-Main-8/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key showDevData was corrected from null to false
[29Jul2020 18:22:51.095] [Worker-Main-8/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key enchantsBlacklist was corrected from null to [flimflam, soulBound]
[29Jul2020 18:22:51.099] [Worker-Main-8/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key hiddenTabs was corrected from null to []
[29Jul2020 18:22:51.100] [Worker-Main-8/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key dimensionsBlacklist was corrected from null to [-11]
[29Jul2020 18:22:51.151] [Worker-Main-8/ERROR] [net.minecraftforge.fml.ModLoader/LOADING]: Skipping lifecycle event SETUP, 1 errors found.
[29Jul2020 18:22:51.151] [Worker-Main-8/FATAL] [net.minecraftforge.fml.ModLoader/LOADING]: Failed to complete lifecycle event SETUP, 1 errors found
[29Jul2020 18:22:51.151] [Worker-Main-8/FATAL] [net.minecraftforge.eventbus.EventBus/EVENTBUS]: EventBus 0 shutting down - future events will not be posted.
java.lang.Exception: stacktrace
	at net.minecraftforge.eventbus.EventBus.shutdown(EventBus.java:317) [eventbus-3.0.3-service.jar:?]
	at net.minecraftforge.fml.client.ClientModLoader.lambda$createRunnableWithCatch$5(ClientModLoader.java:111) [?:?]
	at net.minecraftforge.fml.client.ClientModLoader$$Lambda$2787/937346147.run(Unknown Source) [?:?]
	at net.minecraftforge.fml.client.ClientModLoader.startModLoading(ClientModLoader.java:119) [?:?]
	at net.minecraftforge.fml.client.ClientModLoader.lambda$onreload$3(ClientModLoader.java:101) [?:?]
	at net.minecraftforge.fml.client.ClientModLoader$$Lambda$3626/1513968288.run(Unknown Source) [?:?]
	at net.minecraftforge.fml.client.ClientModLoader.lambda$createRunnableWithCatch$5(ClientModLoader.java:109) [?:?]
	at net.minecraftforge.fml.client.ClientModLoader$$Lambda$2787/937346147.run(Unknown Source) [?:?]
	at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1618) [?:1.8.0_51]
	at java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1610) [?:1.8.0_51]
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) [?:1.8.0_51]
	at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056) [?:1.8.0_51]
	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1689) [?:1.8.0_51]
	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157) [?:1.8.0_51]
[29Jul2020 18:22:58.912] [Worker-Main-14/WARN] [net.minecraft.client.audio.SoundHandler/]: File endergetic:sounds/entity/puffbug/puffbug_hurt_1.ogg does not exist, cannot add it to event endergetic:entity.puffbug.hurt
[29Jul2020 18:23:05.244] [Worker-Main-9/ERROR] [net.minecraftforge.fml.ModLoader/LOADING]: Skipping lifecycle event ENQUEUE_IMC, 1 errors found.
[29Jul2020 18:23:05.244] [Worker-Main-9/FATAL] [net.minecraftforge.fml.ModLoader/LOADING]: Failed to complete lifecycle event ENQUEUE_IMC, 1 errors found
[29Jul2020 18:23:05.244] [Worker-Main-9/FATAL] [net.minecraftforge.eventbus.EventBus/EVENTBUS]: EventBus 0 shutting down - future events will not be posted.
java.lang.Exception: stacktrace
	at net.minecraftforge.eventbus.EventBus.shutdown(EventBus.java:317) [eventbus-3.0.3-service.jar:?]
	at net.minecraftforge.fml.client.ClientModLoader.lambda$createRunnableWithCatch$5(ClientModLoader.java:111) [?:?]
	at net.minecraftforge.fml.client.ClientModLoader$$Lambda$2787/937346147.run(Unknown Source) [?:?]
	at net.minecraftforge.fml.client.ClientModLoader.finishModLoading(ClientModLoader.java:133) [?:?]
	at net.minecraftforge.fml.client.ClientModLoader.lambda$onreload$4(ClientModLoader.java:103) [?:?]
	at net.minecraftforge.fml.client.ClientModLoader$$Lambda$3628/1587010134.run(Unknown Source) [?:?]
	at java.util.concurrent.CompletableFuture.uniRun(CompletableFuture.java:705) [?:1.8.0_51]
	at java.util.concurrent.CompletableFuture$UniRun.tryFire(CompletableFuture.java:687) [?:1.8.0_51]
	at java.util.concurrent.CompletableFuture$Completion.exec(CompletableFuture.java:443) [?:1.8.0_51]
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) [?:1.8.0_51]
	at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056) [?:1.8.0_51]
	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1689) [?:1.8.0_51]
	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157) [?:1.8.0_51]```

Update: After some searching, this may be the issue of Forge itself. Many mods seem to be broken with Forge 32.0.90+

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.