masterpi-2124 / cnweb30-backend Goto Github PK

Problem with PUT /quizRecords/{quiz_id}. also, createdAt is also not needed too

we have both FE and BE here, yay:

• https://cn-web.artsakh.ventures
• https://cn-web.artsakh.ventures/api
• Swagger: https://cn-web.artsakh.ventures/api/swagger

@nghiatm341 please update in swagger config. All CORS enabled.

• in Class object, it is great to have a param quizzes that shows a list of quiz IDs of that class
• When deleting a class, all quizzes of this class should be also removed too.
  @nghiatm341

Need to add this at some point

Also save IP to prevent multiple input from the same machine

Sau khi chọn class, click Continue hệ thống k chuyển sang giao diện điền thông tin quiz mới.

Finally, users

## 1. Students submitted more than once
Check student ID and IP address. First, check the IP to prevent further access. then still allow students to submit and return failure if the ID is in the list. That failed record should still be in the records list handled from front

• In GET /quizRecords/{quizId}, it could be great if we have IPList array containing all IP addresses that have submitted the quiz
• Check student ID and return if the ID is in the records
• In the note param, change the value to FAIL_EXISTED instead of the default uninformative a note

2. The student location is too far

When the quiz asks for a student's location, it will calculate the distance to the teacher's location and return if it is far or not. In the far case, it will prevent the student from going further, but it also should save the IP address in the records to prevent future submissions from the same device.

• A record can also contain empty studentId and studentName, but IP is the failed IP
• note param now is FAIL_DISTANCE

3. Incorrect teacher's location

Some users will find a way to change the teacher's location by changing lat and lon in the URL path to their coordination and thus their submission will be valid.

• Because we can't add that location in the process of creating the quiz (possible but I don't like that), we will need to convert path {quizID}?lat=12.12312&lon=32.4343 to some encoded strings so that students can not decode and change lat and lon
• some other ways in backend?

4. Expired quiz

Only apply to the case when a student is working on the quiz and press Submit button after the quiz is expired. The response should return an error and still save the record with note is FAIL_EXPIRED

• Save record with note: FAIL_EXPIRED

5. Submission amount > total students

Rarely but also need to check that. How should we handle this?

Properties:

• Name
• Classes
• Email
• Gender
• will add more....

like the title, if user want to update some information, they should be able to update the quiz. But should we add thiss? @nghiatm341

Expected these values: "Not Started", "In Progress", "Finished"

right now if I don't specify a formLink, the POST request will return 422 error

New approach: Session

• https://authjs.dev/reference/adapter/mongodb
• https://chat.openai.com/share/25578bff-305b-4427-8798-ec7aa6c3ec06

each quiz should also have these params:

• status: Incoming, happening, and finished. the status can be achieved by comparing startTime, endTime and current time
• QR raw image URL. QR logic should be executed right from back end
  proposed changes:
• change classID type from string to int
• if possible, change ID to normal number, starting from 1, not random string
• __v is unused

This was mentioned in #14 but is closed so I reopened it:

• The quiz should have a status param based on startTime and endTime params so not putting much work into the front-end.

In case we have time. whenever a quiz, a record or a class is updated, push the message to websocket and show in user's notification dashboard

failed message here:

and successful record here:

Many API are redundant, using same method, etc.

-Sau khi xóa class, thì hệ thống vẫn lưu lại class đó, chỉ xóa thông tin -> cần F5 lại thì class trống đó mới được hệ thống xóa.

• Note: bug này không tồn tại lúc xóa quiz

Thêm auth cho các routes tương ứng

yeah I fucked up with users lol. Also maybe allow them to change info?

I used a proper token and tried get all classes but it failed with this:

Just found out that with expired quiz, I was still able to PUT new records to the quizRecord after endTime lol @nghiatm341

it is used in Student section, so it has to be public

Cần validate dữ liệu nhận từ api
Làm theo phần validator của hướng dẫn sau: https://viblo.asia/p/bat-dau-nodejs-mongoose-api-authentication-crud-cho-nguoi-moi-hoc-Eb85oa66Z2G

• Số lượng sinh viên đang có thể âm.
• Các lớp học sau có thể trùng lặp các lớp học trước ( giống nhau về ID, Subject)

Change quizs to quizzes

Các logic nghiệp vụ sẽ được bàn ở đây, front cần gì back sẽ xử lý