The idea is to retrieve a list of tags associated with a commit.

In Git you can use git describe --tags --exact-match <COMMIT ID>

In Bzr you can use bzr tags -r <COMMIT ID>

In Hg you can use hg log -r <COMMIT ID> --style=xml. A tag will be present if one is associated with the commit.

In SVN we aren't supporting tags since they are part of the path.

Hi,

A tool I'm using is looking up some repository information using this library. I kept on getting a "The remote does not match the VCS endpoint" error so I investigated a bit.

Turns out that this library is getting called as follows: repo, err := vcs.NewRepo("", repoRoot). Notice the empty remote address which works fine for Git repositories but it seems to fail for Mercurial.

I think this is a bug in https://github.com/Masterminds/vcs/blob/master/hg.go#L47:

m := hgDetectURL.FindStringSubmatch(string(out))
if m[1] != "" && m[1] != remote {
        return nil, ErrWrongRemote
}

should be instead:

m := hgDetectURL.FindStringSubmatch(string(out))
if remote != "" && m[1] != remote {
        return nil, ErrWrongRemote
}

I just wanted to ask if this is intended behaviour or a bug. In case this is a bug, I'd be happy to open a PR.

Continuing with our work to get glide working on Windows, @davecgh and I noticed that the identical commands were producing different results, with mine working and his failing. We believe the root cause of this issue is the differences in our git installs. I use http://git-for-windows.github.io/ while he is using git installed through msys2's pacman. My git understands Windows paths, while his does not.

When this vcs package makes a call to, e.g. clone a git repo, it appends the local path as the last argument of the command. On windows, this will be a windows path. This works with my git, but his throws errors such as:

[WARN] Update failed for github.com/btcsuite/btclog: fatal: could not create work tree dir 'D:\tmpgo\src\github.com\btcsuite\btcd\vendor\github.com\btcsuite\btclog': No such file or directory : exit status 128

which appears to be from git's stderr.

We took a look at how go (the tool) itself handled this when exec'ing git for 'go get' commands. They don't add the local path to the end of the arguments at all and instead change the relative directory:

https://github.com/golang/go/blob/e35901fd65a9c0f475de260a79b7b628d9d07ebf/src/cmd/go/vcs.go#L345-L347

This is rooted in Masterminds/glide#426.

In git, initial checkout and pulls, these are often "buffered". That information is valuable in my case (www.github.com/tony/vcsync) because I want to forward the progress of the update to stdout. Ideally, a couple of repos at a time.

At the present time, Get, Init and Update is hard-coded to use CombinedOutput, which runs the command and waits for completion. This lends me no ability run the command and observe the live output of a git pull, and due to the command and error handling for the (Get/Init/Update) on the repo being tightly-coupled, I can't trivially compose a command for my case without duplicating 90% of the code.

I'm going to present a PR for this for your opinion.

It seems locale messages can get into the output. See Masterminds/glide#511.

The func detectRemoteFromInfoCommand(infoOut string) (string, error) returns a remote with a trailing "cariagge return".
If this remote is used the commands issued to svn will always respond with an error.

My solution ..

func detectRemoteFromInfoCommand(infoOut string) (string, error) {
sBytes := []byte(infoOut)
urlIndex := strings.Index(infoOut, "URL: ")
if urlIndex == -1 {
return "", fmt.Errorf("Remote not specified in svn info")
}
urlEndIndex := strings.Index(string(sBytes[urlIndex:]), "\n")
if urlEndIndex == -1 {
urlEndIndex = strings.Index(string(sBytes[urlIndex:]), "\r")
if urlEndIndex == -1 {
return "", fmt.Errorf("Unable to parse remote URL for svn info")
}
}

// bugfix : there is a carriage return at the end we need to remove from the string
// original ..
// return string(sBytes[(urlIndex + 5):(urlIndex + urlEndIndex)]), nil

return string(sBytes[(urlIndex + 5):(urlIndex + urlEndIndex) - 1]), nil

}

This is a loose "version" and is different from the Version method which returns a revision. For example, in Git if you're on a branch that name would be returned. If on a tag that name would be returned. Otherwise a revision is returned.

This is a little more difficult in other VCS and am still working out the details if it's possible.

Git

1. Run git symbolic-ref HEAD to see if this is a branch and get the name. If not use Version() to get the revision and TagsFromCommit() to get a tag if one is present.
2. Similar to the first but instead read directly from the file .git/HEAD for the first step.

Hg

1. Run hg parent -T "{node}" to get current commit. Then compare that to hg parent -r tip -T "{node}" to see if on the tip of the branch. If so, hg branch to get the name. Otherwise, use TagsFromCommit() to see if on a tag to return. Or, return commit id.

TODO:

• Bzr
• Strategy for Svn

This happens when enabling ControlMaster in openssh. Seems to be related to golang/go#13155.

~/.ssh/config looks like this:

ControlMaster auto
ControlPath ~/.ssh/master-%r@%h:%p
ControlPersist 10m

Error from Masterminds/glide#292 where git isn't able to create the parent directory.

Maybe I'm doing it wrong, but I expected something like this to work:

package main

import (
  "github.com/Masterminds/vcs"
  "io/ioutil"
  "fmt"
)

func main() {
//remote := "https://github.com/Masterminds/vcs"  // works
remote := "file:///Users/pburkholder/tmp/vcs" // panics
local, _ := ioutil.TempDir("", "go-vcs")
fmt.Println(local)

repo, _ := vcs.NewRepo(remote, local)
// Returns: instance of GitRepo

repo.Vcs()
// Returns Git as this is a Git repo

err := repo.Get()
// Pulls down a repo, or a checkout in the case of SVN, and returns an
// error if that didn't happen successfully.
if err != nil {
    fmt.Println(err)
    }

    err = repo.UpdateVersion("master")
    // Checkouts out a specific version. In most cases this can be a commit
    // id,
    // branch, or tag.
    if err != nil {
        fmt.Println(err)
    }
}

but I get

panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0xb0 pc=0x21d7]

goroutine 1 [running]:
panic(0x3c2c60, 0xc82000a0f0)
    /usr/local/Cellar/go/1.6.2/libexec/src/runtime/panic.go:481 +0x3e6
main.main()
    /Users/pburkholder/tmp/t/t.go:18 +0x197
exit status 2

For a downstream project I'd find it useful to reference repositories by local filesystem paths, so that this package works similarly to:

git clone file:///Users/pburkholder/tmp/vcs
# and
git clone https://github.com/Masterminds/vcs

Thanks, Peter

REDACTED
This problem is due to interactions between internal systems and not related to the open source module.

isDetachedHead parses git status output and looks for "HEAD detached at" Obviously, this fails for any non-english locale. I don't want to be a dick, but this is insanely brittle 😏

A possible improvement would be resetting LANG before running git. An even better solution would be checking the contents of .git/HEAD — this would avoid breakage from future changes of this message. I can provide a pull request if any of these changes would be OK with you.

See Masterminds/glide#77 for an example of this issue in action.

When there is an access denied or not found on a site like bitbucket it falls through to go-get attempts and xml parsing errors can bubble up. See Masterminds/glide#370.

See Masterminds/glide#604

As title

See the report on Glide:
Masterminds/glide#60

As a developer, I would like to be able to selectively run tests, so I do not test code I did not modify.

As a developer, I would like to be able to selectively run tests, so I do not need to install tools I do not normally use (BZR, SVN, et al) just so I can get tests to pass when testing locally.

AC: "+build" tags added to *_test.go files, and CI config files to test all by default.

Hello,

How would you calculate the count difference between the current local commit and last commit on HEAD?

I can do a simple Fetch with RunFromDir, but I see no commit history functions.
(Great piece of library BTW 👍 )

The Get function on hg should get and checkout the codebase. This has caused an issue on Masterminds/glide#65.

The issue is that Get isn't checking out the codebase. Also, the update command isn't pulling the latest changes if they exist.

I'm running Version() on a repo and it should return an error but it doesn't.

Running this at the console reveals:

$ hg --debug identify
*** failed to import extension hggit from ~/code/hg-git/hggit: [Errno 2] No such file or directory: '/Users/kevin/code/hg-git/hggit'
a5494ba2177ff9ef26feb3c155dfecc350b1a8ef

Version() returns "***". The first line is printed to stderr, so filtering out stderr should be sufficient, or returning an error, either seems like it should suffice.

Bug description

When glide tries to perform submodule cleanup, it fails with

    git_test.go:440: checking out needed version failed with err: msg: Unexpected error while defensively cleaning up after possible derelict nested submodule directories: exit status 128
        orig: exit status 128
        out: Entering 'subm1'
        error: unknown switch `x'
        usage: git submodule--helper foreach [--quiet] [--recursive] [--] <command>
        
            -q, --quiet           Suppress output of entering each submodule command
            --recursive           Recurse into nested submodules
        
        fatal: run_command returned non-zero status while recursing in the nested submodules of subm1

Responsible code

The responsible code seems to be at:

Findings from debugging

I tried to build the tests and run them and they do fail, too:

$ go test -c ./...
$ ./vcs.test --test.run "TestGit.*"
--- FAIL: TestGitSubmoduleHandling (8.48s)
    git_test.go:440: checking out needed version failed with err: msg: Unexpected error while defensively cleaning up after possible derelict nested submodule directories: exit status 128
        orig: exit status 128
        out: Entering 'subm1'
        error: unknown switch `x'
        usage: git submodule--helper foreach [--quiet] [--recursive] [--] <command>
        
            -q, --quiet           Suppress output of entering each submodule command
            --recursive           Recurse into nested submodules
        
        fatal: run_command returned non-zero status while recursing in the nested submodules of subm1
        .
--- FAIL: TestGitSubmoduleHandling2 (3.64s)
    git_test.go:551: Unexpected error while defensively cleaning up after possible derelict nested submodule directories: exit status 128
FAIL

It almost seemed like the error would be in os/exec but I when I compile and run the following, it does not fail like the above:

package main

import (
  "os/exec"
  "fmt"
)

func main() {
    cmd := "git"
    args := []string{"submodule", "foreach", "--recursive", "git", "clean", "-x", "-d", "-f", "-f"}
	c := exec.Command(cmd, args...)
	out, err := c.CombinedOutput()
    fmt.Printf("out: %v\n", out)
    fmt.Printf("err: %v\n", err)

Therefore the failure seems to be somewhere else.

System details

Details about my system:

$ uname -ar
Linux standa-arch 5.1.15-arch1-1-ARCH #1 SMP PREEMPT Tue Jun 25 04:49:39 UTC 2019 x86_64 GNU/Linux
$ git --version
git version 2.22.0
$ go version
go version go1.12.6 linux/amd64

Hi,

Thanks for the great work on glide! It seems pretty streaigh-forward to me and helps really a lot to manage dependecies.
There is one thing I've noticed about the VCS detection. I have some dependendies of my project in private repositories and Glide cannot detect the vcs from the package name. I can fix this by specifying repo and vcs in the glide.yml, but I think it could be done automatically. The go-import header in the HTML fetched afterwards (see https://github.com/Masterminds/vcs/blob/master/vcs_remote_lookup.go#L107) contains the right VCS. The HTML is just not fetched, because the function returns the error before. By changing the flow here, the usibility could be improved without breaking anything.

Best regards

Found on Masterminds/glide#121, it seems remote references not yet pulled locally (e.g., a branch that has not been checked out yet after a repo has been cloned).

https://developer.atlassian.com/cloud/bitbucket/bitbucket-api-changes-gdpr/

This is used here and will return a 410.

Even though branches and tags in svn are just convention, it seems like it'd still be useful to enumerate those tags/branches that follow the basic convention.

As it stands, not having data reported back from there makes it nigh-impossible (in [vsolver][https://github.com/sdboyer/vsolver]-land, anyway) to have dependencies on such repos at all.

...ofc, we could also basically just ignore svn... :)

see Masterminds/glide#221

A method that is designed solely for determining the existence of the upstream project as cheaply as possible would be invaluable for careful performance optimizations in vsolver.

I am trying to use Glide on Linux and Windows, and for one of my modules with submodules, it's failing on Windows. Some Googling revealed Glide issue #745, which referenced line 388 in git.go.
After manually trying the underlying git commands on my Windows, I think root cause is that "git submodule foreach ... --prefix=..." passes the prefix string as a doublequote delimited string to Windows bash, and the trailing '' (Windows PathDelimiter) escapes the closing doublequote, which Breaks Things (tm). My inelegant solution is to create helper function which is used to conditionally rewrite the path string on Windows by tripling every PathDelimiter, i.e., '' becomes '\' - and this seems to solve the problem. I also added another test using a publicly accessible repo which exercised the original problem which led me to work on this in the first place.

TestVCSLookup Test Fails:

When I try the default github ssh urls:

"[email protected]:Masterminds/VCSTestRepo.git": {work: true, t: Git},

Hi,

helm is using this go library for installing plugins.

I got an error today, if there is a branch name which has the same name as a local file:

% helm plugin install "https://github.com/jkroepke/helm-secrets" --version "dockerfile"
Error: Unable to update checked out version: exit status 128
% ls Dockerfile
Dockerfile
% git checkout dockerfile
fatal: 'dockerfile' could be both a local file and a tracking branch.
Please use -- (and optionally --no-guess) to disambiguate

To fix this, add 2 hypen at the end of the command, for example:

% git checkout dockerfile --
branch 'dockerfile' set up to track 'origin/dockerfile'.
Switched to a new branch 'dockerfile'

See: https://stackoverflow.com/questions/25322335/git-change-branch-when-file-of-same-name-is-present

Code, needs to be changed:

Git Version: git version 2.39.1

When trying to retrieve golang.org/x/net/context it's failing because the prefix to match is golang.org/x/net and it's looking for an exact match.

I'm trying to work with multiple git repos at the same but am having issues.
3 git repos all hosted on github.

package main

import (
    "log"
    "sync"

    "github.com/Masterminds/vcs"
)

var (
    base = "/srv/apps/"
)

func main() {
    var (
        dirs    = []string{"a", "b", "c"}
        release = "release/4.1.0"
        remotes = map[string]string{
            "a": "[email protected]:fake/a.git",
            "b": "[email protected]:fake/b.git",
            "c": "git@fake/c.git",
        }
    )

    pg := new(sync.WaitGroup)
    for _, val := range dirs {
        pg.Add(1)
        go updateRepo(val, remotes[val], release, pg)
    }
    pg.Wait()
}

func updateRepo(local string, remote string, rel string, pg *sync.WaitGroup) {
    local = base + local

    log.Printf("%s -- %s -- %s\n", local, remote, rel)

    repo, err := vcs.NewGitRepo(remote, local)
    if err != nil {
        log.Printf("In Error: %s -- %s -- %s\n", local, remote, rel)
        log.Fatalln(err)
    }
    if repo.CheckLocal() {
        log.Printf("Local good: %s\n", local)
    }

    pg.Done()
}

I would expect this output everytime(assuming all git repos are there)

2015/10/19 11:59:02 /srv/apps/c -- [email protected]:fake/c.git -- release/4.1.0
2015/10/19 11:59:02 /srv/apps/a -- [email protected]:fake/a.git -- release/4.1.0
2015/10/19 11:59:02 /srv/apps/b -- [email protected]:fake/b.git -- release/4.1.0
2015/10/19 11:59:02 Local good: /srv/apps/c
2015/10/19 11:59:02 Local good: /srv/apps/a
2015/10/19 11:59:02 Local good: /srv/apps/b

However I sometimes I get this:

2015/10/19 11:58:40 /srv/apps/c -- [email protected]:fake/c.git -- release/4.1.0
2015/10/19 11:58:40 /srv/apps/a -- [email protected]:fake/a.git -- release/4.1.0
2015/10/19 11:58:40 /srv/apps/valuation -- [email protected]:fake/b.git -- release/4.1.0
2015/10/19 11:58:40 Local good: /srv/apps/c
2015/10/19 11:58:40 In Error: /srv/apps/a -- [email protected]:fake/a.git -- release/4.1.0
2015/10/19 11:58:40 The Remote does not match the VCS endpoint

Is it possible to execute a sparse checkout based on the full remote URL path to a folder within a Git repo? Similarly to how go get ... works. Might be related to #68