mastercard / client-encryption-php Goto Github PK

Is your feature request related to a problem? Please describe.

This package is not compatible with PHP 8.0

Describe the solution you'd like

PHP 8.0 has been out for 7 months now, this package should support it.

Describe alternatives you've considered

Since PHP 7.3 security support and PHP 7.4 active support will end in 4 months - organizations are upgrading to PHP 8.0, there's no choice but to support it.

Additional context

Add any other context or screenshots about the feature request here.

Is your feature request related to a problem? Please describe.

The parameter and return types are either missing or were added incorrectly, resulting in missing or wrong type inference and requires inspecting quite some code to determine the correct variable types.

Describe the solution you'd like

Parameter and return types should be added to code for developer convenience and possibility to use static code analysis in user code.

Describe alternatives you've considered

The existing PhpDocs at the very least should not be in a wrong format or removed altogether.

Additional context

Bug Report Checklist

• Have you provided a code sample to reproduce the issue?
• Have you tested with the latest release to confirm the issue still exists?
• Have you searched for related issues/PRs?
• What's the actual output vs expected output?
  Failed to run vs Ran successfully

Description
The Github actions fail to run with PHP versions < 7.2

To Reproduce
Using the current master branch trigger a run

Expected behavior
The action "Build and Test" should execute successfully

Screenshots

Additional context

Related issues/PRs

Suggest a fix/enhancement
No longer use php-actions/composer and switch to manually running composer install commands

cardInfo is now fundingAccountInfo