Giter Club home page Giter Club logo

foreman's People

Contributors

deepsourcebot avatar josephmancuso avatar lazyguru avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

foreman's Issues

Add a "default" driver

If we can't determine what driver to use, we should fallback to a default one (Maybe this is Masonite? Or should it be something else?)

Coverage report on build is broken

The test coverage report on builds is broken. It needs to have the following added to the workflow config:

env:
  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

However, the coverage is also being reported wrong.

Don't overwrite Nginx config

It should not be needed to completely overwrite the nginx config file. We should be able to just patch it or add our configuration in a non-destructive way

Need to better handle brew package upgrades

When running foreman install and a package (eg Nginx) is already installed but with an outdated version, the following occurs:

Installing NGINX ..
==> Downloading https://homebrew.bintray.com/bottles/nginx-1.19.5.catalina.bottle.tar.gz
==> Downloading from https://d29vzk4ow07wi7.cloudfront.net/aff0c071bc1b2e8e84e0dd99ffe01a6a29fc6fc933372099bb2aa55d312
######################################################################## 100.0%
Error: nginx 1.19.4 is already installed
To upgrade to 1.19.5, run `brew upgrade nginx`.

  CalledProcessError

  Command '['/usr/local/bin/brew', 'install', 'nginx']' returned non-zero exit status 1.

  at ~/.pyenv/versions/3.7.9/lib/python3.7/subprocess.py:512 in run
       508│             raise
       509│         retcode = process.poll()
       510│         if check and retcode:
       511│             raise CalledProcessError(retcode, process.args,
    →  512│                                      output=stdout, stderr=stderr)
       513│     return CompletedProcess(process.args, retcode, stdout, stderr)
       514│
       515│
       516│ def list2cmdline(seq):

We should handle this more gracefully

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.