Giter Club home page Giter Club logo

hedron's People

Contributors

pmaselkowski avatar

Stargazers

avatar

Watchers

avatar avatar

hedron's Issues

[Insight] Methods and properties visibility should always be explicitly defined - in src/Finder/Filter.php, line 49

in src/Finder/Filter.php, line 49

This method has no explicit visibility which may lead to maintenability issues. You should always declare a visibility for methods and properties.

	 * @author Piotr Maselkowski <pmaselkowski at gmail.com>
	 * @param                      $workingDir
	 * @param array                $config
	 * @param LoggerInterface|null $output
	 */
	function __construct($workingDir, $config = [], LoggerInterface $output = null)
	{
		$this->workingDir = $workingDir;
		$this->filter = new FileFilter;

		if (empty($output))

Posted from SymfonyInsight

Some leftover, should be public function...

Take care of unset composer.json properties

Current:

$ vendor/bin/hedron show
This is how template will look like in files:
PHP Notice:  Undefined index: name in C:\geo\gml-exporter\vendor\maslosoft\hedron\src\Configuration.php on line 72
PHP Stack trace:
PHP   1. {main}() C:\geo\gml-exporter\vendor\maslosoft\hedron\hedron:0
PHP   2. Symfony\Component\Console\Application->run() C:\geo\gml-exporter\vendor\maslosoft\hedron\hedron:39
PHP   3. Symfony\Component\Console\Application->doRun() C:\geo\gml-exporter\vendor\symfony\console\Application.php:145
PHP   4. Symfony\Component\Console\Application->doRunCommand() C:\geo\gml-exporter\vendor\symfony\console\Application.php:262
PHP   5. Maslosoft\Hedron\Commands\RenderTemplateCommand->run() C:\geo\gml-exporter\vendor\symfony\console\Application.php:886
PHP   6. Maslosoft\Hedron\Commands\RenderTemplateCommand->execute() C:\geo\gml-exporter\vendor\symfony\console\Command\Command.php:255
PHP   7. Maslosoft\Hedron\Configuration->load() C:\geo\gml-exporter\vendor\maslosoft\hedron\src\Commands\RenderTemplateCommand.php:48
/**
 * This software package is licensed under `` license[s].
 *
 * @package
 * @license
 *
 */

Expected
When some property is not set, do something wise:

  • Show information
  • Set some default value

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.