masl123 / ym2151-arduino-software Goto Github PK

There are two tiny memory leaks when using EEPROMManager.load(...), because the method allocates a Buffer that is never deallocated:

• A Byte is leaked at setMasterTune(*EPROMManager.load(0x00, 1)); in void YM2151DriverClass::init().
• Another Byte is leaked at the check if (value != *EPROMManager.load(0x00, 1)) in void YM2151DriverClass::setMasterTune(uint8_t value)

These leaks are rather unproblematic. During normal use the "master tune" is read only once from EEPROM at startup and thus a byte is leaked. The more problematic case happens if the user wants to set the "Master Tune" using a sysex-message, but as long as one does not send lots of those sysex-Messages, the Arduino should be able to handle the situation.