marvellembeddedprocessors / a3700-utils-marvell Goto Github PK

While building arm-trusted-firmware 2.5 with A3700-utils-marvell with GCC11, I get the following error:

[   95s] src/TimDescriptorParser.cpp: In member function 'bool CTimDescriptorParser::ParseExtendedReservedData(CCommandLineParser&)':
[   95s] src/TimDescriptorParser.cpp:2685:28: error: ordered comparison of pointer with integer zero ('CImageDescription*' and 'int')
[   95s]  2685 |                 if (pImage > 0
[   95s]       |                     ~~~~~~~^~~
[   95s] g++ -DINCDIR=/usr/include/cryptopp -I./inc -I. -L/usr/lib64 -std=c++11 --debug -c src/TzInitialization.cpp -o release/TzInitialization.o 
[   95s] make: *** [TBB_linux.mak:180: release/TimDescriptorParser.o] Error 1
[   95s] make: *** Waiting for unfinished jobs....

Marvell SDK-10.3.5.0-PR1 contains new version of a3700_utils with new patches which are not available in the publically latest branch A3700_utils-armada-18.12-fixed.

Please publish latest version of a3700_utils from Marvell SDK which is currently available only under NDA.

When trying to build the branch A3700_utils-armada-18.12-fixed I get:

michael@fedora ~/git/marvell/A3700-utils-marvell(A3700_utils-armada-18.12-fixed) » make DDR_TOPOLOGY=2                                                              2 ↵
make PLATFORM=a3700 --no-print-directory -C  DDR_TYPE=DDR3 clean
make[1]: *** DDR_TYPE=DDR3: No such file or directory.  Stop.
make: *** [Makefile:21: mv_ddr] Error 2

With make mv_ddr being able to find the *** DDR_TYPE=DDR3: directory during compilation and fails to build.

Using openSUSE Tumbleweed cross-gcc-arm-none-gcc7's arm-none-eabi-gcc 7.3.1 I get:

[  132s]   CC    clock.c
[  132s] clock.c: In function 'set_tbg_clock':
[  132s] clock.c:397:6: warning: implicit declaration of function 'get_ref_clk'; did you mean 'get_ddr_clock'? [-Wimplicit-function-declaration]
[  132s]   if (get_ref_clk() == 40) {
[  132s]       ^~~~~~~~~~~
[  132s]       get_ddr_clock

ddr/wtmi_ddr/clock.c:   if (get_ref_clk() == 40) {
...
wtmi/clock.h:u32 get_ref_clk(void);

Should ddr/wtmi_ddr/clock.c or ddr/wtmi_ddr/clock.h do #include "../../wtmi/clock.h"?

I don't know why, might be a kernel thing, but strace reports open("/dev/ttyUSB0".... This means the call doesn't return, so unfortunately something in the program needs to change prior to calling open.

I know the addition of O_NONBLOCK changes the ABI slightly, so you should skim the rest of the code looking for places were u might want to block/flush. I think there is a read() somewhere in a loop after sending wtp\CR, for example.

diff --git a/wtptp/src/Wtpdownloader_Linux/src/UARTPortLinux.cpp b/wtptp/src/Wtpdownloader_Linux/src/UARTPortLinux.cpp
index fa1cd9e..bae0c33 100644
--- a/wtptp/src/Wtpdownloader_Linux/src/UARTPortLinux.cpp
+++ b/wtptp/src/Wtpdownloader_Linux/src/UARTPortLinux.cpp
@@ -127,7 +127,7 @@ void CUARTPortLinux::OpenPort() throw (CWtpException)
        UARTDeviceName ="/dev/ttyUSB" ;
        UARTDeviceName.append(portNumber.str());
        cout << endl << UARTDeviceName << endl;
-       uartLinuxFileDesc = open(UARTDeviceName.c_str(),O_RDWR|O_NOCTTY);
+       uartLinuxFileDesc = open(UARTDeviceName.c_str(),O_RDWR|O_NOCTTY|O_NONBLOCK);
        if(uartLinuxFileDesc < 0)
        {
                cout << endl << " ERROR: Open UART driver failed:" << endl;

We have at least three EspressoBin v7 1GB that boot reliably with U-Boot 17.10 (as delivered by Globalscale) but need up to 5 powercylces to boot with U-Boot 18.12 (as offered by armbian.com). Output over serial console:
TIM-1.0 WTMI-devel-18.12.1-e6bb176 WTMI: system early-init SVC REV: 5, CPU VDD voltage: 1.015V
There it gets stuck most of the times booting. This happens at frequencies 1000-800 as well as 800-800.

Branch A3700_utils-armada-17.10 contains ddr/tim_ddr/ddr3_tool and ddr/tim_ddr/ddr4_tool binaries without source code or license information. These tools are called by ddr/tim_ddr/ddrparser.pl, and it unlinks the ddr/tim_ddr/ddr_static.txt output file before calling the tools, so that it cannot easily be supplied pre-generated.

a) Please add licensing information indicating that the files are redistributable.

b) Is there any chance you can add the source code for these tools, as done for TBB_linux, so that they can be rebuilt for, e.g., aarch64?

Currently I've needed to patch ddrparser.pl, commenting out the unlink and ddr3_tool parts.