@merchant_repo sales_engine items etc,
same for items
same for invoice

ideas: might be missing revenue for an invoice that has some failed transactions?

**why doesn't our revenue match up?

same holds true for transaction repo and the customer repo....

before, we were populating the repos by calling the sales_engine object.

initializing for these repos looks different

can we extract out methods related to iteration 4: merchant analytics

currently, we're converting the unit price to a float.

we want to use BigDecimal (BigDecimal.new?)

when it says unit price 700, i think that means 7.00 (specify that it goes two decimal places in big decimal to generate a unit price of 7.00)

possible solutions: brute force with spec harness,

**Why are we letting 7 merchants slip through the conditional crack?

spec says se = SalesEngine.from_csv({
:items => "./data/items.csv",
:merchants => "./data/merchants.csv",
})

mr = se.merchants
merchant = mr.find_by_name("CJsDecor")

=>

but in the spec, we haven't initialized SalesEngine first.

it currently is inside the csv_parser module, but we could just have the parser take the data into rows and save it.

we could then grab the info we need in the item_repo and merchant_repo class.

average_invoices_per_day = 712.14
std_dev = 211.27 (with .ceil, it's 212).

Mon 922
T 618
W 945
T 348
Fri 937
Sat 596
Sun 619

Which days of the week see the most sales?

On which days are invoices created at more than one standard deviation above the mean?

it "#top_days_by_invoice_count returns days with an invoice count more than one standard deviation above the mean" do
expected = sales_analyst.top_days_by_invoice_count

  expect(expected.length).to eq 1
  expect(expected.first).to eq "Wednesday"
  expect(expected.first.class).to eq String
end

ask somebody about stylistically

name should be items_truncated.csv
merchants_truncated.csv

create method that will run first. then use instance variables for all other tests

wednesday should have the most

Date::DAYNAMES

change could be made in line 9 of csv_parser module

• current line 9
  @merchants << Merchant.new({id: row[:id], name: row[:name]})
• change to integer when passing in the row id.
  @merchants << Merchant.new({id: row[:id].to_i, name: row[:name]})

spec harness says: it "#find_by_id finds a merchant by id" do
id = 12335971
expected = engine.merchants.find_by_id(id)

  expect(expected.id).to eq 12335971
  expect(expected.name).to eq "ivegreenleaves"

Currently, the merchant_id is a string

pass in self from se to item_repo/merchant_repo

• add the self/instance variable in the initialize
  pass in self from repo to item/merchant
• add the self/instance variable in the initialize

• day of the week
• unnecessarily long or complicated methods