marlon-sousa / enhancedfinddialog Goto Github PK

First, great addon!
I wanted to remap shortcuts for find features for browse mode to different shortcuts.
I typed the word "find" in the filtered by in the input gestures dialog, and the result was empty.
I removed the enhanced find dialog and searched again, and they appeared inside the browse mode.
Just out of curiosity, I reinstalled the addon, and searched again, and the result was empty.
I'm on nvda 2024.2.rc2.
Could you look into it?
Thanks so much!

Hello

When running NVDA in English, in the add-on manager, one cannot access the add-on's documentation.
On the contrary, the add-on's translated documentation is available through add-on manager (e.g. Franch in my case).

The English documentation exists in any case since it is on the GitHub page.

Could you please add it as it is done automatically for the other add-ons based on the add-on template?
Thanks.

Hello Marlon

Issue

The find dialog of this add-on has a very bad layout. It is missing margins around and between controls. It is specifically very bad for visually impaired people who may have difficulty to identify and separate two adjacent controls or even the content of the find window and the content of the window below.

Solution

Copy the way NVDA's find dialog is made to get a similar layout.

Many thanks.

Hi again @marlon-sousa

Here is another feature request.
The dialog indicating that there is no more match when performiing a search operation is not very nice.
It gives you an information, but the only operation is press OK to validate it.

A smoother flow would be to indicate by speech or by a special beep that no match can be found.

There are 2 situation to be tested where this "No match" dialog can appear:

• After pressing OK in the find dialog
• After pressing F3/shift+F3 to find next/previous occurrence

Before using your add-on, I had coded a prototype of this feature; you can find it here.

Note: this is a Add-on API compatibility breaking release. Add-ons will need to be re-tested and have their manifest updated.

• NVDA 2022.1beta4 available for testing

cc: @marlon-sousa

Thank you for your help.

Hi,
This issue may caused by NVDA 2021.1 addon API compatibility breaking.

NVDA what's new: Note: this is an Add-on API compatibility breaking release. Add-ons will need to be re-tested and have their manifest updated.

Steps to reproduce:

1. Press NVDA+control+f to find string.
2. Press enter to search.
3. press NVDA+f3 to find next

Actual behavior:

NVDA no response.

Expected behavior:

Find next works as expected.

System configuration

NVDA installed/portable/running from source:

portable

NVDA version:

2021.1rc2

Windows version:

Windows 10 20H2 (10.0.19042)

add-on version:

Enhanced Find Dialog 1.1.0 addon

Other questions

Does the issue still occur after restarting your computer?

Yes.

If add-ons are disabled, is your problem still occurring?

No.

log message:

Input: kb(laptop):NVDA+f3
ERROR - scriptHandler.executeScript (02:27:47.491) - MainThread (5488):
error executing script: <bound method script_enhancedFindNext of <virtualBuffers.gecko_ia2.Gecko_ia2 object at 0x044E60F0>> with gesture 'NVDA+f3'
Traceback (most recent call last):
  File "scriptHandler.pyc", line 208, in executeScript
  File "C:\Users\surfer0627\Downloads\NVDA 2021.1\userConfig\addons\EnhancedFindDialog\globalPlugins\EnhancedFindDialog\cursorManagerHelper.py", line 72, in script_enhancedFindNext
    self.doFindText(self._searchEntries[SEARCH_HISTORY_MOST_RECENT_INDEX], caseSensitive = self._lastCaseSensitivity, searchWrap = self._searchWrap)
  File "C:\Users\surfer0627\Downloads\NVDA 2021.1\userConfig\addons\EnhancedFindDialog\globalPlugins\EnhancedFindDialog\cursorManagerHelper.py", line 92, in doFindText
    speech.speakTextInfo(info,reason=controlTypes.REASON_CARET)
AttributeError: module 'controlTypes' has no attribute 'REASON_CARET'
IO - inputCore.executeGesture (02:27:48.968) - winInputHook (11780):

Hello @marlon-sousa

Sometimes, it would be nice to be allowed to use a regular expression to perform search.
Could we add a checkbox for it in the dialog? As for many editors, the checkbox should be disabled by default.
This is probably not too hard to implement.
I may take care of it, unless you do it before me.
Thanks.

Cyrille

Currently NVDA's find function relies on system focus,
press nvda+7 “focus moves navigate object on”, every time you find the review cursor will follow the system focus.
Can we have a feature to find only in browse mode without moving the system cursor.

Hi again

In keyboard settings, activate "Allow skim reading" option.
Without this add-on, if you press F3 or shift+F3 (native NVDA commands), the virtual cursor jumps to the next or previous found item and continues say all.
With this add-on installed, if you press F3 or shift+F3 during say all, the cursor jumps to the found location but say all is stopped even if "Allow skim reading" is activated. This is unexpected and the add-on should honour NVDA's option.

Thanks.

This add-on is based on NVDA's find dialog and code has been copied and modified from there.

Since then, NVDA has received minor improvements regarding the search function:

• #11564
• #11771

#11564 is currently being integrated in the add-on thanks to #17.

#11771 still needs to be integrated in this add-on. Thanks.