Giter Club home page Giter Club logo

Comments (11)

AntonPieper avatar AntonPieper commented on May 26, 2024 2

Well, if all four were to be implemented, would that solve this problem? Feel free to suggest improvements.

  1. A Toast appears for the first error
  2. All erroneous get the dark red background
  3. A panel to show all errors that when clicked move the cursor there
  4. An icon that conditionally shows up in the top bar when there are errors that shows how many errors there are. When clicked, it opens the error panel

from shadereditor.

Martysh12 avatar Martysh12 commented on May 26, 2024

Screenshot_20230711-153658_Shader Editor.png

what is that 🫠

Looks like the OpenGL implementation on my phone doesn't like ternary operations with custom structs.

from shadereditor.

markusfisch avatar markusfisch commented on May 26, 2024

No, the Toast cannot be enlarged, unfortunately. From Toast redesign:

In Android 12, the toast view has been redesigned. Toasts are now limited to two lines of text and show the application icon next to the text.

A modern alternative would be a Bottom Sheet, I guess.

And about the missing error message: these come directly from the OpenGL driver on the phone, and yes, they can be very different or even completely missing 🤷‍♂️ Unfortunately, there's nothing the app can do about this. Apart from including a GLSL compiler/linter, which would be overkill, of course.

from shadereditor.

AntonPieper avatar AntonPieper commented on May 26, 2024

Another alternative would be to make the top bar draggable and move the full error messages there. Then one can additionally keep the old behavior of creating a Toast for the first error.

Here is a recording of my (crude) shader-editor app I made a few years ago:

screen-20230712-1537302.1.mp4

from shadereditor.

markusfisch avatar markusfisch commented on May 26, 2024

Yes, this would be another option, indeed!

My only concern would be that a user would have to know that he/she can pull down the top bar for more information 🤔

from shadereditor.

AntonPieper avatar AntonPieper commented on May 26, 2024

That's also what I thought when creating this. I have rounded the bottom corners a bit to show that it is a bigger surface (because the top has no rounded corners), but adding another handle icon (like iphone X's bottom handle for navigation) could help UX as well. Also a Problems icon could conditionally show up that opens the problems section when pressed.

Problems Icon

Material Symbols:
Problems Symbol

Material Icons:
Problems Icon

from shadereditor.

Martysh12 avatar Martysh12 commented on May 26, 2024

It would be nice to have the errors show up without giving away the focus from the editor, so if you have a bunch of errors you don't have to jump between the error view and the editor.

from shadereditor.

Zabadam avatar Zabadam commented on May 26, 2024

Well, if all four were to be implemented, would that solve this problem? Feel free to suggest improvements.

This application sorely needs these updates.

A single error message, displayed via a temporary toast of finite length, is the worst possible solution for this scenario, at any rate.

This should be a high priority issue.

from shadereditor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.