Feature Request: Lexer-/Parser-Based Syntax highlighting about shadereditor HOT 3 OPEN

from shadereditor.

The Java implementation is flawed IMO, but there also is android-tree-sitter, which is a simple dependency for Gradle. This is already used in their IDE AndroidIDE to highlight XML and Java. They (obviously) don't have GLSL grammar, but this might be a simple task as the developer kindly outlined the steps in an issue I opened. Having tried a simple example using the Java grammar (com.itsaky.androidide:tree-sitter-java:3.0.1), it seems to "just work". There also already is an official (at least linked on the official site) grammar for GLSL: theHamsta/tree-sitter-glsl.

from shadereditor.

Hello again!

I think I have now implemented a syntax highlighting solution that works quite fast. The lag now comes from the EditText and not the (separate) SyntaxEditor View. I have also moved the line numbers into its own view, however this has one side effect: when the EditText changes size vertically (i.e. a new line), the phone scrolls to put the cursor at the far left of the screen. I will look into MovementMethod to see if this can be fixed. Maybe this is not that big of a problem? Also I have increased the API level temporarily to use android/trace, this will be reverted. Of course I will open several pull requests for the various changes. You can look at the changed version here: c-highlight branch

from shadereditor.