TypeScript extension not working about knex-data-api-client HOT 5 CLOSED

Hi @honarpour,

It should work fine to use either the 0.21 or the 0.96 version of knex. I think the issue might be that there is not es-module version of this package but only a version for cjs. I'm not certain what would be needed to add support for es-modules?

from knex-data-api-client.

Hey @markusahlstrand!

For ES6 support could add Babel.
The thing is it worked when using Knex directly, that's why I thought might need to update the dependancy.
Main issue is if I refactor to CommonJS, then it throws error on the colons (:) for TS types, so can't do TS either.

from knex-data-api-client.

@markusahlstrand Yup that was the issue. I forked the repo and updated Knex to latest and am able to run migrations written in TypeScript and ES6 out of the box.

from knex-data-api-client.

@honarpour So just by updating the knex version it worked? I didn't want to bump it because then for instance objection won't work any longer. As it's just a peer dependency it should work fine with an app that has a newer version of knex installed as well.. Or am I missing something?

from knex-data-api-client.

Yeah updating version worked for migrations but importing Knex in Lambdas broke.
Seems like I was missing something... for some reason I got version clashes when installing the latest Knex in consuming project, but just tried it again and it's working everywhere!

from knex-data-api-client.