Aurora MySQL Data API - migration fails on knex_migrations insert step about knex-data-api-client HOT 6 CLOSED

Hi @vdimitrieski ,

Thanks for reporting the issue. The test for migrations and mysql is currently commented out and I can't remember when and why this happened.. I'll see if I can get it passing again.

from knex-data-api-client.

I get this error for the migrations test:

data-api-mysql
       knex-migrate
         should setup a database with knex-migrate:
     insert into `knex_migrations` (`batch`, `migration_time`, `name`) values (1, '2021-06-02 16:02:46.063', '20191220234943_init.js') - Database error code: 1292. Message: Data truncation: Incorrect datetime value: '"2021-06-02T14:02:46.063Z"' for column 'migration_time' at row 1

So, I guess it has something to do with differences in timestamps formats in mysql vs postgres?

from knex-data-api-client.

@markusahlstrand thanks for checking out. If you take a look at the error, I think the knex-generated insert command contains a well formatted datetime '2021-06-02 16:02:46.063', but when it reaches Aurora MySQL it is actually in the format '2021-06-02T14:02:46.063Z' which bounced. As this knex-generated insert command is valid, and you can actually can execute it in the Aurora query builder, I assume the error is somewhere in the middle :)

Any thoughts of what it might be?

from knex-data-api-client.

Seems like it's being passed as a datetime and we're not handing it correctly when converting it to a sql string. Should hopefully be a quick fix

from knex-data-api-client.

Published 1.5.5 with a fix that at least makes the migration test happy :) Let me know if it works for you.

from knex-data-api-client.

It works now with Aurora MySQL as well. Thanks for the fast fix!

from knex-data-api-client.