markedwardmurray / sqreorderablestackview Goto Github PK

The only initializer expects interface builder to be used, but this isn't a requirement of the class but rather an oversight. The existing internals of init(coder: Coder) can be moved to a private commonInit() func called from a each of the complete set of UIStackView's initiliazers

hey, could the temporary view also have the shadow of the actual view or how to do that?

i have this code for each element in the SQReorderableStackView (which is inside a Cell), because otherwise the TablevVew would lag terribly

self.layer.shadowPath = UIBezierPath(roundedRect:self.bounds, cornerRadius: self.layer.cornerRadius).cgPath
self.layer.shouldRasterize = true
self.layer.rasterizationScale = UIScreen.main.scale

Otherwise really love this library, soo easy!!

Hello, thanks for this awesome library,
I have small issue, I'm getting this warning "<CATransformLayer: 0x1450cf050> - changing property masksToBounds in transform-only layer, will have no effect every time I reorder stackViews"
Thanks,

sometimes (dont know why) the original view stays visible and the temporaryView seems like a ghost view, its not always though, i think after a few clicks (i reorder buttons)

First of all, thank you for your work, It saved me some hours of implementation ;)
Just to inform that there is a memory leak regarding the reorderDelegate.

public var reorderDelegate: SQReorderableStackViewDelegate?
should be declared with a weak ref
public weak var reorderDelegate: SQReorderableStackViewDelegate?

The delegate methods need the indexes of the reordering, in order to update the model (= the real list/array) so a swapAt can be applied.

I'm planing to make a PR and fix the few bugs I've found

I cannot move subviews that are inserted using insertArrangedSubview(_:at:).
Only works when subviews are added using addArrangedSubview.
But in my case, I need to use insertArrangedSubviews.