The python-paho-mqtt-for-aws-iot's discuss from mariocannistra

Risk: over-authorization of AWS IoT policy

We are a security research team and we recently discovered that there is an over-authorization security issue with this project's IoT policy.
The affected file is as following:

1. python-paho-mqtt-for-aws-iot/iotpolicy.json

Clarification on thingName and ClientID

Dear Author,

You are using thingName which is the name of a Thing and ClientID
How are these two variables:

clientId = "myThingName"
thingName = "myThingName"

used in awsiotsub.py and awsiotpub.py

Please clarify,

With Thanks and Regards
Srini

Problem with subscription

Hi Mario,
Thank you very much to share this code, I'm trying to use it with a little modification but I have a problem, this is my code:

publish:

#!/usr/bin/python3

#required libraries
import sys                                 
import ssl
import paho.mqtt.client as mutt
from time import sleep
from random import uniform

connflag = False

def on_connect(client, userdata, flags, rc):
    global connflag
    connflag = True
    print("Connection returned result: " + str(rc) )

def on_message(client, userdata, msg):
    print(msg.topic+" "+str(msg.payload))
    print("Received message from topic: "+msg.topic+" | QoS: "+str(msg.qos)+" | Data Received: "+str(msg.payload))

mqttc = mqtt.Client(client_id="RaspberryPi_2", clean_session=True)

mqttc.on_connect = on_connect
mqttc.on_message = on_message


mqttc.tls_set("/home/pi/aws_iot/things/raspberryPi_2/certs/aws-iot-rootCA.crt",
                certfile="/home/pi/aws_iot/things/raspberryPi_2/certs/0ea2cd7eb6-certificate.pem.crt",
                keyfile="/home/pi/aws_iot/things/raspberryPi_2/certs/0ea2cd7eb6-private.pem.key",
              tls_version=ssl.PROTOCOL_TLSv1_2,
              ciphers=None)

mqttc.connect("A2GF7W5U5A46J1.iot.us-west-2.amazonaws.com", port=8883)

mqttc.loop_start()

while 1==1:
    sleep(0.5)
    if connflag == True:
        tempreading = uniform(20.0,25.0)
        #jsonMessage = "{ \"state\": { \"reported\": { \"temperature\": " + str(tempreading) + "} } }"
        #mqttc.publish("$aws/things/RaspberryPi_2/shadow/update", jsonMessage, qos=1)
        mqttc.publish("topic/test",tempreading,qos=1)
        print("msg sent: temperature " + "%.2f" % temp reading )
    else:
        print("waiting for connection...")

subscription:

#!/usr/bin/python3

#required libraries
import sys                                 
import ssl
import paho.mqtt.client as mqtt
import RPi.GPIO as gpio
from time import sleep

try:
    ledPin = 25
    gpio.setmode(gpio.BCM)
    gpio.setup(ledPin, gpio.OUT)

    def on_connect(client, userdata, flags, rc):
        print("Connected with result code "+str(rc))
        client.subscribe("topic/test",1)

    def on_message(client, userdata, msg):
        print("Message received: "+str(msg.payload))

        if str(msg.payload) >= '23':
            print("High Temperature")
            print(str(msg.payload))
            GPIO.output(ledPin, GPIO.HIGH)
            time.sleep(.1)
            GPIO.output(ledPin, GPIO.LOW)


    def on_subscribe(mqttc, obj, mid, granted_qos):
        print("Subscribed: "+str(mid)+" "+str(granted_qos)+"data"+str(obj))


    mqttc = mqtt.Client(client_id="RaspberryPi_2", clean_session=True)

    mqttc.on_connect = on_connect
    mqttc.on_message = on_message
    mqttc.on_subscribe = on_subscribe


    mqttc.tls_set("/home/pi/aws_iot/things/raspberryPi_2/certs/aws-iot-rootCA.crt",
                    certfile="/home/pi/aws_iot/things/raspberryPi_2/certs/0ea2cd7eb6-certificate.pem.crt",
                    keyfile="/home/pi/aws_iot/things/raspberryPi_2/certs/0ea2cd7eb6-private.pem.key",
                  tls_version=ssl.PROTOCOL_TLSv1_2,
                  ciphers=None)

    mqttc.connect("A2GF7W5U5A46J1.iot.us-west-2.amazonaws.com", port=8883) #AWS IoT service hostname and portno

    mqttc.loop_forever()

except KeyboardInterrupt:
    pass
finally:
    gpio.cleanup()

This is the log of the publisher:

waiting for connection...
Connection returned result: 0
msg sent: temperature 20.68
msg sent: temperature 21.28
msg sent: temperature 23.76
...
msg sent: temperature 24.66
msg sent: temperature 22.92
msg sent: temperature 21.52
msg sent: temperature 20.25
Connection returned result: 0
msg sent: temperature 20.25
msg sent: temperature 20.50
msg sent: temperature 23.31
msg sent: temperature 20.85
...
msg sent: temperature 21.89
msg sent: temperature 21.97

This is the log of the subscriber:

Connected with result code 0
Subscribed: 1 (1,)dataNone
Connected with result code 0
Subscribed: 2 (1,)dataNone
Connected with result code 0
Subscribed: 3 (1,)dataNone
Connected with result code 0
Subscribed: 4 (1,)dataNone
Connected with result code 0
Subscribed: 5 (1,)dataNone

So as you can see there is no print of the on_message function, following your solution on the only issue in this project and i have tried this:

jsonMessage = "{ \"state\": { \"reported\": { \"temperature\": " + str(tempreading) + "} } }"
mqttc.publish("$aws/things/RaspberryPi_2/shadow/update", jsonMessage, qos=1)

and the Thing Shadow on AWS IoT is update, so I think that the connection with AWS is established, can you help me?

I noticed another thing if it can be useful to help me, if I run only the subscriber without the publisher this is the log:

Connected with result code 0
Subscribed: 1 (1,)dataNone

only one subscription, so it seems that something happens when I start to publish, but it does not work, I hope you can help me thanks

mariocannistra / python-paho-mqtt-for-aws-iot Goto Github PK

python-paho-mqtt-for-aws-iot's Issues

Risk: over-authorization of AWS IoT policy

Clarification on thingName and ClientID

Problem with subscription

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent