marian13 / convenient_service Goto Github PK

What is the issue?

• Result.new or Result#initialize do NOT trigger config commitment when they are called before any other plugin method, but config is NOT committed yet.

What is the issue?

• stub_service does NOT mock in combination with delegate_to.

When it happens? How to reproduce it?

• Try to uncomment the spec in cowsay_spec.rb.

  context "when `out` is NOT passed" do
    include ConvenientService::RSpec::Helpers::StubService
     
    it "defaults to `stdout`" do
      stub_service(described_class::Services::Print).to return_success
     
      expect { described_class.print(text) }
        .to delegate_to(described_class::Services::Print, :result)
        .with_arguments(text: text, out: $stdout)
    end
  end

• Then run specs.

  task rspec -- spec/lib/convenient_service/examples/standard/cowsay_spec.rb 

Where it happens?

• It does NOT depend on the environment. Fails for all Rubies.
• RSpec 3.

How big is the damage from it?

• Minimal. For now, such a combo is rare.

Why it happens?

• allow ... and_wrap_original inside delegate_to overrides allow ... and_wrap_original inside stub_service.
• According to the RSpec own specs and internal implementation ignoring the previous and_wrap_original is expected behavior.

What can be done to resolve it?

• See #27

What is the complexity of a possible fix?

• Looks hard. Maybe a hack is needed. More precise ETA after a deeper investigation.