motor's People
motor's Issues
Refactor needed!
I've read your code and I can have some feedbacks for you
- Keep your code consistent, you should always add space between
if
,(
and{
and they shouldn't be placed on difference lines.
if (condition) {
}
-
Keep your class methods small, some methods are very heavy (contains many lines of code). You can split it to smaller methods which do exactly 1 actions. For instance the
onCreate
method ofMainActivity.java
, you can split it tobindElements
,setUpFirebase
,setUpToolbar
and so on. -
Remove duplications in code. SharedPreference's actions can be encapsulated to a util class.
-
Remove unused codes (codes which are greyed by editor)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.