Problem loading datatables JS breaks javascript for site about moodle-report_advancedgrading HOT 12 CLOSED

Thank you for reporting this (and especially the console message) Can you go to settings and uncheck
enable_javascriptlayout. It will work without js, you just wont be able to sort columns.
And let me know if the issue goes away.

from moodle-report_advancedgrading.

Hi Marcus: NO the setting enable_javascriptlayout makes no effect. The navigation is broken both with that enable or disabled. The problem is there, it doesn't go away.

Actually, a grep in the code locates NO use for that setting in the report_advancedgrading folder. Only referenced in settings and in lang, no actual code, PHP or JS seems to be using it.

I've been able to avoid the problem only by removing completely the amd folder.
Even keeping the amd folder and commenting out
$PAGE->requires->js_call_amd('report_advancedgrading/table_sort', 'init');
makes NO effect.

Other assignments, with other rubrics and different status (other submissions settings, graded and ungraded students) show other errors in the browser console, for instance

Uncaught Error: No define call for report_advancedgrading/table_sort
http://requirejs.org/docs/errors.html#nodefine

event.js:5189:91082
Uncaught TypeError: a is undefined
e https://cvdev.ulpgc.es/moodle4test/lib/requirejs.php/1685461410/core/event.js:5189
https://cvdev.ulpgc.es/moodle4test/lib/requirejs.php/1685461410/core/event.js:5189
https://cvdev.ulpgc.es/moodle4test/lib/requirejs.php/1685461410/core/event.js:5189
execCb https://cvdev.ulpgc.es/moodle4test/lib/javascript.php/1685461410/lib/requirejs/require.min.js:5
check https://cvdev.ulpgc.es/moodle4test/lib/javascript.php/1685461410/lib/requirejs/require.min.js:5
f https://cvdev.ulpgc.es/moodle4test/lib/javascript.php/1685461410/lib/requirejs/require.min.js:5
each https://cvdev.ulpgc.es/moodle4test/lib/javascript.php/1685461410/lib/requirejs/require.min.js:5
f https://cvdev.ulpgc.es/moodle4test/lib/javascript.php/1685461410/lib/requirejs/require.min.js:5
f https://cvdev.ulpgc.es/moodle4test/lib/javascript.php/1685461410/lib/requirejs/require.min.js:5
each https://cvdev.ulpgc.es/moodle4test/lib/javascript.php/1685461410/lib/requirejs/require.min.js:5
f https://cvdev.ulpgc.es/moodle4test/lib/javascript.php/1685461410/lib/requirejs/require.min.js:5
f https://cvdev.ulpgc.es/moodle4test/lib/javascript.php/1685461410/lib/requirejs/require.min.js:5
each https://cvdev.ulpgc.es/moodle4test/lib/javascript.php/1685461410/lib/requirejs/require.min.js:5
f https://cvdev.ulpgc.es/moodle4test/lib/javascript.php/1685461410/lib/requirejs/require.min.js:5
f https://cvdev.ulpgc.es/moodle4test/lib/javascript.php/1685461410/lib/requirejs/require.min.js:5
each https://cvdev.ulpgc.es/moodle4test/lib/javascript.php/1685461410/lib/requirejs/require.min.js:5
f https://cvdev.ulpgc.es/moodle4test/lib/javascript.php/1685461410/lib/requirejs/require.min.js:5
l https://cvdev.ulpgc.es/moodle4test/lib/javascript.php/1685461410/lib/requirejs/require.min.js:5
each https://cvdev.ulpgc.es/moodle4test/lib/javascript.php/1685461410/lib/requirejs/require.min.js:5
l https://cvdev.ulpgc.es/moodle4test/lib/javascript.php/1685461410/lib/requirejs/require.min.js:5
completeLoad https://cvdev.ulpgc.es/moodle4test/lib/javascript.php/1685461410/lib/requirejs/require.min.js:5
onScriptLoad https://cvdev.ulpgc.es/moodle4test/lib/javascript.php/1685461410/lib/requirejs/require.min.js:5

from moodle-report_advancedgrading.

I expect you have already tried this but can you confirm you have purged caches?

from moodle-report_advancedgrading.

Oh, yes, of course, and tried several browsers.

from moodle-report_advancedgrading.

If commenting out
$PAGE->requires->js_call_amd('report_advancedgrading/table_sort', 'init');
Does not address it, I am very puzzled.
Let me set up a course with and without this on the same setup as you.
Can you confirm the Moodle version and that you have reproduced with core/boost theme

from moodle-report_advancedgrading.

As I just commented in the context related ticket, this is interesting. I just setup a fresh Moodle 4.2, installed the plugin and as you said, it broke all the javascript everywhere all at once. Commenting out the call to that javascript in the PHP didn't make it go away (or purging caches afterwards). The only fix was to delete the amd/build folder. As this is not essential to the plugin and it depends on jquery which will be removed from Moodle within a few versions, I will remove this capability from the plugin. I cannot give any timescale however.

from moodle-report_advancedgrading.

I had exactly the same problem in one of my installations (Moodle 4.2). As soon as the plugin is installed, it breaks the navigation on all pages through a JavaScript error.
I could then replicate the problem in two instances by adding respectively removing the plugin.
Removing the AMD folder also solved the problem.

from moodle-report_advancedgrading.

Thanks Mattias. I am away all this week (at MoodleDach). I will look into this when I return.

from moodle-report_advancedgrading.

Hi Marcus

I have also come across this issue in Moodle 4.1.4 (Build: 20230612)] and have removed the plugin for the time being. I appreciate you have been away but do you happen to have any idea of an eta for a fix at all?

Many thanks
Sarah

from moodle-report_advancedgrading.

Hi,

We've been testing this plugin without issues on Moodle 4.1 until we've installed 4.1.4 and then we've suffered this issue both with Boost and other Boost based themes; maybe looking at the core changes of the last minor gives you a clue about the cause:

https://moodledev.io/general/releases/4.1/4.1.4

from moodle-report_advancedgrading.

I was at MootDACH last week and have discussed this with Sarah who posted above. Prior to 4.X there were intermittent problems, since 4.X there have been widespread problems with this. My solution is to remove the datatables functionality and code. It was always more a "nice to have" than essential. I will post here when I start work on it. I will included the missing get_strings as well.

from moodle-report_advancedgrading.

I am closing this ticket as the latest release has removed datatables both to fix this problem and because Moodle is moving away from any use of JQuery. If anyone would like to provide a pull/fork that keeps this I will attempt to maintain a paralell branch with that support. I won't put it in the main branch for deployment to moodle.org as I feel it is likely to trigger more support than I am willing to do. Thank you for your feedback.

from moodle-report_advancedgrading.