Javascript ordering and pagination isn't localized about moodle-report_advancedgrading HOT 4 CLOSED

Hi, thank you for the feedback, I will investigate. Interestingly I have found a way of adding tests to confirm that MLang filters work with automated testing. See here
https://github.com/marcusgreen/moodle-qtype_gapfill/blob/master/tests/behat/multilang.feature

from moodle-report_advancedgrading.

Hi, as for may 2023, some parts are NOT localized.
The table header calls {{{studentheaders}}} structure to add the student names and ID number.

This structure is populated in locallib.php, function header_fields(), from $data['profilefields']
But the raw (internal) field name is used rather than get_string($field)

So, rather than
$data['studentheaders'] .= "<th " . $data['headerstyle'] . ">" . ucfirst($field) . "";

use,
$data['studentheaders'] .= "<th " . $data['headerstyle'] . ">" . get_string($field) . "";

By the way, if uppercase or not should belong to lang file.

from moodle-report_advancedgrading.

Thank you Enrique, thank you for the detailed information. I will take a look at that with a view to fixing in the near future. And yes, generally the case should be left to the lang file.

from moodle-report_advancedgrading.

I am closing this as the latest release has localised the PHP and removed the javascript. Please create a new ticket if I have missed localisation anywhere else. Many thanks for your feedback, you have helped improve the plugin.

from moodle-report_advancedgrading.