plotter: AddActor method does not update the renderer about vedo HOT 4 CLOSED

Works for me, thanks!

from vedo.

You are right in saying that add() and remove() have different behaviors.. and that'snot so elegant..

We currently have 2 ways of adding objects:
vp += actor
and
vp.add(actor)

if we require a call to interatctor.Render() this would cause a delay in loops (for ex. simmulations/brownian2D becomes 40% slower..).
What about a mixed solution like this, similar to what you propose:
(in plotter.py line ~650)

    def __iadd__(self, actors):
        self.add(actors, render=False) #here the default would be false
        return self

#...
    def add(self, actors, render=True): #here the default would be true
        """Append input object to the internal list of actors to be shown.

        :return: returns input actor for possible concatenation.
        """
        if utils.isSequence(actors):
            for a in actors:
                if a not in self.actors:
                    self.actors.append(a)
                    if render and self.renderer:
                        self.renderer.AddActor(a)
            if render and self.interactor: 
                self.interactor.Render()
            return None
        else:
            self.actors.append(actors)
            if render and self.renderer:
                self.renderer.AddActor(actors)
                if self.interactor:
                    self.interactor.Render()
            return actors

let me know your thoughts! m.

from vedo.

Marco,

How much do you care about backward compatibility? If you want to preserve that then the default argument should be False.

Just to be clear, it is the interactor.Render() than actually causes the delay? If that is the case then I would:

• omit the input argument, add the actors and skip the interactor.render().
• The interactor.render() can then be made into a separate method (plotter.refresh_view() ? ) as it would need to be called after plotter.delete() as well.

from vedo.

interactor.Render() is indeed the bottleneck which is done mainly in show().. I went on with the above changes in the current release, I don't think there are major issues with backwards compatibility.
Thanks again for your feedback and help.
M.

from vedo.