marcom / rnastructure.jl Goto Github PK

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Don't warn when env vars DATAPATH, CYCLEFOLD_DATAPATH already set correctly

Currently we warn in __init__() if these env vars are already set. Don't warn if they are already set to what we would want to set them anyway.

This avoids unnecessary warnings, for example when running the tests after the package has already been loaded with using.

Accidentally overriding DATAPATH, CYCLEFOLD_DATAPATH should be harder

If DATAPATH or CYCLEFOLD_DATAPATH are already set, e.g. because another RNAstructure version has been installed on the system independently of julia, and these env vars are set in .bashrc, then this package will nearly silently (it will issue an @info, nothing more) use the wrong parameters.

Solution: use RNASTRUCTURE_JLL_DATAPATH, RNASTRUCTURE_JLL_CYCLEFOLD_DATAPATH env vars to override these vars in this package.

Example: https://github.com/marcom/RNAstructure.jl/actions/runs/5320855306/jobs/9635178575

run_CycleFold: Test Failed at D:\a\RNAstructure.jl\RNAstructure.jl\test\RNAstructure.jl:473
  Expression: ps == 0
   Evaluated: 3221225477 == 0

• investigate for which inputs this happens, check if upstream issue

• re-enable windows CI testing, perhaps by just marking this test as broken on windows