Open in JOSM not working for bounding box about osm-sidewalker HOT 2 CLOSED

I did a little digging on this:

Essentially, in this line: https://github.com/mapbox/osm-sidewalker/blob/mb-pages/index.src.js#L111 the callback passed to .featuresIn never gets called.

If you swap out the style to the older mapbox style id, and change the layer name to old-sidewalks-world then this works again. My guess is that this is something weird going on with the new mbtile or GL style?

Also, @tcql do you think this needs to be an issue in Mapbox GL JS? I guess even if there is something wrong with the layer, the callback should always be called, either with an error or a list of features?

from osm-sidewalker.

This is a combo of two things. Mapbox studio seems to retain sources even if they are hidden or removed from a style. Gl-js featuresIn seems to fail when a source exists but doesn't have a visible layer.

Once I can put together a good example of this, I'll ticket both projects. I fixed by adding back the old sidewalks layer in my studio style and moving it behind the background, do that out exists but can't be seen visually

from osm-sidewalker.