There are three .map files that fail to load. Are they actually needed? @Rub21 - please fix or remove them.

It would be really cool to have total count for all edits by the team members in a day. I have been using this information in the weekly data activity ticket. @Rub21 is it possible to add this?

cc @geohacker @planemad

Make it easy to add a user, instead of github issues on this repository.

@Rub21 @arunasank The updates are missing since 11th March. Can you check what is wrong?

@Rub21 -

OSM-Edit-Report is showing Zero edits for most of us. Can you please look into this issue.

cc @geohacker @batpad

@Rub21 -

OSM-Edit-Report is showing Zero edits for most of us. Can you look into this issue.

Next Actions

• @Rub21 finds out the problem
• @shravan91 confirms that the OSM edit report is working with @Rub21 closes this ticket.

arun@arun-ghoomakad:~/Documents/Work/mapbox/report-dt/get_data$ cd ../get_data && npm install
npm WARN package.json [email protected] No description
npm WARN package.json [email protected] No README data
\
> [email protected] preinstall /home/arun/Documents/Work/mapbox/report-dt/get_data/node_modules/zlib
> node-waf clean || true; node-waf configure build

sh: 1: node-waf: not found
sh: 1: node-waf: not found

npm ERR! [email protected] preinstall: `node-waf clean || true; node-waf configure build`
npm ERR! Exit status 127
npm ERR! 
npm ERR! Failed at the [email protected] preinstall script.
npm ERR! This is most likely a problem with the zlib package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-waf clean || true; node-waf configure build
npm ERR! You can get their info via:
npm ERR!     npm owner ls zlib
npm ERR! There is likely additional logging output above.
npm ERR! System Linux 3.13.0-45-generic
npm ERR! command "/usr/bin/node" "/usr/bin/npm" "install"
npm ERR! cwd /home/arun/Documents/Work/mapbox/report-dt/get_data
npm ERR! node -v v0.10.33
npm ERR! npm -v 1.4.28
npm ERR! code ELIFECYCLE
npm ERR! not ok code 0

From stackoverflow, node has inbuilt support for zlib.

Everything still seems to work, but we can probably remove zlib from package.json.

When using the num_file and num_directory parameters from the readme it gave errors.
For --num_file=1 --num_directory=0
No file found url:https://s3.amazonaws.com/osm-changesets/hour/000/000/001.osc.gz
For --num_file=177 --num_directory=20
No file found url:https://s3.amazonaws.com/osm-changesets/hour/000/020/177.osc.gz

Was checking parameters for more recent files and at least with --num_file=1 --num_directory=25 it began running:

Start download : https://s3.amazonaws.com/osm-changesets/hour/000/025/003.osc.gz ---> /tmp/003.osc
Process file :/tmp/003.osc
Remove file :/tmp/003.osc
fin
Start download : https://s3.amazonaws.com/osm-changesets/hour/000/025/004.osc.gz ---> /tmp/004.osc
Process file :/tmp/004.osc
Remove file :/tmp/004.osc
fin

On another note, is this same load process used to keep database up-to-date after the initial load?

We just shipped a new API. This currently gives changes every minute for every data team members with nodes, ways, relations, and tags created, modified or deleted.

@rasagy @ajithranka @kepta @batpad @Rub21 - let's use this ticket to start outlining a new front-end. We should start fresh.

The JSON object returned by osm-edit-report-service.mapbox.com contains a values array for each user. This array contains objects in the form

{ 
  "x":<date-object>,
  "y":<no-of-objects-modified>,
  "change":<no-of-changesets>
}

To make this more readable, osm-edit-report-service.mapbox.com, the values array could contain objects in the form

{ 
  "date":<date-object>,
  "objects":<no-of-objects-modified>,
  "changesets":<no-of-changesets>
}

Right now object/changeset counts are displayed with UTC timeline. Would be great if there is an option to view the same in local timings (IST and Peru).

cc @arunasank @geohacker

@Rub21 - Added users @ramyaragupathy and Kshitiz

Ramya Ragupathy
ksharma198

@Rub21 can you update @bkowshik's OSM user name to the edit report. bkowshik

@Rub21 -

I have removed kshitiz sharma from the edit report.

Next Actions

• @Rub21 to run the server
• @shravan91 to check if the graph is updated

Currently the data overlaps. The SVG layouting needs to be fixed to get this to work, without names of editors bleeding out of the svg.

cc @geohacker @Rub21 @batpad

@Rub21 -

We need to remove Jinal from the OSM-edit-report.

Next Actions

• @Rub21 removes the user
• @shravan91 checks the graph and closes this issue

@Rub21 -

I have removed user har777 from the query/add_user.sql table.

Next Actions

• @Rub21 to run the the production server and close this ticket

@Rub21 - the app is hosted now under https://www.mapbox.com hence it won't be able to pull content from a non-SSL connection. Let's move the server under a Mapbox domain, too.

It's not clear what report-dt means. What about osm-user-report or something like that? cc @lxbarth @Rub21

osm-edit-report-service.mapbox.com should also accept 'w' as a parameter and return weekly stats. Currently this is done on the client side in the new frontend.

cc @Rub21 @geohacker @batpad

Last week I've spent some hours doing some counter for the team, basically, this will count w/ high detail the progres of each of the data-team member. right now this si alive https://osm-edit-report-production.mapbox.com/json/m&1483833600&1484524800, running with osm-edit-report on the same server, and it is assets the number of roads which touched by the data-team.

• The counter is updating every hour.
• We can make consult by hour, day, month and year.
• Easily add more tags to count we just need to add in https://s3.amazonaws.com/tofix/osmEditReport/tags.json

I think this could help the number of edition and objects made by data-team, along with osm-metrics, I this case, we don't need to run any query. just add in the s3 file tags.json the tags.

What is missing here?

• A front-end and a good way to display all the numbers.

cc. @ramyaragupathy @arunasank @planemad @maning

Problem:

• Right now, when visiting the report for the first time, the page does not show any data

Solution:

• By default, show daily edits for last week

To avoid any possibilities of SQL injection, parameterized queries should be used.

• https://github.com/brianc/node-postgres/wiki/FAQ#8-does-node-postgres-handle-sql-injection
• Example https://github.com/brianc/node-postgres/wiki/Client#method-query-parameterized

This should be used anywhere where you're using a variable in a query statement, for example:

• https://github.com/mapbox/report-dt/blob/dev/load.js#L111
• https://github.com/mapbox/report-dt/blob/dev/load.js#L118
• https://github.com/mapbox/report-dt/blob/dev/load.js#L120
• https://github.com/mapbox/report-dt/blob/dev/server.js#L40
• https://github.com/mapbox/report-dt/blob/dev/server.js#L51
• https://github.com/mapbox/report-dt/blob/dev/server.js#L61
• Where else?

1. Be able to search for and select a user.
2. Be able to select/unselect all users.

@Rub21

I added har777 to the add_user.sql table.

The graph still does not show his OSM username.

I also found out the karitotp is not in the table but her name shows up on the graph

cc- @planemad

Certain kinds of edits are fast (like building tracing), and others can become more involved (complex turn restrictions). It would be useful to see team edits filtered by "fast" vs "complicated" editing tasks.

Implementing this is more complicated. Requires architectural changes to access actual changeset feature geometries, and rules/algorithms to segment edits by type.

Here https://github.com/mapbox/report-dt/blob/dev/server.js#L17-L22

instead of argv.user, argv.port, etc., you could use postgres environment variables which may give people more flexibility in handling these credentials on their server.

The numbers display in overlap when there are more than 3 digit. is therea way to fix it.

@arunasank @geohacker

@Rub21 -

Added Nikhil Prabhakar U to OSM-edit report

Next Actions

• @Rub21 deploys this change (5cc8537) on the server and closes the ticket

@Rub21 - We are facing a concern while we spool the data for our daily Mapping scrum report.

• Dates mismatched - If we need to spool a report from 2nd - 6th of Feburary 2015,we need to select dates from 1st -7th Febuary 2015 and the dates do not match with the edits done for the previous day/week.

Please check the below screenshot - Edits done on the 2nd of Febuary 2015 are showing for the 3rd of Feburary.

cc: @lxbarth @shvrm @shravan91 @srividyacb @geohacker

Currently the object is in the form

[
     {
          "key": <editor's name>,
          "color": <data-color>,
          "iduser": <editor's OSM id>,
          "values": [
                         {
                              "x": <first-date-object-in-date-range>,
                              "y": <objects-modified>,
                              "change": <changesets-created>
                         },
                         {
                              "x": <second-date-object-in-date-range>,
                              "y": <objects-modified>,
                              "change": <changesets-created>
                         },
                         ....
                         ....
                         {
                              "x": <last-date-object-in-date-range>,
                              "y": <objects-modified>,
                              "change": <changesets-created>
                         }
                     ]
     }
   ...
   <more such objects>
   ..........
]

Besides renaming keys as suggested in mapbox/osm-edit-report#31, each user object can include the following keys:

• total-objects which contains the total number of objects modified by that user in the requested time range.
• total-changesets which contains the total number of changesets created by that user in the requested time range.

The color key in each user object can be removed since this is done in the front end.

The array of user objects can be nested in a parent object containing the following keys:

• total-objects which contains the total number of objects modified by all users in the requested time range.
• total-changesets which contains the total number of changesets created by all users in the requested time range.
• active-users which is an array of names of all active users (or a key active in each user object set to either true or false.)

Adding the above three consolidated keys will also be useful to resolve mapbox/osm-edit-report#35.

cc @Rub21, @geohacker, @batpad.

OSM Edit report graphs are not showing and it keeps loading up.

cc @Rub21

@Rub21 @tmcw - longer term, how could we use Stickshift to power OSM edit reports? https://github.com/mapbox/stickshift

• For an example of our report-dt's are used https://github.com/mapbox/data/issues/807#issuecomment-74202296
• Functioning instance is on @Rub21's server right now http://rub21.github.io/report-dt/#d&2015-02-06&2015-02-12

cc @aaronlidman @geohacker @planemad

@Rub21, seria bueno añadir el detalle de que es lo que se esta modificando/agregando por usuario, por ejemplo cuantas calles y cuantas relaciones se modificó.

@Rub21

I have added Chetan_Gowda to the add_user.sql table. @Rub21 - could you please update on the server.

Something like ^?

Missing correct user names: aarthy and jinalfoflia. These are the correct usernames of Aarthy and Jinal Foflia. Can you guys update the query.

@Rub21 @arunasank

• Needs an entry in README explaining how to set up report-dt

Trying to use OSM Bright 2 tile layer in and of a section of Shanghai and when I am at 15 + zoom layer, the characters for street names and locations are breaking.

STR

1. Go to this url: http://bit.ly/1R6GkTV (uploaded MapBox layer to CartoDB)
2. Zoom in to a 15 level

Expected Behavior: To see english characters as labels on streets and buildings
Actual Behavior: English characters as labels for some locations, [][][] for other locations

Error found in MapBox Studio

I suspect it has something to do with the unicode, any suggestions on how to fix this issue and reproduce the proper tiles?

[please let me know if I should report this issue in a different issues repo]

--user -> --pguser
--database -> --pgdatabase

This looks like debug code, should it be removed? https://github.com/mapbox/report-dt/blob/dev/server.js#L23

Currently osm-edit-report-service.mapbox.com returns both data for objects modified and changesets created depending on the dates. Instead, it can accept another parameter, called stats maybe, that takes in two values, objects or changesets and returns only relevant data.

cc @Rub21 @geohacker @batpad

OSM edit report needs node version >= 0.6.13 < 0.11.0 for the npm install to work. This needs to be mentioned in the README. More information - such as installing ’n’ as opposed to ‘nvm’, to use the required node version.

Specific instructions for OSX - you need essentials, wget and n before being able to install osm-edit-report.

"$postgres createdb dbstatic" -> Was simply "$createdb dbstatic". Also a note to install postgres from http://postgresapp.com/ instead of the graphical installer, for OSX or the many other versions would be useful.

need a mapbox icon
https://www.mapbox.com/img/favicon.ico

@Rub21 - I have added @pratikyadav and @jinalfoflia to the OSM Edit report

Next Actions:

• @Rub21 to update and run the script on the server to add them on the OSM-edit-report

@Rub21 - looking at https://github.com/mapbox/report-dt/blob/mb-pages/install.sh I don't think it's relevant anymore.

• Calls npm install in a directory that does not contain a package.json file
• Let's not have platform specific install.sh files in a repo, running this on Mac OSX will just fail. To keep it simple, let's just document installation in README instead #2