Giter Club home page Giter Club logo

reddsaver's People

Contributors

kdkasad avatar manojkarthick avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

reddsaver's Issues

App creating sub-directories with underlined filenames

I installed the 2.2 binaries and ran the app, and downloaded the files in a new folder for a quick comparison with the files downloaded using the previous version. I've found two probably undesired behaviours, one of them I'm reporting on this ticket: when reddsaver tries to download files whose post titles contain underlines, a new sub-directory (sometimes 2 nested sub-directories) are created, like this (download directory is ./folders_02):

~/reddsaver 2.2/folders_02/osr/face_folio_|a_little_preview_of_some_concept_sketches(100_pc/underlined_filename.jpg

The files end up in the nested sub-directory, though.

[Feature Request] Option to change output format

by default the script will put all saved media in folders according to their subreddit.
I'm not really interested in this folder structure, as i only have a huge image dump. Would it be possible to change the output format to different folder-structures/ no folder structes at all?

(awesome script btw)

reddsaver: error while loading shared libraries: libssl.so.1.1: cannot open shared object file: No such file or directory

I am using archlinux and reddsaver is giving me an error

reddsaver: error while loading shared libraries: libssl.so.1.1: cannot open shared object file: No such file or directory

-rwxr-xr-x 1 root root 415K Jun 5 20:01 libssl3.so
lrwxrwxrwx 1 root root 11 May 30 21:44 libssl.so -> libssl.so.3
-r-xr-xr-x 1 root root 498K Jun 1 20:16 libssl.so.1.0.0
-rwxr-xr-x 1 root root 636K May 30 21:44 libssl.so.3

can you help me please!

Failure when reddit password includes a dollar sign

This may be of limited relevance now that access to reddit’s API is about to become restricted/expensive but I noticed today that if the user’s password in the .env file includes a dollar sign $ the script throws an error:

Error: ReqwestError(reqwest::Error { kind: Decode, source: Error("missing field `access_token`", line: 1, column: 26) })

error at launch: missing field `access_token`

App lauching with all env variables throw this error istantly.

Error: ReqwestError(reqwest::Error { kind: Decode, source: Error("missing field access_token", line: 1, column: 95) })

Runned of macOS, tried homebrew version and release 0.4.0

Missing field: "access_token"

When running the script
reddsaver -e reddsaver.env -d .

it immediately interrupts because of the following error:

Error: ReqwestError(reqwest::Error { kind: Decode, source: Error("missing field access_token", line: 1, column: 95) })

Any ideas where this is coming from? I have no knowledge of Rust, but tried to find where the error might be, could not find a way to resolve.. thanks a lot

Three videos being saved for each video

For every video the tool currently downloads, three different videos are saved: one with without audio, one with audio, and the audio only. I assume this is something to do with ffmpeg, but shouldn't it delete the other two once the video with audio is made?

Error: EnvVarNotPresent(NotPresent)

I've followed the instructions and made sure that the .env file holds correct data, and to unset the USERNAME system variable.

However, I'm getting the error "Error: EnvVarNotPresent(NotPresent)" both in cmd.exe, powershell and under WSL with linux binaries. What could be causing this error?

Fails when encountering media from gfycat

When the script comes to media from gfycat (which no longer resolves / exists), the following error is generated and the script stops running: "failed to lookup address information: Name or service not known"

Multi-image posts not being downloaded

Beginning on 2.2 (running binaries) with human-readable option active, reddsaver is no longer downloading all the images in multi-image posts, just one for each post.

--human-readable flag tries to create invalid filenames on Windows

Hello!

I'm using Windows 10. Reddscaver, when using the --human-readable flag, will try to faithfully reproduce Reddit post titles as filenames that include invalid characters like "?". This results in a "WARN reddsaver::download] Could not create a file with the name: reddsaver/exampleSubreddit/this_is_an_example?_t3_abcdef.jpg. Skipping" and nothing is saved.

Ideally Reddsaver would strip invalid characters before attempting to save.

missing feild 'access token'

I've installed using cargo and when I run the script I get:

λ ~/Downloads/Programs/reddsaver reddsaver -e reddsaver.env -d ~/Pictures/reddit/
Error: ReqwestError(reqwest::Error { kind: Decode, source: Error("missing field `access_token`", line: 1, column: 26) })

Picks up Windows USERNAME instead of the variable from env

As the title says, this happens on Win10. unset USERNAME doesn't do anything on Windows. I think it is a better solution if you change the name of the variable for the username, or add a clause to README on how to do this on Windows.

Thank you for an awesome work which I have yet to get it to working. lol

Meanwhile, I am going to give this a shot on WSL

Header user-agent is missing

This used to work for me but suddenly all new downloaded files have a size of 29 bytes and only contain this text:

Header user-agent is missing.

Any idea what the issue is?

Unable to get access token

Installed in archlinux from the AUR repository.
I followed the running instructions in this page.
The command "reddsaver -e reddsaver.env -d reddsaver --show-config" didn't show configuration errors.
But the next command did:

 % reddsaver -e reddsaver.env -d reddsaver  
Error: ReqwestError(reqwest::Error { kind: Decode, source: Error("missing field `access_token`", line: 1, column: 41) })

Dunno what to do.

Feature: Download and merge audio track for videos

First of all, thank you for reddsaver!

I appears like right now, reddsaver only downloads the video track for video files, which sadly makes it virtually useless for video downloads as they come without their audio tracks. Other tools like youtube-dl support downloading the audio track and merging the two back to the complete video file, and it would be great if reddsaver supported this, as well. It could be accomplished e.g. by integrating ffmpeg.

[feature request] Interactive request for credentials

I'd really like to not have my password in plaintext on my disk. It would be great if I could do one of the following:

  1. get prompted for my password and TOTP code (and maybe even username) at runtime
  2. set a command to get my password (e.g. for use with https://www.passwordstore.org/) and TOTP code

Somewhat-related:

Passwords may contain the : character, so I don't think that's a good separator for the PASSWORD env var. Maybe a separate TOTP env var should be used?

The unsave flag is more destructive than it appears and could use a warning.

Using the -U flag with reddsaver unsaves whatever it skips, not just what it successfully downloads.

I was hoping to use this function to free up access to saved posts after the 1000 post limit. However it caused some issues.

In my case (running Windows 10 with the human readable flag):

  • It unsaved posts that had a WARN (as in this issue). This is fine because I can go back through the log and find the posts on reddit again manually.

  • It unsaved self-posts/text posts. This is worse as it doesn't log these and I have lost hundreds of self-posts I had saved.

It is my fault for making assumptions about the functionality, but I think this should be mentioned somewhere so others don't lose their saves.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.