mannew / vilfo-api-client-python Goto Github PK

Please see home-assistant/core#113245

This is the error we're seeing during the testing of the above PR:

==================================== ERRORS ====================================
_________ ERROR collecting tests/components/vilfo/test_config_flow.py __________
ImportError while importing test module '/home/runner/work/core/core/tests/components/vilfo/test_config_flow.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/components/vilfo/test_config_flow.py:4: in <module>
    import vilfo
venv/lib/python3.11/site-packages/vilfo/__init__.py:5: in <module>
    from .client import (
venv/lib/python3.11/site-packages/vilfo/client.py:7: in <module>
    from semver import compare as semver_compare
E   ModuleNotFoundError: No module named 'semver'

It is caused by the plugwise-backend module removing the semver dependency in this PR, which breaks the vilfo-backend module.

Please also see frenck's comment in the Core PR.

The 'get-mac' dependency being used by this integration, is being moved to a new name 'getmac'. Both packages internally contain a 'getmac' python package. At some point the 'get-mac' will no longer be updated.

The 'homeassistant' project uses plugins/integrations, each of which is developed by independent developers and it was found that some integrations used 'get-mac' such as vilfo-api-client-python, and others use 'getmac' and so they conflict.

This issue is to request that the vilfo-api-client-python moves to use getmac instead of get-mac to help remove this conflict and also help this project receive future updates in the newer getmac package.