Giter Club home page Giter Club logo

Comments (2)

ronny1982 avatar ronny1982 commented on May 11, 2024

This issue seems to be so simple, but in fact it is quite troublesome to solve for the current versions of electron for the following reasons:

  • the bundled chromium browser does not allow to call confirm() within the onbeforeunload event
  • trying to use the dialog provided by electron did also not work since this seems not to be shown modal and the application will just quit ignoring the dialog
  • showing the dialog outside of the render process will work, but then the web-application has no control over the decision when to show a confirmation and when not

from hakuneko.

ronny1982 avatar ronny1982 commented on May 11, 2024

The implementation has been changed and the confirm() method has been replaced to call a synchronous confirmation dialog in the render thread instead of the chromium confirmation dialog.

However, the window still closes even when cancel the confirmation dialog (except when the develper console is open, then it works as expected)

This seems to be a bug in electron itself: electron/electron#9966

from hakuneko.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.