Comments (2)
This issue seems to be so simple, but in fact it is quite troublesome to solve for the current versions of electron for the following reasons:
- the bundled chromium browser does not allow to call
confirm()
within theonbeforeunload
event - trying to use the dialog provided by electron did also not work since this seems not to be shown modal and the application will just quit ignoring the dialog
- showing the dialog outside of the render process will work, but then the web-application has no control over the decision when to show a confirmation and when not
from hakuneko.
The implementation has been changed and the confirm()
method has been replaced to call a synchronous confirmation dialog in the render thread instead of the chromium confirmation dialog.
However, the window still closes even when cancel the confirmation dialog (except when the develper console is open, then it works as expected)
This seems to be a bug in electron itself: electron/electron#9966
from hakuneko.
Related Issues (20)
- [<cypherscans>] Connector not working HOT 2
- [Bug] Hakuneko not installing in Ubuntu 22 HOT 11
- docker version HOT 1
- [Site Request] VF Scan HOT 1
- [Feature] Option to disable Comicinfo file included in cbz download by default HOT 10
- [WestManga] Domain Change
- [Shinigami ID] Downloads aren't working HOT 1
- [Site Request] Sushi-Scan HOT 4
- [Site Request] Lethe Scans HOT 1
- [Site Request] Turkmanga HOT 1
- [Site Request] NyxManga HOT 1
- [<mangaokutr>] Connector not working HOT 1
- [Bug] New installation of Haku Neku wiped old bookmarks-file when it was pointed to the old bookmarks path
- Saikai Scan HOT 1
- [Site Request] Mangalek HOT 6
- mangadistrict HOT 4
- [MangaHub.io] Connector not working HOT 2
- [Site Request] NewManhua
- [<LezhinUS>] Connector not working HOT 1
- [Site Request] RawXZ
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hakuneko.