[Feature] Option to disable Comicinfo file included in cbz download by default about hakuneko HOT 10 OPEN

I'd basically go with new setting with default settings enabled ("yes include commicbookinfo") meaning that for people that are unsatisfied by latest PR they still have an opt-out scenario

from hakuneko.

Another idea would be to add a new format option

• Comic Book Archive (*.cbz)
• Comic Book Archive with Info (*.cbz)

from hakuneko.

Not a bug but a feature enhancement request.
It's been in nightly branch for 6 months

from hakuneko.

Any problem with that file?

from hakuneko.

the downloaded cbz file itself doesn't have problems in terms of usage, other than the comic info file being included.

From the messages in the merged pull request mentioned, it looked like including comic info file should have been defaulted to be not included, and there should have been a checkbox in the settings to enable or disable inclusion. But as mentioned, I didn't see the option in the settings.

Did I read it wrong?

from hakuneko.

This was changed after a review of the lead dev and the original title wasn't changed :
#6102 (comment)

from hakuneko.

So the question is: is there a request (and a use case) for this to be optional ?

from hakuneko.

It would be nice for it to be optional, as I usually rename the files afterwards, and I'd like for the reader I use to show the file in the format I renamed to, but with the comicinfo file present, it takes the name as shown in the comicinfo file.

If it's too much of a bother, It's fine. I'll just try and figure out a way to remove or edit the comicinfo file when I rename cbz files.

from hakuneko.

Nah it's a valid request then. Could be easily integrated.
@ronny1982, any second thoughts on that one ?

from hakuneko.

I was hesitant to approve the mentioned PR since HakuNeko is actually feature complete, but was swayed by the effort the contributor put into.

Unfortunately now this leads to more maintenance work :(

Options:

• Revert PR that introduced the info file
  ➔ User group A is going to be unsatisfied
• Leave as is
  ➔ User group B is going to be unsatisfied
• Introduce a new setting to enable/disable info file
  ➔ This leads to a new discussion, what should be the default value as one of the user groups would need to change it?

I would prefer Leave as is.

from hakuneko.