malinkinsa / asyncgelf Goto Github PK

Is your feature request related to a problem? Please describe.
For lightweight setups we'd want to minimize dependencies. Technically 'httpx' is only required for HTTP handler but not for TCP and UDP.

Describe the solution you'd like
Wrap 'httpx' import into try..except and remove from required dependencies.

Describe alternatives you've considered
No.

Additional context
No.

Hello,

I've successfully used your library.
I just had to make a modification that could be interesting to add to the default one.

The timestamp parameter

In the GELF documentation there is this parameter that is crucial to have them nicely saved on graylog.

As I've used this library to ingest old logs I wanted to forcefeed the timestamp into the GELF.

I had to add in the library the timestamp in

• def init with Optional[int] =None
• self.timestamp=timestamp
• gelf_message = {... 'timestamp':self.timestamp}

In my code I've used int(datetime.strptime(<variable_from_log>, <timeformat>).timestamp()) to get the right format of my original time from the log. It worked.

I was just wondering if there is a more "elegant" way to integrate it in the library.

Thanks

Describe the bug
(

in the line above sync call from async happens.

To Reproduce

Minimal code example:

import asyncio
import asyncgelf
handler = asyncgelf.GelfUdp(host='127.0.0.1')
asyncio.run(handler.udp_handler({'text': 'yo!'}))

Expected behavior
Actually I think that it's also extremely useful to have both sync and async interfaces. So the expected behaviour is sync calls to happen synchronously and async to happen asynchronously.

Additional context
So the current implementation for GelfUdp from what I can see is pretty much sync, and the GelfUdp.make_gelf_chunks() is sync as well.