makieorg / makiethemes.jl Goto Github PK

if this is coming back, maybe better to have it in the Makie Org, @SimonDanisch ?

Seems like a conflict with the rest of the plotting ecosystem. Why is it needed anyway? I understand that GPL is viral, but can the look of a plot be copyrightable?

When using your theme package, I noticed that the frame as you can see on the left and bottom of the plot is missing.

without frame

with frame (like intended)

When searching for the source of this problem I saw that the frames attribute was properly set on the axis2d object. However that did not result in the wanted frame.

I found out, that setting the frames attribute on the axis object instead of the axis2d would produce our frame. Do you know if this would be an AbstractPlotting Error or something to correct in your Package?

following code did the quick fix:

import MakieThemes
const mt = MakieThemes
t = mt.ggthemr(:fresh)
t.axis.frame.frames = t.axis2d.frame.frames

The REQUIRE file could not be found.
cc: @SimonDanisch

Would be nice to maybe depend on PerceptualColourMaps.jl for this. The current colormaps are just formed by two colors, which I would like to move past in the long term.

Hi!
I saw that in your project.toml version is still 0.0.1 - but in registry etc. it is 0.0.2

Maybe this is the reason I always get downgraded to CairoMakie 0.3 (super old) or GLMakie 0.1.3 (superold)?

Try it yourself e.g. in pluto

begin
	using Pkg
	using CairoMakie
	using MakieThemes
	#Figure()
	Pkg.resolve()
	Pkg.update()
	Pkg.status(;outdated=true)
end

⌃ [13f3f980] CairoMakie v0.3.4 [<v0.3.19], (<v0.10.2)

If I manually run ]dev MakieThemes - it works though, indicating something messed up with the versioning - and the Project.toml missmatches, so maybe that is the issue?

Best, Benedikt

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

I tried this code:

using Makie
using MakieThemes
show_ggthemr(:fresh)

and get this output:

I suppose this is not meant to be like that, but should be more colorful as indicated on
https://github.com/JuliaPlots/MakieThemes.jl

Any ideas? I'm on julia 1.4 on windows 10.

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Windows (x86_64-w64-mingw32)
  CPU: Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, skylake)
Environment:
  JULIA_EDITOR = "C:\Users\joach\AppData\Local\Programs\Microsoft VS Code\Code.exe"
  JULIA_NUM_THREADS = 8

Would be nice to have utils which "expand" a figure with a logo/source bar a la ggplot, or something else. We need to figure out a nice API for this.

It seems like the Axis options that are passed through to the plots are intended for 2d not 3d plots, and they don't seem to function when in 3d plots - you get dimension mismatch errors. Is there any way we could alleviate this?

As I understand it, Themes are just a set of attributes passed naively to the plotting function. Is it possible to select which attributes to pass to Axis3d v/s Axis2d? Would go a long way to making this feature-complete.

Would it be ok to allow gitkraken to push to the org. It's just a git gui.