We need to log FC removals from the waitlist, and just for shits and giggles can we log all invites/removals. Who when and why.

• Update logs to text file so names are included. IDs are painful as fuck
• Log all invites, removals and fleet joins in a database table, then create a filterable view.

That is, if we even want to keep it. I'm not sure I care enough.

Bug Description

The join the waitlist, and the queue info panels are visible where there are no active fleets. We can look at putting something there but for now it should just be the 'Waitlist Inactive' banner and any FC banner message that is currently being used for the alpha notice.

Reproduction Steps

Close any open fleets and go to the / route.

Expected Outcome

Remove pilot panels on the left.

Notes

We could look at putting some cool things in there long term. Maybe focus stats during an active deployment, and in between deployment focus information while we are waiting for a spawn. Just a thought.

Bug Description

When an invite is sent they get highlighted and then stay there. They are not removed from the waitlist

Reproduction Steps

Expected Outcome

Actual Outcome

Notes

@Makeshift please replace the font awesome four CDN (CSS File) with the font awesome five <script defer src="https://use.fontawesome.com/releases/v5.0.2/js/all.js"></script> script.

Bootstrap tool-tips also needs to be bootstrap documentation.

• Ajax
• Sockets

I DON'T KNOW WHICH ONE TO PICK

Bug Description

Table spews of the side of the screen. This makes me hate myself ALOT.

Reproduction Steps

Look at commander on a small screen (tablet).

TODO

Use bootstrap classes to make this less crappy on small screens..... All other FC pages should be looked at as well, though the actual waitlist page may not be done.

Maybe?

Just a thought.

https://eveonline-third-party-documentation.readthedocs.io/en/latest/sso/intro.html

The Eve CDN has actually been updated to have the login images so we should use those.

The changes @samuelgrant made to remove the languages and tickboxes means that routes.js might now be picking up a bunch of null data. I'll look into that later.

Bug Description

Clicking on "Remove all alts" queued me up.

Reproduction Steps

Click on "Remove all alts" and watch.

Expected Outcome

"Remove all alts" working.

Actual Outcome

"Remove all alts" not working.

Notes

grr

Bug Description

http://img.scassany.space/AXqBy8Ne.png

Reproduction Steps

make a fleet, add some people to it, look at the fleet at a glance

Expected Outcome

It doesn't look like shit

Actual Outcome

It looks like shit

Notes

Waitlist will occasionally mess with the order of waitlistee's due to mongo.

Fix: Have them return in order of when they signed up.

Let's get the I am the FC buttons done next time you have a few minutes. They should work something like this:

• I'm the FC can be used to force the waitlist to update the FC object, so it can continue to use the token. If the token fails (Wrong FC) then don't delete the fleet, disable ESI actions for that fleet and display a banner prompting the new FC to press the button.
• Back seating FC button should have two states. One that allows you to set yourself as the backseat, and one that lets you remove yourself as the backseat.

@Makeshift let me know what you think

New fleets should be registered as Not Listed. There is already an option in the dropdown box for this.

This allows an FC to set up the required options / in game things before publicly opening the waitlist. If the only fleet is not listed, the public UI should render as if there were no fleets up. However, setting the fleet to that mode should not act in the same was as closing the waitlist (should not remove all pilots from the waitlist).

Either give us a check box, or show us people who have been in fleet for less than five hours. That way we can make sure we bring them in on a safe site (TPPH/NRF) and give them some extra attention such as a quick newbro speech

Bug Description

Reproduction Steps

Expected Outcome

Actual Outcome

Notes

There is no bug, there is a slight design problem. The style Samuel created is great, but it has a small issue. The red border on the active input text field confuses new people to think that the page does not like what they're typing. I'd recommend changing this color to something more neutral.

Now that the I'm the FC button works (or should work), can you please either extend the amount of time the new FC has to press the button after a star handover or after x number of failed queries unset the FC object and block all fleet related ESI queries until a new FC is set.

Remember the class of the nav element. If the user collapses or expands the nav bar it should persist through page loads.

• Currently on page loads it will always be expanded.

Bug Description

A shiptype name that is too long really fucks up the waitlist

Reproduction Steps

Put a name like "megamegamegamegamegamegamegamegamegamegamegamegamegamegamegamegamegamegamegamegamegamegamegamegamegamegamegamegamegamegamegamegamegamegamega"

Expected Outcome

It doesn't look like shit

Actual Outcome

It looks like shit

Notes

I'm gay

Stuff won't load properly if they're offline.

Unhandled rejection esi:Error: Error from ESI service for https://esi.tech.ccp.is/v1/fleets/1025011408543/members/: {"error":"{'error_label': 'FleetCandidateOffline', 'error_dict': {'invitee': (2, 95334207)}}"}: cannot POST /v1/fleets/1025011408543/members/?datasource=tranquility&language=en-us (420)
    at getExceptionFromAgentError (/home/user/eve-goons-newwaitlist/eve-goons-waitlist/node_modules/eve-swagger/lib/internal/esi-agent.js:82:17)
    at /home/user/eve-goons-newwaitlist/eve-goons-waitlist/node_modules/eve-swagger/lib/internal/esi-agent.js:243:22
    at Request.callback (/home/user/eve-goons-newwaitlist/eve-goons-waitlist/node_modules/superagent/lib/node/index.js:703:3)
    at IncomingMessage.<anonymous> (/home/user/eve-goons-newwaitlist/eve-goons-waitlist/node_modules/superagent/lib/node/index.js:922:12)
    at emitNone (events.js:91:20)
    at IncomingMessage.emit (events.js:185:7)
    at endReadableNT (_stream_readable.js:974:12)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)

Okay, good job, you made your own shitty templating engine. Now got and get a real one.

Fix those

Bug Description

Reproduction Steps

We don't know

Expected Outcome

Show ship names and a count or failing that ship IDs and a count.

Notes

If you can give me show info windows (#22) in game then the user could click on a fleet ID and still see the ship type. Not perfect but it will help.

As the scree resizes, text overflows off the buttons for join, leave and update on the public waitlist page.
@samuelgrant needs to address CSS.

Bug Description

cant select/copy any text

Reproduction Steps

try to select/copy some text

Expected Outcome

text gets selected and then copied

Actual Outcome

nothing gets selected

Notes

A user revoking their refresh token while logged in kills the app when they try and do anything with the ESI. If any ESI request comes back with 'invalid token' we should forcefully log the user out and delete their session.

2018-02-22T12:58:14.585Z [error] getLocation: Error for requestNewAccessToken {"err":{"statusCode":400,"data":"{\"error\":\"invalid_token\",\"error_description\":\"The refresh token is expired.\"}"},"characterID":96099470}

Per changes in #23 an FC can now select 'Arse fleet' in the Fleet Type section of their management panel.

If they do pilots will see:
Fleet Type: "Long Deployment" - or something like this
Fleet Doctrine: "Arsefleet"

If the FC selects (HQs/Ass/Vgs/Kundi ) then pilots would see
Fleet Type: what ever was selected by the FC
Fleet Doctrine: "Mainfleet"

Description

It would be nice to allow the waitlist to invite people to a specific squad rather than the default squad. What we should do is replace the green plus button with a drop-down nav button. Then list each squad in say wing one and allow fcs to click on the squad they want to put the person in.

At the same time the fleet comp should only show people in the 'active wing'. That way I don't see scouts/cynos that are in fleet in that comp window.

Usecase

• Arsefleet legions are both DPS and Logi ships. This means the fleet at a glance tab won't help. Having a logi squad vs a dps squad could allow the FC to get a better view of how many legions are logi vs dps.
• Being able to add people into separate squads minimizes the risk of a squad commander accidentally warping the entire fleet off grid.
• People will end up in the expected squads rather than the one ESI puts them in.
• If FCs max squads at 14 people + the squad commander, squad commanders could add their squads to their watchlists as a form of AFK checking pilots.

Bug Description

At least one external URL "breaking" the SSL encryption:
image.eveonline.com

Expected Outcome

Should be called by https://

• WITH COLORS
• AND DIFFERENT OUTPUT TYPES (info, error, debug etc.)
• NOT IN STUPID PLACES
• TO A FILE! (I know this is revolutionary)

Assuming the pilot has provided us with their ESA name in the format of samuel_the_terrible, we can have a button that allow the FCs to contact a pilot via jabber.

This could be added to the pilot function drop-down menu on the waitlist page /commander/:fleetID/. This would be useful if the FC needs to talk to the pilot in private about an issue stopping them from getting into fleet, or informing a pilot they cannot login after DCing from a TCRC.

<a href="xmpp:[email protected]">Testing Jabber Link</a>

Bug Description

When inviting a user their row is highlighted green. If the invite succeeds they are removed from the database and view. If the invite fails, they stay highlighted green. This persists through page refreshes.

Reproduction Steps

Invite a player who is offline, in another fleet or who rejects the invite.

Expected Outcome

Clicking the invite button makes the users row go blue. After the invite is sent through ESI successfully the database record should be deleted and for the FC who pressed the invite button the row should go green for 10 seconds before it is deleted.

If the invite fails, the row should go red (only for the FC who clicked invite) and it should not persist past a page refresh.

Notes

Color classes:

• invite-pending (when a user clicks invite; this class should be used pending a sent or failed response)
• invite-sent (if ESI accepts the fleet invite request - this does not mean the user accepted the invite, just that they received an invite).
• invite-failed (Invite failed (The pilot did not get sent an invite) - could be due to the user being offline, in a fleet, fleet being full)

Bug Description

Trying to register a fleet with the wrong pilot (One not authed) returns an error that the waitlist cannot handle. Attempting to load the page kills node, after five time outs the fleet page will then load but I cannot transfer the waitlist boss.

Expected Outcome

An error that states the fleet cannot be registered.

Actual Outcome

      throw err;
      ^

TypeError: Cannot read property 'length' of null
    at module.exports (P:\xampp\htdocs\waitlist\eve-goons-waitlist\pageContent\fcFleetList.js:31:46)
    at P:\xampp\htdocs\waitlist\eve-goons-waitlist\template.js:21:7
    at sidebar (P:\xampp\htdocs\waitlist\eve-goons-waitlist\template.js:114:3)
    at P:\xampp\htdocs\waitlist\eve-goons-waitlist\template.js:20:5
    at header (P:\xampp\htdocs\waitlist\eve-goons-waitlist\template.js:43:5)
    at generateTemplate (P:\xampp\htdocs\waitlist\eve-goons-waitlist\template.js:19:3)
    at Object.pageGenerate (P:\xampp\htdocs\waitlist\eve-goons-waitlist\template.js:12:3)
    at P:\xampp\htdocs\waitlist\eve-goons-waitlist\routes.js:115:14
    at P:\xampp\htdocs\waitlist\eve-goons-waitlist\fleets.js:88:4
    at args.push (P:\xampp\htdocs\waitlist\eve-goons-waitlist\node_modules\mongodb\lib\utils.js:404:72)
    at handleCallback (P:\xampp\htdocs\waitlist\eve-goons-waitlist\node_modules\mongodb\lib\utils.js:128:55)
    at self.close (P:\xampp\htdocs\waitlist\eve-goons-waitlist\node_modules\mongodb\lib\cursor.js:934:60)
    at handleCallback (P:\xampp\htdocs\waitlist\eve-goons-waitlist\node_modules\mongodb\lib\utils.js:128:55)
    at completeClose (P:\xampp\htdocs\waitlist\eve-goons-waitlist\node_modules\mongodb\lib\cursor.js:1073:14)
    at Cursor.close (P:\xampp\htdocs\waitlist\eve-goons-waitlist\node_modules\mongodb\lib\cursor.js:1086:10)
    at P:\xampp\htdocs\waitlist\eve-goons-waitlist\node_modules\mongodb\lib\cursor.js:934:21```

#### Notes
Once I handed over the star in game and waited a minute I was unable to transfer fleet boss in waitlist.... I had to close and create a new fleet with the same link.

• Hyperlinks for ship/pilot/corporation/constellation names should open a 'show info' window in game.
• System names should set the destination (After clearing the current autopilot)
• Ship icons (for pilot fits) should open a UI... haven't worked that one out yet.

Bug Description

There is too long between queuing for fleet and being accepted to fleet

Reproduction Steps

Queue for fleet

Expected Outcome

It doesn't take ages

Actual Outcome

It takes ages

Notes

Blame samuel for this

Give the FC an indicator of what language a pilot speaks so we have an idea who might need a translator.

oops

The t at the end of fleet management is visible on the wait-list if the navbar is hidden on a smaller screen.

Bug Description

Each new fleet lists down. They should go left to right dropping to a new line as needed.

Reproduction Steps

Open multiple fleets.

Expected Outcome

They should list in rows across before dropping down.

Actual Outcome

Notes

Check cols sizes.

Checklist:

• Login Oauth2
• Pilot settings table of alts and login button
• Select alt dropdown on /commander/:name/skills
• List of alts on /admin/commanders
• List of alts on /commander/:name:/profile
  • Design view for waitlisting with alts
  • Code waitlisting with main
  • Code leaving waitlist with all (Big red button)
  • Code Queue Info (Waitlist Main)
  • Code Queue Info (Your Position)
  • Code alts waitlist panel
    • Listing Alts (Not already in fleet)
    • Code add specific alt
    • Code remove specific alt
  • Render main/alts table (see below)
    • Code More Actions
    • Code removals
    • Code Invites
    • Code Invite Alarms
    • Code Alarm User
    • Code "Newbee" label - Still need the check to determine who is new and who isn't
    • Code "alt of" label

NOTE: Todo add character whitelist. All waitlist joins need to be vetted for online and whitelist

Other Things:

• Validate user is online before they waitlist up
• Validate user is online every timer() cycle as a verification that their token is still good
• Move timers to the task system
• Character whitelist function

Main:
object.waitlistMain.characterID == object.characterID

Alt:
object.waitlistMain.characterID != object,characterID

Waitlist table object template
{
	_id: objectID,
	"waitlistMain": {
		"characterID": null,
		"name": null
	},
	"name": Caitlin Viliana,
	"characterID": 96304094,
	"fit",
	"location": {
		"systemID": 1322112,
		"name": 1DQ1-A,
		"docked": false
	},
	contact: {
		"xmpp": samuel_the_terrible,
		"alarmTarget": 96304094
	},
	new: true
	signup: Date.now(),
}

1. We were going to have an alts table under the main table for waitlists. I think I would like to move them to their own tab. If sockets will let you do fully async then all the tables should be able to update without page refreshes.

2. Alts on waitlist should only be visible to the fleet their main is in.

Newbee Indicator

• This will be covered as part of alts. After a person has been with us for x number of sites remove the newbee flag.

If screens shrink too far the input fields become too small. @samuelgrant needs to investigate an alternative layout

Fix that.

The more actions dropdown box :a class is taking the colouring from the table rows.

Goal: Make the dropdown box consistent regardless of the state of the row (keep it white, not green/grey/red/black whatever).

If the waitlist attempts to make ESI requests on a fleet that is no longer active in game CCP will return this error. {'what': 'The specified proxy or server node (1392245) is dead'}}"}.

To combat this issue the following safeguards should be completed:

• Auto close all registered fleets at 11:00 Eve time.
• Allow FCs to manually close fleets using the fleet management page.

Currently a lot of the page generation relies on synchronous stuff which is super terrible and will cause issues in the future. It REALLY needs to be made into async, probably at about the same time data is moved into an actual database.

To keep the waitlist as current as possible, when the last open fleet is closed the waitlist should be cleaned removing all pilots.

This should also occur automatically at downtime: see issue #16 .

Urgency: Low

An example of a popup when selecting fits to add to the waitlist would be great.

Just.... don't ask