Giter Club home page Giter Club logo

Comments (9)

mbanzon avatar mbanzon commented on August 21, 2024

I see the problem - do you/we know if the domain used for stored messages is always the same?

This seems very odd - the tests run - and I can't see anything strange in those.

from mailgun-go.

daBrado avatar daBrado commented on August 21, 2024

I do not know if it is always the same... though the documentation for messages says (https://documentation.mailgun.com/api-sending.html#retrieving-stored-messages):

To retrieve an inbound message that has been stored via the store() action, use the URL found in the stored event (which you can find through the Events API, or in the notify webhook set when creating the store action (store(notify="http://mydomain.com/callback")).

...which would seem to suggest that one should use the URL as given, I think?

from mailgun-go.

daBrado avatar daBrado commented on August 21, 2024

Given the documentation quoted above, would it be preferrable to have the StoredMessage methods take the url value directly instead of the key value? Trying that in a local copy of the mailgun-go repo where I just bypass the generateStoredMessageUrl function seems to work fine.

Or are there cases where you would have the message key but not its url, and/or is that too much of a change in expectations for the argument for those methods?

from mailgun-go.

luxifer avatar luxifer commented on August 21, 2024

I have the same problem, since stored message are not always on the main API domain, this wrapper is not able to fetch stored messages. I had to create a custom function to get the stored message by its url.

from mailgun-go.

mbanzon avatar mbanzon commented on August 21, 2024

@luxifer is that something we can get into the library?

from mailgun-go.

luxifer avatar luxifer commented on August 21, 2024

I'll see. Not as is, but it is possible

Le 4 sept. 2016 5:55 PM, "Michael Banzon" [email protected] a
Γ©crit :

@luxifer https://github.com/luxifer is that something we can get into
the library?

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#64 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZlBnUpoQ0Dqz1byRyz6Q26zoNFwE9uks5qmuoBgaJpZM4Jsxej
.

from mailgun-go.

james-lawrence avatar james-lawrence commented on August 21, 2024

its a 4 line change to fix the GetMessage functions in the library to just take the url.

from mailgun-go.

thrawn01 avatar thrawn01 commented on August 21, 2024

Pull requests welcome, if you have a fix.

from mailgun-go.

mbanzon avatar mbanzon commented on August 21, 2024

@thrawn01 do we know if this is still an issue?

from mailgun-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.