Comments (9)
I see the problem - do you/we know if the domain used for stored messages is always the same?
This seems very odd - the tests run - and I can't see anything strange in those.
from mailgun-go.
I do not know if it is always the same... though the documentation for messages says (https://documentation.mailgun.com/api-sending.html#retrieving-stored-messages):
To retrieve an inbound message that has been stored via the
store()
action, use the URL found in the stored event (which you can find through the Events API, or in the notify webhook set when creating the store action (store(notify="http://mydomain.com/callback")
).
...which would seem to suggest that one should use the URL as given, I think?
from mailgun-go.
Given the documentation quoted above, would it be preferrable to have the StoredMessage
methods take the url
value directly instead of the key
value? Trying that in a local copy of the mailgun-go repo where I just bypass the generateStoredMessageUrl
function seems to work fine.
Or are there cases where you would have the message key
but not its url
, and/or is that too much of a change in expectations for the argument for those methods?
from mailgun-go.
I have the same problem, since stored message are not always on the main API domain, this wrapper is not able to fetch stored messages. I had to create a custom function to get the stored message by its url.
from mailgun-go.
@luxifer is that something we can get into the library?
from mailgun-go.
I'll see. Not as is, but it is possible
Le 4 sept. 2016 5:55 PM, "Michael Banzon" [email protected] a
Γ©crit :
@luxifer https://github.com/luxifer is that something we can get into
the library?β
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#64 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZlBnUpoQ0Dqz1byRyz6Q26zoNFwE9uks5qmuoBgaJpZM4Jsxej
.
from mailgun-go.
its a 4 line change to fix the GetMessage functions in the library to just take the url.
from mailgun-go.
Pull requests welcome, if you have a fix.
from mailgun-go.
@thrawn01 do we know if this is still an issue?
from mailgun-go.
Related Issues (20)
- Remove dependancy on Chi
- Make fields public in struct `mailgun.Message`. HOT 3
- SetDeliveryTime Ignored HOT 1
- Change response for `VerifyDomain` method from (string, error) to (DomainResponse, error) HOT 2
- How to convert json stored messages to url.Values HOT 1
- Make properties on Message struct publicly accessible HOT 2
- missing `result` in email validation response HOT 4
- VerifyAndReturnDomain is missing from the Mailgun interface
- Validate domain in mg.Send()
- Allow to use : in domain for testing HOT 2
- Inline image example should have img tag in html input HOT 1
- events.ClientInfo is missing the `bot` field HOT 2
- Add 'web_scheme' as a primary attribute to Domain HOT 3
- Set preferred reply method for mailing lists missing HOT 1
- [Feature Request] Add Send Time Optimization (STO) Feature HOT 3
- Ability to add multiple webhooks for same events.
- panic: runtime error: invalid memory address or nil pointer dereference On GetStoredAttachment
- GetMailingList returns empty struct even though address is present HOT 4
- SDK doesn't return errors for email send failures
- Remove dependency on github.com/go-chi/chi/v5 (again)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mailgun-go.