missing `result` in email validation response about mailgun-go HOT 4 CLOSED

Seems like there are multiple discrepancies between the API and V4 structs in the library. E.g. is_valid is assumed to be present, but I can find no mention it in the docs for API V4.

Manual testing via curl also shows no is_valid field:

$ curl --user 'api:***' -G \
    https://api.mailgun.net/v4/address/validate \
    --data-urlencode address='[email protected]'

{"address":"[email protected]","is_disposable_address":false,"is_role_address":false,"reason":["unknown_provider"],"result":"deliverable","risk":"medium"}

$ curl --user 'api:***' -G \
    https://api.mailgun.net/v4/address/validate \
    --data-urlencode address='foo@'

{"address":"foo@","is_disposable_address":false,"is_role_address":false,"reason":["malformed address; failed parse checks"],"result":"undeliverable","risk":"high"}

I would assume result has superseeded is_valid in the newer versions of API. Perhaps if the same result structure is used for both V3 and V4 in the library, IsValid should be mapped according to result and perhaps other fields.

from mailgun-go.

Yeah, I think in this library they want to ensure the backward compatibility between v3 and v4, so that's why it's used the same struct in v3 and v4

Mapping the result values into is_valid field would not solve the problem when we want to handle different logic based on the result values. Because is_valid only contains true or false.

If we look at this PR #244, he just adds some new field in v4EmailValidationResp and EmailVerification struct

from mailgun-go.

@riskimidiw Let me know if I missed anything. #265

from mailgun-go.

@thrawn01 LGTM, Thank you for working on this issue 🙏🏻

from mailgun-go.