App Engine support about mailgun-go HOT 9 CLOSED

I have made a custom-client branch that supports alternative http.Clients - these are passed to simplehttp. I haven't had time to test it properly but it should work as intended with GAE eg.

from mailgun-go.

The simplehttp library has been fixed, but mailgun-go now needs to expose a way to pass an http.Client into simplehttp. One way to do this would be to add it as a field to MailgunImpl and call r.SetClient(mg.client) whenever we create a simplehttp request object.

from mailgun-go.

I am looking into it - but the fix won't be as smooth as in simplehttp.

from mailgun-go.

+1

from mailgun-go.

It does have quite a number of compilation errors :P Many places you used m.client to access the client, but the function context is actually called mg.

E.g. https://github.com/mailgun/mailgun-go/blob/custom-client/credentials.go#L22

from mailgun-go.

Oh my. I have no idea why that even compiled on my machine!

Thank you for the comment + PR.

from mailgun-go.

+1

from mailgun-go.

Why did this get closed? :(
Is app engine not going to be supported?

from mailgun-go.

Oh I see, it looks like SetClient was ultimately added to master branch. Spoke too soon, sorry for the noise! Thanks :D

from mailgun-go.