in build.rs

    // Only accept 2xx status codes
    if response.status_code() < 200 && response.status_code() >= 300 {
        panic!("Download error: HTTP {}", response.status_code());
    }

should be < 200 || >= 300

see #99

currently:

#[cfg(target_env = "msvc")] // libsodium-<VERSION>-msvc.zip
const SHA256: &'static str = "0580d54f57594a7cb493607cec6e7045369fb67d43623491523781e901589948";

is not covered by any tests on CI

the other hashes are covered

There are a few new releases of libsodium available (current version depends on 1.0.12). Changelog

Upgrading to 1.0.14 or later will also fix #16.

--- stderr
thread 'main' panicked at '
"powershell" "-Command" "If ($PSVersionTable.PSVersion.Major -lt 4) { exit 1 }"

You must have Powershell v4.0 or greater installed.

Currently sodiumoxide is looking for maintainership: https://github.com/dnaq/sodiumoxide/issues/203

As a user who recently switched from sodiumoxide to this library due to the static linking I wonder if it wouldn't make sense to merge those two projects together in some capacity?

this error:

= note: /usr/bin/ld: /tmp/rustc.ZbjniGJ7D9Ug/librust_sodium_sys-24ee5a8b5f6825c1.rlib(libsodium_la-aead_chacha20poly1305.o): relocation R_X86_64_PC32 against symbol `cr
ypto_aead_chacha20poly1305_encrypt_detached' can not be used when making a shared object; recompile with -fPIC

can appear when working with neon on linux even with pie disabled if build-essential is not installed

the readme implies (imo) that build-essential is only needed for cross compiling but it can show up in other edge cases it seems

unfortunately the linker error is very cryptic, it took me a long time to figure out that -fPIC is a red herring and that i was actually missing an apt-get dependency (newer gcc or something?)

Do you have any policy regarding tracking of changes from sodiumoxide?

For example, here is a feature that was recently added to sodiumoxide that I'd like to see in rust_sodium as well.

Do you plan on including sodiumoxide changes into rust_sodium from time to time, or would it be better to create a standalone pull request with the functionality?

We have moved to 1.16 and serde is now a reccommended and drop-in replacement for rustc-serialize for attribute deriviations of encodable and decodable. Rustc-serialize is going to be deprecated so we need to update to using serde (sodiumoxide is already using it).

When cargo tries to build the rust_sodium_sys package, it runs into several syntactical errors with make, cc, ar:

>cargo build
.......
ar: `u' modifier ignored since `D' is the default (see `U')
cc: error: 0: No such file or directory
cc: error: RESERVED_FUNCTION_POINTERS=8: No such file or directory
cc: error: unrecognized command line option '--memory-init-file'; did you mean '--warn-init-self'?
cc: error: unrecognized command line option '--pre-js'; did you mean '--prefix'?
make[3]: *** [Makefile:1194: aead_aes256gcm.js] Error 1
make[3]: *** Waiting for unfinished jobs....
cc: error: 0: No such file or directory
cc: error: RESERVED_FUNCTION_POINTERS=8: No such file or directory
cc: error: unrecognized command line option '--memory-init-file'; did you mean '--warn-init-self'?
cc: error: unrecognized command line option '--pre-js'; did you mean '--prefix'?
make[3]: *** [Makefile:1198: aead_chacha20poly1305.js] Error 1
make[2]: *** [Makefile:2176: check-am] Error 2
make[1]: *** [Makefile:394: check-recursive] Error 1
make: *** [Makefile:505: check-recursive] Error 1

', github.com-1ecc6299db9ec823/rust_sodium-sys-0.1.1/build.rs:233

The Argon2 password hashing algorithm has been in libsodium since 1.0.9 (released 2 Apr 2016), and it is now recommended over scrypt https://download.libsodium.org/doc/password_hashing/
Is there any plan to support it in rust_sodium ?

last release was a year ago

its impossible to publish crates to crates.io if they have a dependency on an unpublished crate

this makes changes like the recent bump to 1.4.0 (needed to unblock lots of other ecosystem crates, e.g. wasmer) impossible to use outside development until a new release is published

Thanks for providing this crate!

There is something that makes me a bit uneasy though, which is the fact that the downloaded libsodium library is not checked during the build.

Could we maybe verify SHA256 checksums of the downloads in the build script?

the build step that downloads the tarballs is a source of sporadic build failures for us

we see it both on CI and developing locally

occasionally something will go wrong in the download and the hash will be incorrect, failing the build in a very cryptic way

given that only one version at a time is supported anyway (1.0.16 atm) why not simply include the extracted tarball in this repo, or setup a git submodule or something?

Seems that because of the reqwest dependency for building, it also pulls in hyper-tls which uses openssl which is kind of unfortunate.

Hi!

We would like to port our tox-rs from sodiumoxide to your crate.
Is there anything we should know before we start porting our code to your crate? What's the difference between your crate and sodiumoxide?

There are some questions:

1. How do I use system libsodium to link it to rust_sodium-sys?
2. How do I force downloading and building libsodium even if I have an installed libsodium?
3. How do I tell rust_sodium to use libsodium from custom directory?

Did you test your crate on:

1. ArchLinux?
2. FreeBSD?
3. CentOS?

Hi, I'm currently trying to tidy up the bindings linked on the libsodium website. If this library is still maintained, then please let me know; otherwise, the link to this library will likely be removed from the bindings page to help users find up to date and maintained bindings.

I take it from #115 that it's not.

there's a new libsodium version released in jan 2019

https://download.libsodium.org/libsodium/releases/

1.0.17

error: failed to run custom build command for rust_sodium-sys v0.10.4

Caused by:
process didn't exit successfully: /Users/xxx/code/holochain/sim2h/target/debug/build/rust_sodium-sys-2e21ff8278bca277/build-script-build (exit code: 101)
--- stdout
cargo:rerun-if-env-changed=RUST_SODIUM_LIB_DIR
cargo:rerun-if-env-changed=RUST_SODIUM_USE_PKG_CONFIG
cargo:rerun-if-env-changed=RUST_SODIUM_SHARED
OPT_LEVEL = Some("0")
TARGET = Some("x86_64-apple-darwin")
HOST = Some("x86_64-apple-darwin")
CC_x86_64-apple-darwin = None
CC_x86_64_apple_darwin = None
HOST_CC = None
CC = Some("clang")
CFLAGS_x86_64-apple-darwin = None
CFLAGS_x86_64_apple_darwin = None
HOST_CFLAGS = None
CFLAGS = None
CRATE_CC_NO_DEFAULTS = None
DEBUG = Some("true")
cargo:rerun-if-env-changed=RUST_SODIUM_DISABLE_PIE

--- stderr
thread 'main' panicked at 'Failed to run './configure': No such file or directory (os error 2)
', /Users/xxx/code/holochain/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/rust_sodium-sys-0.10.4/build.rs:393:13
stack backtrace:
0: backtrace::backtrace::libunwind::trace
at /Users/vsts/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.29/src/backtrace/libunwind.rs:88
1: backtrace::backtrace::trace_unsynchronized
at /Users/vsts/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.29/src/backtrace/mod.rs:66
2: std::sys_common::backtrace::_print
at src/libstd/sys_common/backtrace.rs:47
3: std::sys_common::backtrace::print
at src/libstd/sys_common/backtrace.rs:36
4: std::panicking::default_hook::{{closure}}
at src/libstd/panicking.rs:200
5: std::panicking::default_hook
at src/libstd/panicking.rs:214
6: std::panicking::rust_panic_with_hook
at src/libstd/panicking.rs:477
7: std::panicking::continue_panic_fmt
at src/libstd/panicking.rs:384
8: std::panicking::begin_panic_fmt
at src/libstd/panicking.rs:339
9: build_script_build::get_libsodium::{{closure}}
at ./build.rs:393
10: core::result::Result<T,E>::unwrap_or_else
at /rustc/69656fa4cbafc378fd63f9186d93b0df3cdd9320/src/libcore/result.rs:818
11: build_script_build::get_libsodium
at ./build.rs:386
12: build_script_build::main
at ./build.rs:80
13: std::rt::lang_start::{{closure}}
at /rustc/69656fa4cbafc378fd63f9186d93b0df3cdd9320/src/libstd/rt.rs:64
14: std::rt::lang_start_internal::{{closure}}
at src/libstd/rt.rs:49
15: std::panicking::try::do_call
at src/libstd/panicking.rs:296
16: __rust_maybe_catch_panic
at src/libpanic_unwind/lib.rs:82
17: std::panicking::try
at src/libstd/panicking.rs:275
18: std::panic::catch_unwind
at src/libstd/panic.rs:394
19: std::rt::lang_start_internal
at src/libstd/rt.rs:48
20: std::rt::lang_start
at /rustc/69656fa4cbafc378fd63f9186d93b0df3cdd9320/src/libstd/rt.rs:64

warning: build failed, waiting for other jobs to finish...
error: build failed

Hi MaidSafe, thanks to #33 we are successfully building neon projects with libsodium cross-platform 🙂 ... well, almost.

When I try building rust_sodium in a Jenkins Windows job, I get the error "The system cannot find the path specified". On Linux and macOS there is no such problem... It is possible that this is a Jenkins error, but maybe you have an idea what this could be about?

Here is the full log:

[...]
Compiling rust_sodium-sys v0.2.0 (https://github.com/maidsafe/rust_sodium?rev=a1a17b261a0081b94e10179a11816c7894708f34#a1a17b26)
error: failed to run custom build command for `rust_sodium-sys v0.2.0 (https://github.com/maidsafe/rust_sodium?rev=a1a17b261a0081b94e10179a11816c7894708f34#a1a17b26)`
process didn't exit successfully: `C:\Users\jenkins\Documents\jenkins\workspace\Wrapper Windows Production\electron\node_modules\libsodium-neon\native\target\release\build\rust_sodium-sys-95df8c375f7de787\build-script-build` (exit code: 101)
--- stderr
thread 'main' panicked at '

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!   unwrap! called on Result::Err                                              !
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
C:\Users\jenkins\.cargo\git\checkouts\rust_sodium-55555f070d27ffcc\a1a17b2\rust_sodium-sys\build.rs:154,27 in build_script_build

Err(
    Error {
        repr: Os {
            code: 3,
            message: "The system cannot find the path specified."
        }
    }
)

', C:\Users\jenkins\.cargo\registry\src\github.com-1ecc6299db9ec823\unwrap-1.1.0\src\lib.rs:67
note: Run with `RUST_BACKTRACE=1` for a backtrace.

neon ERR! cargo build failed

Thanks in advance for your help!